Skip to content

Commit b91a240

Browse files
authored
Merge pull request #61 from doubleSlashde/bugfix/css_Warnings
changed rootItem to be created once and children changes, solves reap…
2 parents ca7795f + 15bd18f commit b91a240

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/main/java/de/doubleslash/keeptime/view/ReportController.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,8 @@ public class ReportController {
118118

119119
private LocalDate currentReportDate;
120120

121+
private final TreeItem<TableRow> rootItem = new TreeItem<>();
122+
121123
@Autowired
122124
public ReportController(final Model model, final Controller controller) {
123125
this.model = model;
@@ -185,11 +187,13 @@ protected void updateItem(final TableRow item, final boolean empty) {
185187

186188
workTableTreeView.setShowRoot(false);
187189

190+
workTableTreeView.setRoot(rootItem);
191+
rootItem.setExpanded(true);
188192
}
189193

190194
private void updateReport(final LocalDate dateToShow) {
191195
this.currentReportDate = dateToShow;
192-
196+
rootItem.getChildren().clear();
193197
reportRoot.requestFocus();
194198

195199
this.currentDayLabel.setText(DateFormatter.toDayDateString(this.currentReportDate));
@@ -204,8 +208,6 @@ private void updateReport(final LocalDate dateToShow) {
204208
long currentWorkSeconds = 0;
205209
long currentSeconds = 0;
206210

207-
final TreeItem<TableRow> root = new TreeItem<>();
208-
209211
for (final Project project : workedProjectsSet) {
210212
final List<Work> onlyCurrentProjectWork = currentWorkItems.stream().filter(w -> w.getProject() == project)
211213
.collect(Collectors.toList());
@@ -234,12 +236,10 @@ private void updateReport(final LocalDate dateToShow) {
234236
}
235237

236238
projectRow.setExpanded(true);
237-
root.getChildren().add(projectRow);
239+
rootItem.getChildren().add(projectRow);
238240

239241
}
240242

241-
root.setExpanded(true);
242-
workTableTreeView.setRoot(root);
243243
this.currentDayTimeLabel.setText(DateFormatter.secondsToHHMMSS(currentSeconds));
244244
this.currentDayWorkTimeLabel.setText(DateFormatter.secondsToHHMMSS(currentWorkSeconds));
245245

0 commit comments

Comments
 (0)