Skip to content

Commit bf4478b

Browse files
committed
#178: fix tests
1 parent 2a496db commit bf4478b

File tree

1 file changed

+5
-14
lines changed

1 file changed

+5
-14
lines changed

src/test/java/de/doubleslash/keeptime/controller/HeimatControllerTest.java

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
import de.doubleslash.keeptime.rest.integration.heimat.HeimatAPI;
1010
import de.doubleslash.keeptime.rest.integration.heimat.model.HeimatTask;
1111
import de.doubleslash.keeptime.rest.integration.heimat.model.HeimatTime;
12-
import de.doubleslash.keeptime.view.MapExternalProjectsController;
1312
import javafx.scene.paint.Color;
1413
import org.hamcrest.Matchers;
1514
import org.junit.jupiter.api.BeforeEach;
@@ -80,10 +79,9 @@ void shouldSaveNewMappingWhenMappingDidNotExistBefore() {
8079
// ARRANGE
8180
final List<HeimatController.ProjectMapping> newMappings = Arrays.asList(
8281
new HeimatController.ProjectMapping(workProject1, heimatTask1));
83-
final List<HeimatController.ProjectMapping> existingMappings = Arrays.asList();
8482

8583
// ACT
86-
heimatController.updateMappings(newMappings, existingMappings);
84+
heimatController.updateMappings(newMappings);
8785

8886
// ASSERT
8987
ArgumentCaptor<List<ExternalProjectMapping>> saveMappingsCaptor = ArgumentCaptor.forClass(List.class);
@@ -101,11 +99,10 @@ void shouldNotSaveOrRemoveAnythingWhenMappingDidNotChange() {
10199
// ARRANGE
102100
final List<HeimatController.ProjectMapping> newMappings = Arrays.asList(
103101
new HeimatController.ProjectMapping(workProject1, heimatTask1));
104-
final List<HeimatController.ProjectMapping> existingMappings = Arrays.asList(new HeimatController.ProjectMapping(workProject1, heimatTask1));
105102
externalMappings.add(project1To1Mapping);
106103

107104
// ACT
108-
heimatController.updateMappings(newMappings, existingMappings);
105+
heimatController.updateMappings(newMappings);
109106

110107
// ASSERT
111108
ArgumentCaptor<List<ExternalProjectMapping>> saveMappingsCaptor = ArgumentCaptor.forClass(List.class);
@@ -125,12 +122,10 @@ void shouldUpdateMappingWhenExistedBeforeButChanged() {
125122
// ARRANGE
126123
final List<HeimatController.ProjectMapping> newMappings = Arrays.asList(
127124
new HeimatController.ProjectMapping(workProject1, heimatTask2));
128-
final List<HeimatController.ProjectMapping> existingMappings = Arrays.asList(
129-
new HeimatController.ProjectMapping(workProject1, heimatTask1));
130125
externalMappings.add(project1To1Mapping);
131126

132127
// ACT
133-
heimatController.updateMappings(newMappings, existingMappings);
128+
heimatController.updateMappings(newMappings);
134129

135130
// ASSERT
136131
ArgumentCaptor<List<ExternalProjectMapping>> saveMappingsCaptor = ArgumentCaptor.forClass(List.class);
@@ -153,12 +148,10 @@ void shouldRemoveMappingWhenMappingDoesNoLongerExist() {
153148
// ARRANGE
154149
final List<HeimatController.ProjectMapping> newMappings = Arrays.asList(
155150
new HeimatController.ProjectMapping(workProject1, null));
156-
final List<HeimatController.ProjectMapping> existingMappings = Arrays.asList(
157-
new HeimatController.ProjectMapping(workProject1, heimatTask1));
158151
externalMappings.add(project1To1Mapping);
159152

160153
// ACT
161-
heimatController.updateMappings(newMappings, existingMappings);
154+
heimatController.updateMappings(newMappings);
162155

163156
// ASSERT
164157
ArgumentCaptor<List<ExternalProjectMapping>> saveMappingsCaptor = ArgumentCaptor.forClass(List.class);
@@ -179,12 +172,10 @@ void shouldRemoveMappingWhenMappingDoesNoLongerExist() {
179172
void shouldRemoveMappingWhenProjectWasDeleted() {
180173
// ARRANGE
181174
final List<HeimatController.ProjectMapping> newMappings = Arrays.asList();
182-
final List<HeimatController.ProjectMapping> existingMappings = Arrays.asList(
183-
new HeimatController.ProjectMapping(deletedProject, heimatTask1));
184175
externalMappings.add(deletedProjectTo1Mapping);
185176

186177
// ACT
187-
heimatController.updateMappings(newMappings, existingMappings);
178+
heimatController.updateMappings(newMappings);
188179

189180
// ASSERT
190181
ArgumentCaptor<List<ExternalProjectMapping>> saveMappingsCaptor = ArgumentCaptor.forClass(List.class);

0 commit comments

Comments
 (0)