Skip to content

Commit cd4e588

Browse files
author
Martin Plieske
committed
refactored dialogResultConverter method
1 parent ca70845 commit cd4e588

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

src/main/java/de/doubleslash/keeptime/view/ViewController.java

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,9 @@
5656
import javafx.scene.canvas.GraphicsContext;
5757
import javafx.scene.control.Button;
5858
import javafx.scene.control.ButtonType;
59-
import javafx.scene.control.CheckBox;
60-
import javafx.scene.control.ColorPicker;
6159
import javafx.scene.control.Dialog;
6260
import javafx.scene.control.Label;
6361
import javafx.scene.control.ListView;
64-
import javafx.scene.control.Spinner;
6562
import javafx.scene.control.TextArea;
6663
import javafx.scene.control.TextField;
6764
import javafx.scene.effect.Light;
@@ -310,14 +307,17 @@ private void initialize() {
310307
private Dialog<Project> dialogResultConverter(final Dialog<Project> dialog) {
311308
dialog.setResultConverter(dialogButton -> {
312309
if (dialogButton == ButtonType.OK) {
313-
final TextField nameTextField = manageProjectController.getNameTextField();
314-
final TextArea descriptionTextArea = manageProjectController.getDescriptionTextArea();
315-
final ColorPicker textFillColorPicker = manageProjectController.getTextFillColorPicker();
316-
final CheckBox isWorkCheckBox = manageProjectController.getIsWorkCheckBox();
317-
final Spinner<Integer> indexSpinner = manageProjectController.getSortIndexSpinner();
318-
return new Project(nameTextField.getText(), descriptionTextArea.getText(), textFillColorPicker.getValue(),
319-
isWorkCheckBox.isSelected(), indexSpinner.getValue()); // temporary (misused) transfer object for
320-
// project
310+
final String projectName = manageProjectController.getProjectName();
311+
final String projectDescription = manageProjectController.getProjectDescription();
312+
final Color projectColor = manageProjectController.getProjectColor();
313+
final boolean isWork = manageProjectController.isWork();
314+
final int index = manageProjectController.getIndex();
315+
return new Project(projectName, projectDescription, projectColor, isWork, index); // temporary
316+
// (misused)
317+
// transfer
318+
// object
319+
// for
320+
// project
321321
}
322322
// TODO: Do you really want to return null?
323323
return null;

0 commit comments

Comments
 (0)