PTBAS-738: set tooltup directly during label creation. rename, comments

Author: Death111

src/main/java/de/doubleslash/keeptime/view/ExternalProjectsSyncController.java

@@ -282,11 +282,6 @@ protected void updateItem(List<Project> item, boolean empty) {
                for (Project project : item) {
                   HBox row = createRow(project.getColor(), project.getName());
                   vbox.getChildren().add(row);
-
-                  // Set tooltip for the label
-                  Label label = (Label) row.getChildren().get(1);
-                  Tooltip tooltip = new Tooltip(label.getText());
-                  label.setTooltip(tooltip);
                }
                setGraphic(vbox);
             }
@@ -295,6 +290,7 @@ protected void updateItem(List<Project> item, boolean empty) {
          private HBox createRow(Color color, String text) {
             Circle circle = new Circle(6, color);
             Label label = new Label(text);
+            label.setTooltip(new Tooltip(text));
 
             label.setMaxWidth(Double.MAX_VALUE);
             HBox.setHgrow(label, Priority.ALWAYS);
@@ -441,20 +437,20 @@ protected void updateItem(TableRow item, boolean empty) {
             }
 
             TextFlow statusFlow = item.syncStatus;
-            String status = statusFlow.getChildren()
+            String statusForTooltip = statusFlow.getChildren()
                                       .stream()
-                                      .filter(n -> n instanceof Text)
+                                      .filter(Text.class::isInstance)
                                       .map(n -> ((Text) n).getText())
                                       .collect(Collectors.joining());
 
             if (!item.bookingHint.isEmpty().get()) {
                statusFlow = new TextFlow(statusFlow);
-               tooltip.setText(status + "\n" + item.bookingHint.get());
+               tooltip.setText(statusForTooltip + "\n" + item.bookingHint.get());
                Text icon = new Text("ⓘ ");
                icon.setStyle("-fx-text-fill: #1c2070; -fx-font-size: 14px;");
                statusFlow.getChildren().add(0, icon);
             } else {
-               tooltip.setText(status);
+               tooltip.setText(statusForTooltip);
             }
 
             // Fix Cell height not aligning with Textflow
@@ -475,6 +471,7 @@ protected void updateItem(TableRow item, boolean empty) {
 
       mappingTableView.getColumns().addAll(shouldSyncColumn, projectColumn, timeColumn, notesColumn, syncColumn);
       mappingTableView.setSelectionModel(null);
+      mappingTableView.setFocusTraversable(false);
       mappingTableView.getColumns().forEach(column -> column.setSortable(false));
 
       saveButton.setOnAction(ae -> {
@@ -638,7 +635,8 @@ private void setUpTimeSpinner(final Spinner<LocalTime> spinner) {
          final StringProperty text = spinner.getEditor().textProperty();
          try {
             stringConverter.fromString(text.get());
-            spinner.increment(0);
+            // needed to log in value from editor to spinner
+            spinner.increment(0); // TODO find better Solution
          } catch (final DateTimeParseException ex) {
             text.setValue(spinner.getValue().toString());
          }

src/main/java/de/doubleslash/keeptime/view/ReportController.java

@@ -170,15 +170,15 @@ private void showSyncStage(){
          syncStage.setResizable(true);
          syncStage.getIcons().add(new Image(Resources.getResource(RESOURCE.ICON_MAIN).toString()));
 
-         final Scene settingsScene = new Scene(syncRoot);
-         settingsScene.addEventFilter(KeyEvent.KEY_PRESSED, ke -> {
+         final Scene syncScene = new Scene(syncRoot);
+         syncScene.addEventFilter(KeyEvent.KEY_PRESSED, ke -> {
             if (ke.getCode() == KeyCode.ESCAPE) {
                LOG.info("pressed ESCAPE");
                syncStage.close();
             }
          });
 
-         syncStage.setScene(settingsScene);
+         syncStage.setScene(syncScene);
          syncStage.showAndWait();
       } catch (final Exception e) {
          throw new FXMLLoaderException(e);