more cleanup

Author: Death111

src/main/java/de/doubleslash/keeptime/Main.java

@@ -224,7 +224,7 @@ private void initialiseUI(final Stage primaryStage) throws IOException {
       // Show the scene containing the root layout.
       final Scene mainScene = new Scene(mainPane, Color.TRANSPARENT);
 
-      // Image(Resources.getResource(RESOURCE.ICON_MAIN).toString()));
+      // Image(Resources.getResource(RESOURCE.ICON_MAIN).toString())); // TODO use an app icon
 
       primaryStage.setTitle("KeepTime");
       primaryStage.setScene(mainScene);

src/main/java/de/doubleslash/keeptime/model/Model.java

@@ -38,7 +38,7 @@ public Model(final ProjectRepository projectRepository, final WorkRepository wor
 
    public static final Color originalTaskBarFontColor = Color.BLACK;
 
-   public final Project DEFAULT_PROJECT = new Project("Idle", Color.ORANGE, false, 0, true);
+   public static final Project DEFAULT_PROJECT = new Project("Idle", Color.ORANGE, false, 0, true);
    public Project idleProject = DEFAULT_PROJECT;
 
    public ObservableList<Project> availableProjects = FXCollections.observableArrayList();

src/main/java/de/doubleslash/keeptime/view/ViewController.java

@@ -8,6 +8,7 @@
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
+import java.util.Map.Entry;
 import java.util.Optional;
 
 import org.slf4j.Logger;
@@ -423,8 +424,9 @@ private void initialize() throws IOException {
          allTimeLabel.setText(DateFormatter.secondsToHHMMSS(todayWorkingSeconds));
          todayAllSeconds.setText(DateFormatter.secondsToHHMMSS(todaySeconds));
 
-         for (final Project p : elapsedProjectTimeLabelMap.keySet()) {
-            final Label label = elapsedProjectTimeLabelMap.get(p);
+         for (final Entry<Project, Label> entry : elapsedProjectTimeLabelMap.entrySet()) {
+            final Project p = entry.getKey();
+            final Label label = entry.getValue();
 
             final long seconds = model.pastWorkItems.stream().filter((work) -> work.getProject().getId() == p.getId())
                   .mapToLong(work -> {
@@ -533,8 +535,6 @@ private Node addProjectToProjectList(final Project p) {
          final MouseButton button = a.getButton();
          if (button == MouseButton.PRIMARY) {
             changeProject(p, 0);
-         } else if (button == MouseButton.SECONDARY) {
-
          }
 
       });

src/main/java/de/doubleslash/keeptime/viewPopup/ViewControllerPopup.java

@@ -50,7 +50,7 @@ public class ViewControllerPopup {
    private FilteredList<Project> filteredData;
 
    private void changeProject(final Project item) {
-      LOG.info("Change project to '" + item.getName() + "'.");
+      LOG.info("Change project to '{}'.", item.getName());
 
       // ask for a note for the current project
       final TextInputDialog dialog = new TextInputDialog(model.activeWorkItem.get().getNotes());
@@ -84,12 +84,10 @@ protected void updateItem(final Project project, final boolean empty) {
 
                   if (project == null || empty) {
                      setText(null);
-                     // setPrefHeight(0);
                   } else {
                      setOnMouseClicked((ev) -> {
                         changeProject(project);
                      });
-                     // setPrefHeight(24);
                      final boolean isActiveProject = project == model.activeWorkItem.get().getProject();
                      setText((isActiveProject ? "* " : "") + project.getName());
                      setTextFill(project.getColor());
@@ -104,7 +102,7 @@ protected void updateItem(final Project project, final boolean empty) {
       // TODO why is there no nice way for listview height?
       // https://stackoverflow.com/questions/17429508/how-do-you-get-javafx-listview-to-be-the-height-of-its-items
       final Consumer<Double> updateSize = (height) -> {
-         LOG.debug("update size" + height);
+         LOG.debug("update size {}.", height);
          projectListView.setPrefHeight(height);
          stage.sizeToScene(); // also update scene size
       };