Skip to content

Commit b6c38b6

Browse files
authored
fix HEAD requests for items (geopython#1836) (geopython#1838)
1 parent d2f38de commit b6c38b6

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

pygeoapi/flask_app.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -279,11 +279,7 @@ def collection_items(collection_id, item_id=None):
279279
"""
280280

281281
if item_id is None:
282-
if request.method == 'GET': # list items
283-
return execute_from_flask(itemtypes_api.get_collection_items,
284-
request, collection_id,
285-
skip_valid_check=True)
286-
elif request.method == 'POST': # filter or manage items
282+
if request.method == 'POST': # filter or manage items
287283
if request.content_type is not None:
288284
if request.content_type == 'application/geo+json':
289285
return execute_from_flask(
@@ -298,6 +294,10 @@ def collection_items(collection_id, item_id=None):
298294
return execute_from_flask(
299295
itemtypes_api.manage_collection_item, request, 'options',
300296
collection_id, skip_valid_check=True)
297+
else: # GET: list items
298+
return execute_from_flask(itemtypes_api.get_collection_items,
299+
request, collection_id,
300+
skip_valid_check=True)
301301

302302
elif request.method == 'DELETE':
303303
return execute_from_flask(itemtypes_api.manage_collection_item,

pygeoapi/starlette_app.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -334,11 +334,7 @@ async def collection_items(request: Request, collection_id=None, item_id=None):
334334
if 'item_id' in request.path_params:
335335
item_id = request.path_params['item_id']
336336
if item_id is None:
337-
if request.method == 'GET': # list items
338-
return await execute_from_starlette(
339-
itemtypes_api.get_collection_items, request, collection_id,
340-
skip_valid_check=True)
341-
elif request.method == 'POST': # filter or manage items
337+
if request.method == 'POST': # filter or manage items
342338
content_type = request.headers.get('content-type')
343339
if content_type is not None:
344340
if content_type == 'application/geo+json':
@@ -357,6 +353,10 @@ async def collection_items(request: Request, collection_id=None, item_id=None):
357353
itemtypes_api.manage_collection_item, request,
358354
'options', collection_id, skip_valid_check=True,
359355
)
356+
else: # GET: list items
357+
return await execute_from_starlette(
358+
itemtypes_api.get_collection_items, request, collection_id,
359+
skip_valid_check=True)
360360

361361
elif request.method == 'DELETE':
362362
return await execute_from_starlette(

0 commit comments

Comments
 (0)