fix(tests): Resolve history file race condition in parallel test exec… #161
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: CI | |
| on: | |
| push: | |
| branches: [ main ] | |
| paths: | |
| - 'crates/**' | |
| - 'fuzz/**' | |
| - 'Cargo.toml' | |
| - 'Cargo.lock' | |
| - '.github/workflows/ci.yml' | |
| pull_request: | |
| branches: [ main ] | |
| paths: | |
| - 'crates/**' | |
| - 'fuzz/**' | |
| - 'Cargo.toml' | |
| - 'Cargo.lock' | |
| - '.github/workflows/ci.yml' | |
| # Cancel outdated workflow runs | |
| concurrency: | |
| group: ${{ github.workflow }}-${{ github.ref }} | |
| cancel-in-progress: true | |
| env: | |
| CARGO_TERM_COLOR: always | |
| RUST_BACKTRACE: 1 | |
| CARGO_INCREMENTAL: 0 | |
| jobs: | |
| # Job 1: Format check | |
| format: | |
| name: Format Check | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - name: Install Rust stable | |
| uses: dtolnay/rust-toolchain@stable | |
| with: | |
| components: rustfmt | |
| - name: Check formatting | |
| run: cargo fmt --all -- --check | |
| # Job 2: Clippy linting | |
| clippy: | |
| name: Clippy Lint | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - name: Install Rust stable | |
| uses: dtolnay/rust-toolchain@stable | |
| with: | |
| components: clippy | |
| - name: Cache dependencies | |
| uses: Swatinem/rust-cache@v2 | |
| with: | |
| shared-key: "clippy" | |
| - name: Run clippy | |
| run: cargo clippy --workspace --all-targets --locked -- -D warnings | |
| # Job 3: Build and Test (Matrix for multiple platforms) | |
| test: | |
| name: Test (${{ matrix.os }}) | |
| runs-on: ${{ matrix.os }} | |
| strategy: | |
| fail-fast: false | |
| matrix: | |
| os: [ubuntu-latest, windows-latest, macos-latest] | |
| rust: [stable] | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - name: Install Rust ${{ matrix.rust }} | |
| uses: dtolnay/rust-toolchain@master | |
| with: | |
| toolchain: ${{ matrix.rust }} | |
| - name: Install system dependencies (Linux) | |
| if: matrix.os == 'ubuntu-latest' | |
| run: sudo apt-get update && sudo apt-get install -y libpcap-dev pkg-config | |
| - name: Install system dependencies (macOS) | |
| if: matrix.os == 'macos-latest' | |
| run: | | |
| # Install libpcap (only if not already present) | |
| brew list libpcap &>/dev/null || brew install libpcap | |
| # pkg-config is provided by pkgconf which is pre-installed on GitHub Actions runners | |
| brew list pkgconf &>/dev/null || brew install pkgconf | |
| - name: Install Npcap SDK and Runtime DLLs (Windows) | |
| if: matrix.os == 'windows-latest' | |
| shell: pwsh | |
| run: | | |
| # Download and extract Npcap SDK (contains Packet.lib for development) | |
| Write-Host "Downloading Npcap SDK..." | |
| curl -L -o npcap-sdk.zip https://npcap.com/dist/npcap-sdk-1.13.zip | |
| Expand-Archive -Path npcap-sdk.zip -DestinationPath npcap-sdk | |
| Write-Host "✓ Npcap SDK extracted" | |
| # Download Npcap installer and extract DLLs without running (avoids hang) | |
| Write-Host "`nDownloading Npcap 1.79 installer..." | |
| curl -L -o npcap-installer.exe https://npcap.com/dist/npcap-1.79.exe | |
| # Extract installer using 7zip (pre-installed on GitHub Actions) | |
| Write-Host "Extracting DLLs from Npcap installer (no execution)..." | |
| 7z x npcap-installer.exe -o"npcap-runtime" -y | Out-Null | |
| # Create runtime directory and copy DLLs | |
| New-Item -ItemType Directory -Force -Path "npcap-dlls" | Out-Null | |
| # Find and copy ONLY x64 DLLs (to avoid 32-bit/64-bit architecture mismatch) | |
| Get-ChildItem -Path "npcap-runtime" -Recurse -Filter "*.dll" | Where-Object { | |
| ($_.Name -eq "Packet.dll" -or $_.Name -eq "wpcap.dll") -and $_.DirectoryName -like "*x64*" | |
| } | ForEach-Object { | |
| Copy-Item $_.FullName -Destination "npcap-dlls\" -Force | |
| Write-Host "Copied $($_.Name) from $($_.DirectoryName)" | |
| } | |
| # Verify we got the x64 DLLs | |
| if (-not (Test-Path "npcap-dlls\Packet.dll") -or -not (Test-Path "npcap-dlls\wpcap.dll")) { | |
| Write-Error "Failed to extract x64 DLLs from installer" | |
| exit 1 | |
| } | |
| # Add SDK lib directory to LIB environment variable for linking | |
| echo "LIB=$PWD\npcap-sdk\Lib\x64;$env:LIB" >> $env:GITHUB_ENV | |
| # Add DLL directory to PATH for runtime | |
| echo "PATH=$PWD\npcap-dlls;$env:PATH" >> $env:GITHUB_ENV | |
| # List what we extracted to verify | |
| Write-Host "`nExtracted DLLs:" | |
| Get-ChildItem "npcap-dlls" | Format-Table Name, Length -AutoSize | |
| - name: Cache dependencies | |
| uses: Swatinem/rust-cache@v2 | |
| with: | |
| shared-key: "test-${{ matrix.os }}" | |
| - name: Build | |
| run: cargo build --workspace --locked --verbose | |
| - name: Run tests | |
| run: | | |
| if [ "${{ matrix.os }}" = "windows-latest" ]; then | |
| # Windows: Run only unit tests for crates that don't require Npcap | |
| # Exclude: prtip-network (network layer), prtip-scanner (uses Npcap), prtip-cli integration tests | |
| # Include: prtip-core (core types), prtip-cli unit tests (args parsing, formatting) | |
| cargo test --workspace --locked --lib --exclude prtip-network --exclude prtip-scanner | |
| else | |
| cargo test --workspace --locked | |
| fi | |
| shell: bash | |
| env: | |
| # Disable history file I/O during tests to prevent race conditions | |
| # when multiple tests run in parallel (same fix as commit 0bf2a70) | |
| PRTIP_DISABLE_HISTORY: "1" | |
| - name: Build release | |
| run: cargo build --release --workspace --locked | |
| # Job 4: Security audit | |
| security_audit: | |
| name: Security Audit | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - name: Run cargo-deny | |
| uses: EmbarkStudios/cargo-deny-action@v2 | |
| with: | |
| log-level: warn | |
| command: check advisories | |
| arguments: --all-features | |
| # Job 5: MSRV (Minimum Supported Rust Version) check | |
| msrv: | |
| name: MSRV Check (1.85) | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - name: Install Rust 1.85 | |
| uses: dtolnay/rust-toolchain@1.85 | |
| - name: Install system dependencies | |
| run: sudo apt-get update && sudo apt-get install -y libpcap-dev pkg-config | |
| - name: Cache dependencies | |
| uses: Swatinem/rust-cache@v2 | |
| with: | |
| shared-key: "msrv" | |
| - name: Check build with MSRV | |
| run: cargo build --workspace --locked --verbose |