Skip to content

Commit 11edb4d

Browse files
doublegateclaude
andcommitted
fix(ci): resolve CI build failures for audio dependencies
- Add libasound2-dev to Ubuntu CI workflows for ALSA support (cpal crate) - Add opus to macOS CI for audiopus_sys build - Remove unused imports in wraith-chat integration_tests.rs: - std::time::Duration - GroupInfo, GroupMember - VideoCallError, VideoCallInfo - CallInfo, VoiceCallError - Fix unused variable warning (manager -> _manager) These changes fix CI runs #308 and #309 which failed due to: 1. alsa-sys build failure on Linux (missing libasound2-dev) 2. audiopus_sys cmake failure on macOS (missing libopus) 3. Unused import/variable warnings treated as errors with -D warnings Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 39b8301 commit 11edb4d

File tree

5 files changed

+16
-20
lines changed

5 files changed

+16
-20
lines changed

.github/workflows/ci.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
- name: Install system dependencies (Ubuntu)
3535
run: |
3636
sudo apt-get update
37-
sudo apt-get install -y libglib2.0-dev libwebkit2gtk-4.1-dev librsvg2-dev patchelf libgtk-3-dev libayatana-appindicator3-dev libsqlcipher-dev
37+
sudo apt-get install -y libglib2.0-dev libwebkit2gtk-4.1-dev librsvg2-dev patchelf libgtk-3-dev libayatana-appindicator3-dev libsqlcipher-dev libasound2-dev
3838
3939
- name: Install Rust toolchain
4040
uses: dtolnay/rust-toolchain@stable
@@ -77,12 +77,12 @@ jobs:
7777
if: matrix.os == 'ubuntu-latest'
7878
run: |
7979
sudo apt-get update
80-
sudo apt-get install -y libglib2.0-dev libwebkit2gtk-4.1-dev librsvg2-dev patchelf libgtk-3-dev libayatana-appindicator3-dev libsqlcipher-dev
80+
sudo apt-get install -y libglib2.0-dev libwebkit2gtk-4.1-dev librsvg2-dev patchelf libgtk-3-dev libayatana-appindicator3-dev libsqlcipher-dev libasound2-dev
8181
8282
- name: Install system dependencies (macOS)
8383
if: matrix.os == 'macos-latest'
8484
run: |
85-
brew install sqlcipher
85+
brew install sqlcipher opus
8686
8787
- name: Install system dependencies (Windows)
8888
if: matrix.os == 'windows-latest'
@@ -127,7 +127,7 @@ jobs:
127127
- name: Install system dependencies (Ubuntu)
128128
run: |
129129
sudo apt-get update
130-
sudo apt-get install -y libglib2.0-dev libwebkit2gtk-4.1-dev librsvg2-dev patchelf libgtk-3-dev libayatana-appindicator3-dev libsqlcipher-dev
130+
sudo apt-get install -y libglib2.0-dev libwebkit2gtk-4.1-dev librsvg2-dev patchelf libgtk-3-dev libayatana-appindicator3-dev libsqlcipher-dev libasound2-dev
131131
132132
- name: Install Rust toolchain
133133
uses: dtolnay/rust-toolchain@stable
@@ -169,7 +169,7 @@ jobs:
169169
- name: Install system dependencies (Ubuntu)
170170
run: |
171171
sudo apt-get update
172-
sudo apt-get install -y libglib2.0-dev libwebkit2gtk-4.1-dev librsvg2-dev patchelf libgtk-3-dev libayatana-appindicator3-dev libsqlcipher-dev
172+
sudo apt-get install -y libglib2.0-dev libwebkit2gtk-4.1-dev librsvg2-dev patchelf libgtk-3-dev libayatana-appindicator3-dev libsqlcipher-dev libasound2-dev
173173
174174
- name: Install Rust toolchain
175175
uses: dtolnay/rust-toolchain@stable
@@ -197,7 +197,7 @@ jobs:
197197
- name: Install system dependencies (Ubuntu)
198198
run: |
199199
sudo apt-get update
200-
sudo apt-get install -y libglib2.0-dev libwebkit2gtk-4.1-dev librsvg2-dev patchelf libgtk-3-dev libayatana-appindicator3-dev libsqlcipher-dev
200+
sudo apt-get install -y libglib2.0-dev libwebkit2gtk-4.1-dev librsvg2-dev patchelf libgtk-3-dev libayatana-appindicator3-dev libsqlcipher-dev libasound2-dev
201201
202202
- name: Install Rust 1.85
203203
uses: dtolnay/rust-toolchain@1.85
@@ -217,7 +217,7 @@ jobs:
217217
- name: Install system dependencies (Ubuntu)
218218
run: |
219219
sudo apt-get update
220-
sudo apt-get install -y libglib2.0-dev libwebkit2gtk-4.1-dev librsvg2-dev patchelf libgtk-3-dev libayatana-appindicator3-dev libsqlcipher-dev
220+
sudo apt-get install -y libglib2.0-dev libwebkit2gtk-4.1-dev librsvg2-dev patchelf libgtk-3-dev libayatana-appindicator3-dev libsqlcipher-dev libasound2-dev
221221
222222
- name: Install Rust toolchain
223223
uses: dtolnay/rust-toolchain@stable

.github/workflows/codeql.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ jobs:
6767
- name: Install system dependencies (Ubuntu)
6868
run: |
6969
sudo apt-get update
70-
sudo apt-get install -y libglib2.0-dev libwebkit2gtk-4.1-dev librsvg2-dev patchelf libgtk-3-dev libayatana-appindicator3-dev libsqlcipher-dev
70+
sudo apt-get install -y libglib2.0-dev libwebkit2gtk-4.1-dev librsvg2-dev patchelf libgtk-3-dev libayatana-appindicator3-dev libsqlcipher-dev libasound2-dev
7171
7272
# Build the project (required for compiled languages like Rust)
7373
# CodeQL needs the build to understand the code structure

.github/workflows/docs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ jobs:
9898
- name: Install system dependencies (Ubuntu)
9999
run: |
100100
sudo apt-get update
101-
sudo apt-get install -y libglib2.0-dev libwebkit2gtk-4.1-dev librsvg2-dev patchelf libgtk-3-dev libayatana-appindicator3-dev libsqlcipher-dev
101+
sudo apt-get install -y libglib2.0-dev libwebkit2gtk-4.1-dev librsvg2-dev patchelf libgtk-3-dev libayatana-appindicator3-dev libsqlcipher-dev libasound2-dev
102102
103103
- name: Install Rust toolchain
104104
uses: dtolnay/rust-toolchain@stable

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ jobs:
133133
- name: Install system dependencies (Ubuntu)
134134
run: |
135135
sudo apt-get update
136-
sudo apt-get install -y libglib2.0-dev libwebkit2gtk-4.1-dev librsvg2-dev patchelf libgtk-3-dev libayatana-appindicator3-dev libsqlcipher-dev
136+
sudo apt-get install -y libglib2.0-dev libwebkit2gtk-4.1-dev librsvg2-dev patchelf libgtk-3-dev libayatana-appindicator3-dev libsqlcipher-dev libasound2-dev
137137
138138
- name: Install Rust toolchain
139139
uses: dtolnay/rust-toolchain@stable

clients/wraith-chat/src-tauri/src/integration_tests.rs

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,20 +5,15 @@
55

66
#![cfg(test)]
77

8-
use std::time::Duration;
9-
108
use crate::group::{
11-
GroupEncryptedMessage, GroupError, GroupInfo, GroupMember, GroupRole, GroupSession,
12-
GroupSessionManager, KEY_ROTATION_DAYS, MAX_GROUP_MEMBERS, SenderKeyDistribution,
13-
SenderKeyState,
9+
GroupEncryptedMessage, GroupError, GroupRole, GroupSession, GroupSessionManager,
10+
KEY_ROTATION_DAYS, MAX_GROUP_MEMBERS, SenderKeyDistribution, SenderKeyState,
1411
};
1512
use crate::video_call::{
16-
VideoCallError, VideoCallInfo, VideoCallManager, VideoCallSignal, VideoCallStats,
17-
VideoCodecConfig, VideoPacket, VideoSource,
13+
VideoCallManager, VideoCallSignal, VideoCallStats, VideoCodecConfig, VideoPacket, VideoSource,
1814
};
1915
use crate::voice_call::{
20-
CallDirection, CallInfo, CallSignal, CallState, CallStats, CodecConfig, VoiceCallError,
21-
VoiceCallManager, VoicePacket,
16+
CallDirection, CallSignal, CallState, CallStats, CodecConfig, VoiceCallManager, VoicePacket,
2217
};
2318

2419
// ============================================================================
@@ -794,7 +789,8 @@ fn test_concurrent_group_operations() {
794789
/// Test call state transitions
795790
#[tokio::test]
796791
async fn test_call_state_transitions() {
797-
let manager = VoiceCallManager::new();
792+
// VoiceCallManager is available but we're testing state serialization
793+
let _manager = VoiceCallManager::new();
798794

799795
// Verify all state transitions
800796
assert_eq!(CallState::Initiating.to_string(), "initiating");

0 commit comments

Comments
 (0)