fix: resolve F824 flake8 errors - remove unnecessary global declarations

Removed unused `global _scrapetui_module` declarations from three test files.
These global statements were flagged by flake8 F824 because the variable
itself was never reassigned in scope - only its attributes were modified.

In Python, you don't need `global` to modify attributes of a module-level
object; it's only needed when reassigning the variable itself.

Files fixed:
- tests/test_analytics.py:38
- tests/test_performance.py:55
- tests/test_scheduling.py:39

Verification:
- flake8 critical errors (E9,F63,F7,F82): 0 ✅
- pytest test suite: 307/307 passing (100%) ✅
- No test functionality affected

Resolves GitHub Actions workflow failures in runs:
- #18236485813 (2025-10-04)
- #18236145310 (2025-10-03)
- #18235535859 (2025-10-03)

Author: doublegate

tests/test_analytics.py

@@ -35,7 +35,6 @@ def analytics_test_db(temp_db):
     """Create a temporary database for analytics testing with unique data."""
     # temp_db fixture from conftest.py already provides isolated database
     # IMPORTANT: Must patch the monolithic module's DB_PATH to use temp database
-    global _scrapetui_module
     _scrapetui_module.DB_PATH = temp_db
 
     # Just add test data to it

tests/test_performance.py

@@ -52,7 +52,6 @@ def perf_test_db(tmp_path):
     db_path = tmp_path / "perf_test.db"
 
     # Patch the monolithic module's DB_PATH to use temp database
-    global _scrapetui_module
     original_db = _scrapetui_module.DB_PATH
     _scrapetui_module.DB_PATH = Path(db_path)
 

tests/test_scheduling.py

@@ -36,7 +36,6 @@ def temp_db(monkeypatch):
         temp_db_path = f.name
 
     # Patch the monolithic module's DB_PATH to use temp database
-    global _scrapetui_module
     original_db = _scrapetui_module.DB_PATH
     _scrapetui_module.DB_PATH = Path(temp_db_path)