feat: remove old portfolios in maintenance

Author: macite

app/helpers/file_helper.rb

@@ -225,9 +225,13 @@ def unit_dir(unit, create = true)
     dir_for_unit_code_and_id(unit.code, unit.id, create)
   end
 
-  def unit_portfolio_dir(unit, create = true)
+  def root_portfolio_dir
     file_server = Doubtfire::Application.config.student_work_dir
-    dst = "#{file_server}/portfolio/" # trust the server config and passed in type for paths
+    "#{file_server}/portfolio/" # trust the server config and passed in type for paths
+  end
+
+  def unit_portfolio_dir(unit, create = true)
+    dst = root_portfolio_dir
 
     dst << sanitized_path("#{unit.code}-#{unit.id}") << '/'
 
@@ -674,6 +678,7 @@ def line_wrap(path, width: 160)
   module_function :student_work_root
   module_function :dir_for_unit_code_and_id
   module_function :unit_dir
+  module_function :root_portfolio_dir
   module_function :unit_portfolio_dir
   module_function :student_portfolio_dir
   module_function :student_portfolio_path

lib/tasks/maintenance.rake

@@ -63,5 +63,8 @@ namespace :maintenance do
       unit.archive_submissions($stdout)
       unit.update(archived: true)
     end
+
+    puts "Removing old portfolio PDFs"
+    `find #{FileHelper.root_portfolio_dir} -name "*pdf.old" -exec rm {} \;`
   end
 end