fix compiler complaints (#140)

Co-authored-by: Chao Yan <cyan@uottawa.ca>

Author: cyanmcg

src/dg/dg.cpp

@@ -1384,7 +1384,7 @@ double DGBase<dim,real,MeshType>::get_residual_linfnorm () const
                                                                update_flags);
 
     // Obtain the mapping from local dof indices to global dof indices
-    for (const auto cell : dof_handler.active_cell_iterators()) {
+    for (const auto& cell : dof_handler.active_cell_iterators()) {
         if (!cell->is_locally_owned()) continue;
 
         const int i_fele = cell->active_fe_index();
@@ -1439,7 +1439,7 @@ double DGBase<dim,real,MeshType>::get_residual_l2norm () const
                                                                update_flags);
 
     // Obtain the mapping from local dof indices to global dof indices
-    for (const auto cell : dof_handler.active_cell_iterators()) {
+    for (const auto& cell : dof_handler.active_cell_iterators()) {
         if (!cell->is_locally_owned()) continue;
 
         const int i_fele = cell->active_fe_index();

src/mesh/high_order_grid.cpp

@@ -1081,7 +1081,7 @@ void HighOrderGrid<dim,real,MeshType,VectorType,DoFHandlerType>::update_surface_
 
         n_locally_owned_surface_nodes_per_mpi.clear();
         n_locally_owned_surface_nodes_per_mpi.resize(n_mpi);
-        MPI_Allgather(&n_locally_owned_surface_nodes, 1, MPI::UNSIGNED, &(n_locally_owned_surface_nodes_per_mpi[0]), 1, MPI::UNSIGNED, MPI_COMM_WORLD);
+        MPI_Allgather(&n_locally_owned_surface_nodes, 1, MPI_UNSIGNED, &(n_locally_owned_surface_nodes_per_mpi[0]), 1, MPI_UNSIGNED, MPI_COMM_WORLD);
 
         std::vector<std::vector<real>> vector_locally_owned_surface_nodes(n_mpi);
         std::vector<std::vector<unsigned int>> vector_locally_owned_surface_indices(n_mpi);
@@ -1097,7 +1097,7 @@ void HighOrderGrid<dim,real,MeshType,VectorType,DoFHandlerType>::update_surface_
 
         for (int i_mpi=0; i_mpi<n_mpi; ++i_mpi) {
             MPI_Bcast(&(vector_locally_owned_surface_nodes[i_mpi][0]), n_locally_owned_surface_nodes_per_mpi[i_mpi], MPI_DOUBLE, i_mpi, MPI_COMM_WORLD);
-            MPI_Bcast(&(vector_locally_owned_surface_indices[i_mpi][0]), n_locally_owned_surface_nodes_per_mpi[i_mpi], MPI::UNSIGNED, i_mpi, MPI_COMM_WORLD);
+            MPI_Bcast(&(vector_locally_owned_surface_indices[i_mpi][0]), n_locally_owned_surface_nodes_per_mpi[i_mpi], MPI_UNSIGNED, i_mpi, MPI_COMM_WORLD);
         }
 
         all_surface_nodes = flatten(vector_locally_owned_surface_nodes);
@@ -1127,7 +1127,7 @@ void HighOrderGrid<dim,real,MeshType,VectorType,DoFHandlerType>::update_surface_
         }
 
         std::vector<unsigned int> n_locally_relevant_surface_nodes_per_mpi(n_mpi);
-        MPI_Allgather(&n_locally_relevant_surface_nodes, 1, MPI::UNSIGNED, &(n_locally_relevant_surface_nodes_per_mpi[0]), 1, MPI::UNSIGNED, MPI_COMM_WORLD);
+        MPI_Allgather(&n_locally_relevant_surface_nodes, 1, MPI_UNSIGNED, &(n_locally_relevant_surface_nodes_per_mpi[0]), 1, MPI_UNSIGNED, MPI_COMM_WORLD);
 
     }
 

tests/unit_tests/grid/make_cells_valid.cpp

@@ -151,7 +151,7 @@ int main (int argc, char * argv[])
     }
 
     bool mpi_has_invalid_poly;
-    MPI_Allreduce(&has_invalid_poly, &mpi_has_invalid_poly, 1, MPI::BOOL, MPI_LOR, MPI_COMM_WORLD);
+    MPI_Allreduce(&has_invalid_poly, &mpi_has_invalid_poly, 1, MPI_C_BOOL, MPI_LOR, MPI_COMM_WORLD);
 
     return mpi_has_invalid_poly;
 }

tests/unit_tests/sensitivities/d2RdWdW_fd_vs_ad.cpp

@@ -143,7 +143,7 @@ int test (
 
             const bool local_isnonzero = sparsity_pattern.exists(iw,jw);
             bool global_isnonzero;
-            MPI_Allreduce(&local_isnonzero, &global_isnonzero, 1, MPI::BOOL, MPI_LOR, MPI_COMM_WORLD);
+            MPI_Allreduce(&local_isnonzero, &global_isnonzero, 1, MPI_C_BOOL, MPI_LOR, MPI_COMM_WORLD);
             if (!global_isnonzero) continue;
 
             const bool iw_relevant = dg->locally_relevant_dofs.is_element(iw);

tests/unit_tests/sensitivities/d2RdWdX_fd_vs_ad.cpp

@@ -111,7 +111,7 @@ int test (
 
             const bool local_isnonzero = sparsity_pattern.exists(iw,jnode);
             bool global_isnonzero;
-            MPI_Allreduce(&local_isnonzero, &global_isnonzero, 1, MPI::BOOL, MPI_LOR, MPI_COMM_WORLD);
+            MPI_Allreduce(&local_isnonzero, &global_isnonzero, 1, MPI_C_BOOL, MPI_LOR, MPI_COMM_WORLD);
             if (!global_isnonzero) continue;
 
             const bool iw_relevant = dg->locally_relevant_dofs.is_element(iw);

tests/unit_tests/sensitivities/d2RdXdX_fd_vs_ad.cpp

@@ -151,7 +151,7 @@ int test (
 
             const bool local_isnonzero = sparsity_pattern.exists(inode,jnode);
             bool global_isnonzero;
-            MPI_Allreduce(&local_isnonzero, &global_isnonzero, 1, MPI::BOOL, MPI_LOR, MPI_COMM_WORLD);
+            MPI_Allreduce(&local_isnonzero, &global_isnonzero, 1, MPI_C_BOOL, MPI_LOR, MPI_COMM_WORLD);
             if (!global_isnonzero) continue;
 
             const bool inode_relevant = high_order_grid->locally_relevant_dofs_grid.is_element(inode);