Config rewrite fixups #1103
Merged
Config rewrite fixups #1103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's now clear enough based on the setting names.
Since not all settings are currently supported by dict-ldap, it's better to be explicit.
This comment has been minimized.
This comment has been minimized.
sirainen
force-pushed
the
config-rewrite-fixups
branch
from
8f786c8 to
9f67776
Compare
sirainen
force-pushed
the
config-rewrite-fixups
branch
from
9f67776 to
013c262
Compare
cmouse
approved these changes
Dec 17, 2024
cmouse
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOV-7293
On top of #1102