passwd-file default scheme is not CRYPT #1363
Open
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmouse
reviewed
Nov 28, 2025
| values: setting_types.STRING, | ||
| default: { | ||
| value: 'PLAIN', | ||
| value: 'CRYPT', |
Contributor
There was a problem hiding this comment.
you sure about this? isn't it only for passwd and passwd-file?
Contributor
There was a problem hiding this comment.
Yeah, there are many different defaults. We currently have a bit kludgy way of specifying that. See for example mail_attachment_detection_options. Also see how mail_cache_fields specifies the default change.
Contributor
There was a problem hiding this comment.
Although looking at the change, it changes the global default_password_scheme to CRYPT. And then all of the defaults are CRYPT. So this part of the change is correct.
sirainen
reviewed
Nov 28, 2025
| | ------- | ----------------- | ----------------- | | ||
| | [[setting,lazy_expunge_only_last_instance]] | `no` | `yes` | | ||
| | [[setting,mail_access_groups]] | | [[setting,default_internal_group]] | | ||
| | [[setting,passdb_default_password_scheme]] | `PLAIN` | `CRYPT` | |
Contributor
There was a problem hiding this comment.
This could say in some way which passdbs are actually changed, since default wasn't PLAIN for all of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.