do not allow incorrect indeces

Author: silviuaavram

src/hooks/useTagGroup/__tests__/getTagProps.test.ts

@@ -40,8 +40,8 @@ describe('getTagProps', () => {
       const {result} = renderUseTagGroup()
 
       expect(() =>
-        result.current.getTagProps({}),
-      ).toThrowErrorMatchingInlineSnapshot(`Pass index to getTagProps!`)
+        result.current.getTagProps({index: -2}),
+      ).toThrowErrorMatchingInlineSnapshot("Pass correct item index to getTagProps!")
     })
   })
 

src/hooks/useTagGroup/__tests__/getTagRemoveProps.test.ts

@@ -51,8 +51,8 @@ describe('getTagRemoveProps', () => {
       const {result} = renderUseTagGroup()
 
       expect(() =>
-        result.current.getTagRemoveProps({}),
-      ).toThrowErrorMatchingInlineSnapshot(`Pass index to getTagRemoveProps!`)
+        result.current.getTagRemoveProps({index: -3}),
+      ).toThrowErrorMatchingInlineSnapshot(`Pass correct item index to getTagRemoveProps!`)
     })
   })
 

src/hooks/useTagGroup/index.ts

@@ -143,17 +143,12 @@ const useTagGroup: UseTagGroupInterface = <Item>(
 
   const getTagProps = useCallback(
     <Extra extends Record<string, unknown>>(
-      options?: GetTagPropsOptions & Extra,
+      options: GetTagPropsOptions & Extra,
     ) => {
-      const {
-        index,
-        refKey = 'ref',
-        ref,
-        onClick,
-        ...rest
-      } = options ?? ({} as GetTagPropsOptions & Extra)
-      if (index === undefined) {
-        throw new Error('Pass index to getTagProps!')
+      const {index, refKey = 'ref', ref, onClick, ...rest} = options
+
+      if (!Number.isInteger(index) || index < 0) {
+        throw new Error('Pass correct item index to getTagProps!')
       }
 
       const latestState = latest.current.state
@@ -183,13 +178,12 @@ const useTagGroup: UseTagGroupInterface = <Item>(
 
   const getTagRemoveProps = useCallback(
     <Extra extends Record<string, unknown>>(
-      options?: GetTagRemovePropsOptions & Extra,
+      options: GetTagRemovePropsOptions & Extra,
     ) => {
-      const {index, onClick, ...rest} =
-        options ?? ({} as GetTagRemovePropsOptions & Extra)
+      const {index, onClick, ...rest} = options
 
-      if (index === undefined) {
-        throw new Error('Pass index to getTagRemoveProps!')
+      if (!Number.isInteger(index) || index < 0) {
+        throw new Error('Pass correct item index to getTagRemoveProps!')
       }
 
       const handleClick = (event: React.MouseEvent) => {

src/hooks/useTagGroup/index.types.ts

@@ -51,7 +51,7 @@ export interface UseTagGroupReturnValue<Item> {
 }
 
 export interface GetTagPropsOptions extends React.HTMLProps<HTMLElement> {
-  index?: number
+  index: number
   refKey?: string
   ref?: React.MutableRefObject<HTMLElement>
 }
@@ -66,7 +66,7 @@ export interface GetTagPropsReturnValue {
 }
 
 export interface GetTagRemovePropsOptions extends React.HTMLProps<HTMLElement> {
-  index?: number
+  index: number
 }
 
 export interface GetTagRemovePropsReturnValue {
@@ -95,11 +95,11 @@ export type GetTagGroupProps = <Extra extends Record<string, unknown> = {}>(
 ) => GetTagGroupPropsReturnValue & Extra
 
 export type GetTagProps = <Extra extends Record<string, unknown> = {}>(
-  options?: GetTagPropsOptions & Extra,
+  options: GetTagPropsOptions & Extra,
 ) => GetTagPropsReturnValue & Extra
 
 export type GetTagRemoveProps = <Extra extends Record<string, unknown> = {}>(
-  options?: GetTagRemovePropsOptions & Extra,
+  options: GetTagRemovePropsOptions & Extra,
 ) => GetTagRemovePropsReturnValue & Extra
 
 export enum UseTagGroupStateChangeTypes {