Fix isBound function for surface set classes (#235)

Author: doyubkim

include/jet/implicit_surface_set2.h

@@ -44,6 +44,9 @@ class ImplicitSurfaceSet2 final : public ImplicitSurface2 {
     //! Updates internal spatial query engine.
     void updateQueryEngine() override;
 
+    //! Returns true if bounding box can be defined.
+    bool isBounded() const override;
+
     //! Returns true if the surface is a valid geometry.
     bool isValidGeometry() const override;
 

include/jet/implicit_surface_set3.h

@@ -44,6 +44,9 @@ class ImplicitSurfaceSet3 final : public ImplicitSurface3 {
     //! Updates internal spatial query engine.
     void updateQueryEngine() override;
 
+    //! Returns true if bounding box can be defined.
+    bool isBounded() const override;
+
     //! Returns true if the surface is a valid geometry.
     bool isValidGeometry() const override;
 

include/jet/surface_set2.h

@@ -39,6 +39,9 @@ class SurfaceSet2 final : public Surface2 {
     //! Updates internal spatial query engine.
     void updateQueryEngine() override;
 
+    //! Returns true if bounding box can be defined.
+    bool isBounded() const override;
+
     //! Returns true if the surface is a valid geometry.
     bool isValidGeometry() const override;
 

include/jet/surface_set3.h

@@ -39,6 +39,9 @@ class SurfaceSet3 final : public Surface3 {
     //! Updates internal spatial query engine.
     void updateQueryEngine() override;
 
+    //! Returns true if bounding box can be defined.
+    bool isBounded() const override;
+
     //! Returns true if the surface is a valid geometry.
     bool isValidGeometry() const override;
 

src/jet/implicit_surface_set2.cpp

@@ -41,6 +41,18 @@ ImplicitSurfaceSet2::ImplicitSurfaceSet2(const ImplicitSurfaceSet2& other)
 
 void ImplicitSurfaceSet2::updateQueryEngine() { buildBvh(); }
 
+bool ImplicitSurfaceSet2::isBounded() const {
+    // All surfaces should be bounded.
+    for (auto surface : _surfaces) {
+        if (!surface->isBounded()) {
+            return false;
+        }
+    }
+
+    // Empty set is not bounded.
+    return !_surfaces.empty();
+}
+
 bool ImplicitSurfaceSet2::isValidGeometry() const {
     // All surfaces should be valid.
     for (auto surface : _surfaces) {

src/jet/implicit_surface_set3.cpp

@@ -41,6 +41,18 @@ ImplicitSurfaceSet3::ImplicitSurfaceSet3(const ImplicitSurfaceSet3& other)
 
 void ImplicitSurfaceSet3::updateQueryEngine() { buildBvh(); }
 
+bool ImplicitSurfaceSet3::isBounded() const {
+    // All surfaces should be bounded.
+    for (auto surface : _surfaces) {
+        if (!surface->isBounded()) {
+            return false;
+        }
+    }
+
+    // Empty set is not bounded.
+    return !_surfaces.empty();
+}
+
 bool ImplicitSurfaceSet3::isValidGeometry() const {
     // All surfaces should be valid.
     for (auto surface : _surfaces) {

src/jet/surface2.cpp

@@ -60,7 +60,7 @@ bool Surface2::isBounded() const { return true; }
 bool Surface2::isValidGeometry() const { return true; }
 
 bool Surface2::isInside(const Vector2D& otherPoint) const {
-    return isInsideLocal(transform.toLocal(otherPoint));
+    return isNormalFlipped == !isInsideLocal(transform.toLocal(otherPoint));
 }
 
 bool Surface2::intersectsLocal(const Ray2D& rayLocal) const {

src/jet/surface3.cpp

@@ -65,7 +65,7 @@ bool Surface3::isBounded() const { return true; }
 bool Surface3::isValidGeometry() const { return true; }
 
 bool Surface3::isInside(const Vector3D& otherPoint) const {
-    return isInsideLocal(transform.toLocal(otherPoint));
+    return isNormalFlipped == !isInsideLocal(transform.toLocal(otherPoint));
 }
 
 double Surface3::closestDistanceLocal(const Vector3D& otherPointLocal) const {

src/jet/surface_set2.cpp

@@ -32,6 +32,18 @@ SurfaceSet2::SurfaceSet2(const SurfaceSet2& other)
 
 void SurfaceSet2::updateQueryEngine() { buildBvh(); }
 
+bool SurfaceSet2::isBounded() const {
+    // All surfaces should be bounded.
+    for (auto surface : _surfaces) {
+        if (!surface->isBounded()) {
+            return false;
+        }
+    }
+
+    // Empty set is not bounded.
+    return !_surfaces.empty();
+}
+
 bool SurfaceSet2::isValidGeometry() const {
     // All surfaces should be valid.
     for (auto surface : _surfaces) {

src/jet/surface_set3.cpp

@@ -32,6 +32,18 @@ SurfaceSet3::SurfaceSet3(const SurfaceSet3& other)
 
 void SurfaceSet3::updateQueryEngine() { buildBvh(); }
 
+bool SurfaceSet3::isBounded() const {
+    // All surfaces should be bounded.
+    for (auto surface : _surfaces) {
+        if (!surface->isBounded()) {
+            return false;
+        }
+    }
+
+    // Empty set is not bounded.
+    return !_surfaces.empty();
+}
+
 bool SurfaceSet3::isValidGeometry() const {
     // All surfaces should be valid.
     for (auto surface : _surfaces) {