Skip to content

Commit 60f38b3

Browse files
Set GITHUB_OWNER envvar so that github provider modules will work (#32)
* Added inputs for GITHUB overrides * Added conditional handling for terraform plan exitcodes --------- Co-authored-by: Guy Owen <[email protected]> Co-authored-by: Guy Owen <[email protected]>
1 parent b170a89 commit 60f38b3

File tree

4 files changed

+59
-25
lines changed

4 files changed

+59
-25
lines changed

.github/workflows/run_db_trigger.yml

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,25 +19,29 @@ on:
1919
description: 'S3 URI'
2020
required: true
2121
type: string
22+
runner:
23+
type: string
24+
required: false
25+
default: ubuntu-latest
2226

23-
24-
2527
secrets:
2628
AWS_ACCESS_KEY_ID:
2729
required: true
2830
AWS_SECRET_ACCESS_KEY:
2931
required: true
32+
REGISTRY_TOKEN:
33+
required: true
34+
REGISTRY_USER:
35+
required: true
3036
SLACK_WEBHOOK_URL:
3137
required: true
3238

33-
34-
3539
env:
3640
REGISTRY: ghcr.io
3741

3842
jobs:
3943
export-db:
40-
runs-on: biggy
44+
runs-on: ${{ inputs.runner }}
4145
permissions:
4246
contents: read
4347
packages: write
@@ -108,8 +112,8 @@ jobs:
108112
uses: docker/login-action@v3
109113
with:
110114
registry: ${{ env.REGISTRY }}
111-
username: ${{ github.actor }}
112-
password: ${{ secrets.GITHUB_TOKEN }}
115+
username: ${{ secrets.REGISTRY_USER }}
116+
password: ${{ secrets.REGISTRY_TOKEN }}
113117

114118
# Extract metadata (tags, labels) for Docker
115119
# https://github.com/docker/metadata-action

.github/workflows/tf_apply.yml

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,23 +12,31 @@ on:
1212
type: string
1313
required: false
1414
default: production
15+
tf_github_owner:
16+
description: Terraform GitHub repo owner
17+
type: string
18+
required: false
19+
default: dpc-sdp
1520

1621
env:
17-
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
18-
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
19-
AWS_DEFAULT_REGION: ${{ inputs.aws_default_region }}
20-
SUMOLOGIC_ACCESSID: ${{ secrets.SUMOLOGIC_ACCESSID }}
21-
SUMOLOGIC_ACCESSKEY: ${{ secrets.SUMOLOGIC_ACCESSKEY }}
2222
ARM_SUBSCRIPTION_ID: ${{ secrets.ARM_SUBSCRIPTION_ID }}
2323
ARM_CLIENT_ID: ${{ secrets.ARM_CLIENT_ID }}
2424
ARM_CLIENT_SECRET: ${{ secrets.ARM_CLIENT_SECRET }}
2525
ARM_TENANT_ID: ${{ secrets.ARM_TENANT_ID }}
26+
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
27+
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
28+
AWS_DEFAULT_REGION: ${{ inputs.aws_default_region }}
2629
EC_API_KEY: ${{ secrets.EC_API_KEY }}
30+
GITHUB_OWNER: ${{ inputs.TF_GITHUB_OWNER }}
31+
GITHUB_TOKEN: ${{ secrets.TF_GITHUB_TOKEN }}
32+
SUMOLOGIC_ACCESSID: ${{ secrets.SUMOLOGIC_ACCESSID }}
33+
SUMOLOGIC_ACCESSKEY: ${{ secrets.SUMOLOGIC_ACCESSKEY }}
2734

2835
jobs:
2936
apply:
3037
environment: ${{ inputs.environment }}
31-
runs-on: ubuntu-latest
38+
runs-on:
39+
group: organization/Default
3240
steps:
3341
- name: Checkout code
3442
uses: actions/checkout@v4

.github/workflows/tf_diffscheck.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,17 @@ on:
1313
default: "ops"
1414

1515
env:
16-
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
17-
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
18-
AWS_DEFAULT_REGION: ${{ inputs.aws_default_region }}
19-
SUMOLOGIC_ACCESSID: ${{ secrets.SUMOLOGIC_ACCESSID }}
20-
SUMOLOGIC_ACCESSKEY: ${{ secrets.SUMOLOGIC_ACCESSKEY }}
2116
ARM_SUBSCRIPTION_ID: ${{ secrets.ARM_SUBSCRIPTION_ID }}
2217
ARM_CLIENT_ID: ${{ secrets.ARM_CLIENT_ID }}
2318
ARM_CLIENT_SECRET: ${{ secrets.ARM_CLIENT_SECRET }}
2419
ARM_TENANT_ID: ${{ secrets.ARM_TENANT_ID }}
20+
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
21+
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
22+
AWS_DEFAULT_REGION: ${{ inputs.aws_default_region }}
2523
EC_API_KEY: ${{ secrets.EC_API_KEY }}
24+
GITHUB_OWNER: ${{ vars.TF_GITHUB_OWNER }}
25+
SUMOLOGIC_ACCESSID: ${{ secrets.SUMOLOGIC_ACCESSID }}
26+
SUMOLOGIC_ACCESSKEY: ${{ secrets.SUMOLOGIC_ACCESSKEY }}
2627

2728
jobs:
2829
diffscheck:

.github/workflows/tf_plan.yml

Lines changed: 28 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,21 +7,27 @@ on:
77
type: string
88
required: false
99
default: ap-southeast-2
10+
tf_github_owner:
11+
description: Terraform GitHub repo owner
12+
type: string
13+
required: false
14+
default: dpc-sdp
1015

1116
env:
12-
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
13-
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
14-
AWS_DEFAULT_REGION: ${{ inputs.aws_default_region }}
15-
SUMOLOGIC_ACCESSID: ${{ secrets.SUMOLOGIC_ACCESSID }}
16-
SUMOLOGIC_ACCESSKEY: ${{ secrets.SUMOLOGIC_ACCESSKEY }}
1717
ARM_SUBSCRIPTION_ID: ${{ secrets.ARM_SUBSCRIPTION_ID }}
1818
ARM_CLIENT_ID: ${{ secrets.ARM_CLIENT_ID }}
1919
ARM_CLIENT_SECRET: ${{ secrets.ARM_CLIENT_SECRET }}
2020
ARM_TENANT_ID: ${{ secrets.ARM_TENANT_ID }}
21+
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
22+
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
23+
AWS_DEFAULT_REGION: ${{ inputs.aws_default_region }}
2124
EC_API_KEY: ${{ secrets.EC_API_KEY }}
25+
GITHUB_OWNER: ${{ inputs.tf_github_owner }}
26+
GITHUB_TOKEN: ${{ secrets.TF_GITHUB_TOKEN }}
27+
SUMOLOGIC_ACCESSID: ${{ secrets.SUMOLOGIC_ACCESSID }}
28+
SUMOLOGIC_ACCESSKEY: ${{ secrets.SUMOLOGIC_ACCESSKEY }}
2229

2330
jobs:
24-
2531
plan:
2632
runs-on: ubuntu-latest
2733
steps:
@@ -48,7 +54,22 @@ jobs:
4854

4955
- name: Terraform Plan
5056
id: plan
51-
run: terraform plan -no-color -input=false -out=tfplan
57+
run: |
58+
set +e
59+
terraform plan -no-color -input=false -out=tfplan -detailed-exitcode
60+
exitcode="$?"
61+
echo "exitcode=$exitcode" >> $GITHUB_OUTPUT
62+
if [[ $exitcode -eq 2 ]]
63+
then
64+
exit 0
65+
else
66+
exit $exitcode
67+
fi
68+
69+
- name: Check Terraform Plan
70+
run: |
71+
echo "Terraform plan returned ${{ steps.plan.outputs.exitcode }}"
72+
echo "2 = Succeeded with non-empty diff (changes present) "
5273
5374
- name: Render plan diff
5475
id: show

0 commit comments

Comments
 (0)