chore: display profile's display name in reaction tooltip

Author: dpc

crates/rostra-core/src/event.rs

@@ -237,6 +237,12 @@ array_type_define!(
     64
 );
 
+impl fmt::Display for EventSignature {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        data_encoding::BASE64URL_NOPAD.encode_write(&self.0, f)
+    }
+}
+
 #[cfg_attr(feature = "bincode", derive(::bincode::Encode, ::bincode::Decode))]
 #[derive(Copy, Clone, PartialEq, Eq, PartialOrd, Ord, Hash, Debug)]
 pub struct EventKind([u8; 2]);

crates/rostra-core/src/id.rs

@@ -131,6 +131,11 @@ array_type_define_public!(struct ShortRostraId, 16);
 
 array_type_define_public!(struct RestRostraId, 16);
 
+impl fmt::Display for RestRostraId {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        data_encoding::BASE64URL_NOPAD.encode_write(&self.0, f)
+    }
+}
 impl fmt::Display for ShortRostraId {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         f.write_str("rs")?;

crates/rostra-core/src/macros.rs

@@ -6,7 +6,7 @@ macro_rules! array_type_define {
     ) => {
         $(#[$outer])*
         #[cfg_attr(feature = "bincode", derive(::bincode::Encode, ::bincode::Decode))]
-        #[derive(Copy, Clone, Hash, Debug)]
+        #[derive(Copy, Clone, Hash)]
         pub struct $t([u8; $n]);
 
         impl $t {
@@ -26,6 +26,12 @@ macro_rules! array_type_define {
                 self.0
             }
         }
+
+        impl std::fmt::Debug for $t {
+            fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+                <Self as std::fmt::Display>::fmt(self, f)
+            }
+        }
     }
 }
 

crates/rostra-web-ui/src/routes/timeline.rs

@@ -1,4 +1,4 @@
-use std::collections::HashSet;
+use std::collections::{HashMap, HashSet};
 use std::time::Duration;
 
 use axum::extract::ws::WebSocket;
@@ -534,12 +534,37 @@ impl UiState {
             vec![]
         };
 
+        let mut reaction_social_profiles: HashMap<RostraId, IdSocialProfileRecord> = HashMap::new();
+
+        for reaction_author in reactions
+            .iter()
+            .map(|reaction| reaction.author)
+            // collect to deduplicate
+            .collect::<HashSet<_>>()
+        {
+            // TODO: make a batched request for all profiles in one go
+            if let Some(reaction_user_profile) =
+                self.get_social_profile_opt(reaction_author, client).await
+            {
+                // HashSet above must have deduped it
+                assert!(reaction_social_profiles
+                    .insert(reaction_author, reaction_user_profile)
+                    .is_none());
+            }
+        }
+
         let reactions_html = html! {
             @for reaction in reactions {
                 @if let Some(reaction_text) = reaction.content.get_reaction() {
 
                     span .m-postOverview__reaction
-                        title=(format!("by {}", reaction.author))
+                        title=(
+                            format!("by {}",
+                                reaction_social_profiles.get(&reaction.author)
+                                    .map(|r| r.display_name.clone())
+                                    .unwrap_or_else(|| reaction.author.to_string())
+                            )
+                        )
                     {
                         (reaction_text)
                     }