Skip to content

Commit 36b50bc

Browse files
committed
fix defaultload
1 parent a37596f commit 36b50bc

File tree

2 files changed

+4
-11
lines changed

2 files changed

+4
-11
lines changed

flask_appbuilder/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
__author__ = "Daniel Vaz Gaspar"
2-
__version__ = "5.0.0a4"
2+
__version__ = "5.0.0a6"
33

44
from .actions import action # noqa: F401
55
from .api import ModelRestApi # noqa: F401

flask_appbuilder/models/sqla/interface.py

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
get_column_root_relation,
1919
is_column_dotted,
2020
)
21-
from flask_appbuilder.utils.legacy import is_flask_sqlalchemy_2
2221
from sqlalchemy import asc, desc
2322
from sqlalchemy import types as sa_types
2423
from sqlalchemy.exc import SQLAlchemyError
@@ -350,17 +349,11 @@ def apply_outer_select_joins(
350349
if self.is_relation_many_to_many(
351350
root_relation
352351
) or self.is_relation_one_to_many(root_relation):
353-
if outer_default_load and is_flask_sqlalchemy_2():
352+
if outer_default_load:
354353
load = (
355354
Load(self.obj)
356-
.defaultload(attr.of_type(alias))
357-
.load_only(leaf_column)
358-
)
359-
elif outer_default_load:
360-
load = (
361-
Load(self.obj)
362-
.defaultload(attr.of_type(alias))
363-
.load_only(leaf_column)
355+
.defaultload(attr)
356+
.load_only(getattr(related_model, get_column_leaf(column)))
364357
)
365358
else:
366359
query = query.join(alias, attr, isouter=True)

0 commit comments

Comments
 (0)