Skip to content

Commit c65e067

Browse files
authored
fix: Check if Oauth login with OKTA is correct (#1926)
1 parent 0ab8b4e commit c65e067

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

flask_appbuilder/security/manager.py

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -660,13 +660,17 @@ def get_oauth_user_info(
660660
me = self.appbuilder.sm.oauth_remotes[provider].get("userinfo")
661661
data = me.json()
662662
log.debug("User info from Okta: %s", data)
663-
return {
664-
"username": f"{provider}_{data['sub']}",
665-
"first_name": data.get("given_name", ""),
666-
"last_name": data.get("family_name", ""),
667-
"email": data["email"],
668-
"role_keys": data.get("groups", []),
669-
}
663+
if "error" not in data:
664+
return {
665+
"username": f"{provider}_{data['sub']}",
666+
"first_name": data.get("given_name", ""),
667+
"last_name": data.get("family_name", ""),
668+
"email": data["email"],
669+
"role_keys": data.get("groups", []),
670+
}
671+
else:
672+
log.error(data.get("error_description"))
673+
return {}
670674
# for Auth0
671675
if provider == "auth0":
672676
data = self.appbuilder.sm.oauth_remotes[provider].userinfo()

0 commit comments

Comments
 (0)