Skip to content

Commit 33c303e

Browse files
author
dphuang2
committed
label = "Opinion"
1 parent ab085cd commit 33c303e

File tree

3 files changed

+15
-15
lines changed

3 files changed

+15
-15
lines changed

blog/2023-12-11-grpc/grpc.mdx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ service-to-service developer experience and performance remarkably.
131131
</CarouselContent>
132132
<CarouselPrevious />
133133
<CarouselNext />
134-
<CarouselIndicator />
134+
<CarouselIndicator label="Opinion"/>
135135
</Carousel>
136136

137137
#### Key Takeaway 🔑
@@ -185,7 +185,7 @@ confusing for quickly building applications.
185185
</CarouselContent>
186186
<CarouselPrevious />
187187
<CarouselNext />
188-
<CarouselIndicator />
188+
<CarouselIndicator label="Opinion"/>
189189
</Carousel>
190190

191191
#### Key Takeaway 🔑
@@ -277,7 +277,7 @@ authentication and browser support are complicated by gRPC.
277277
</CarouselContent>
278278
<CarouselPrevious />
279279
<CarouselNext />
280-
<CarouselIndicator />
280+
<CarouselIndicator label="Opinion"/>
281281
</Carousel>
282282

283283
#### Key Takeaway 🔑
@@ -344,7 +344,7 @@ The world is built on standards and REST is no exception.
344344
</CarouselContent>
345345
<CarouselPrevious />
346346
<CarouselNext />
347-
<CarouselIndicator />
347+
<CarouselIndicator label="Opinion"/>
348348
</Carousel>
349349

350350
#### Key Takeaway 🔑
@@ -391,7 +391,7 @@ services.
391391
</CarouselContent>
392392
<CarouselPrevious />
393393
<CarouselNext />
394-
<CarouselIndicator />
394+
<CarouselIndicator label="Opinion"/>
395395
</Carousel>
396396

397397
#### Key Takeaway 🔑
@@ -441,7 +441,7 @@ lot of open source tooling that needs to be built.
441441
</CarouselContent>
442442
<CarouselPrevious />
443443
<CarouselNext />
444-
<CarouselIndicator />
444+
<CarouselIndicator label="Opinion"/>
445445
</Carousel>
446446

447447
#### Key Takeaway 🔑

blog/2024-04-29-htmx/htmx.mdx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ excited, and others are just curious.
6868
</CarouselContent>
6969
<CarouselPrevious />
7070
<CarouselNext />
71-
<CarouselIndicator/>
71+
<CarouselIndicator label="Opinion"/>
7272
</Carousel>
7373

7474
To analyze how developers truly feel about HTMX, I went to where developers
@@ -145,7 +145,7 @@ of building user interfaces.
145145
</CarouselContent>
146146
<CarouselPrevious />
147147
<CarouselNext />
148-
<CarouselIndicator/>
148+
<CarouselIndicator label="Opinion"/>
149149
</Carousel>
150150

151151
#### Takeaway
@@ -190,7 +190,7 @@ might be ignoring the modern best practices of building web applications.
190190
</CarouselContent>
191191
<CarouselPrevious />
192192
<CarouselNext />
193-
<CarouselIndicator/>
193+
<CarouselIndicator label="Opinion"/>
194194
</Carousel>
195195

196196
#### Takeaway
@@ -251,7 +251,7 @@ engineerings teams less productive and codebases more complex.
251251
</CarouselContent>
252252
<CarouselPrevious />
253253
<CarouselNext />
254-
<CarouselIndicator/>
254+
<CarouselIndicator label="Opinion"/>
255255
</Carousel>
256256

257257
#### Takeaway
@@ -304,7 +304,7 @@ HTMX is only good for simple use-cases.
304304
</CarouselContent>
305305
<CarouselPrevious />
306306
<CarouselNext />
307-
<CarouselIndicator/>
307+
<CarouselIndicator label="Opinion"/>
308308
</Carousel>
309309

310310
#### Takeaway
@@ -395,7 +395,7 @@ developers of the application.
395395
</CarouselContent>
396396
<CarouselPrevious />
397397
<CarouselNext />
398-
<CarouselIndicator/>
398+
<CarouselIndicator label="Opinion"/>
399399
</Carousel>
400400

401401
#### Takeaway

src/components/ui/carousel.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -292,8 +292,8 @@ CarouselNext.displayName = "CarouselNext";
292292

293293
const CarouselIndicator = React.forwardRef<
294294
HTMLDivElement,
295-
React.HTMLAttributes<HTMLDivElement>
296-
>(({ className, ...props }, ref) => {
295+
React.HTMLAttributes<HTMLDivElement> & { label?: string }
296+
>(({ className, label = "Slide", ...props }, ref) => {
297297
const { current, total } = useCarousel();
298298

299299
return (
@@ -302,7 +302,7 @@ const CarouselIndicator = React.forwardRef<
302302
className={cn("text-center text-sm text-muted-foreground", className)}
303303
{...props}
304304
>
305-
Slide {current} of {total}
305+
{label} {current} of {total}
306306
</div>
307307
);
308308
});

0 commit comments

Comments
 (0)