Commit 38ee3ad
[9.1] [ML][AI Connector] Ensure testing validation for Elastic Managed LLM works as expected (elastic#231873) (elastic#233518)
# Backport
This will backport the following commits from `main` to `9.1`:
- [[ML][AI Connector] Ensure testing validation for Elastic Managed LLM
works as expected
(elastic#231873)](elastic#231873)
<!--- Backport version: 10.0.1 -->
### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)
<!--BACKPORT [{"author":{"name":"Melissa
Alvarez","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-08-27T19:35:05Z","message":"[ML][AI
Connector] Ensure testing validation for Elastic Managed LLM works as
expected (elastic#231873)\n\n## Summary\n\nFixes
https://github.com/elastic/kibana/issues/222006\n### TODO: Needs to be
backported to 9.1.4\n(After Aug 28)\n\nProblem was occurring in the
`UnifiedCompletionParamsFields` component\nin the `onDocumentChange` -
`JSON.parse(json)` had an unhandled error\nwhen the string was not valid
JSON. This was preventing the validation\nfrom running and allowing the
`Run` button to remain active.\n\nThis PR handles the case of invalid
JSON and updates messaging for the\nuser when that is the case. The
`Run` button is now disabled when the\ntest string is invalid
JSON.\n\n\n\nhttps://github.com/user-attachments/assets/3c206596-3bd2-409a-8d31-fbc5b8a7c491\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [ ] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[
]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas
added for features that require explanation or tutorials\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [ ] If a plugin
configuration key changed, check if it needs to be\nallowlisted in the
cloud and added to the
[docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n-
[ ] This was checked for breaking HTTP API changes, and any
breaking\nchanges have been approved by the breaking-change committee.
The\n`release_note:breaking` label should be applied in these
situations.\n- [ ] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n- [ ] The PR description includes the
appropriate Release Notes section,\nand the correct `release_note:*`
label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n-
[ ] Review the
[backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand
apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by:
Elastic Machine
<[email protected]>\nCo-authored-by: Dima Arnautov
<[email protected]>","sha":"00ad9b9ed09355a65220d90ac6961c8685313da7","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","backport:skip","Feature:Inference
UI","v9.2.0"],"title":"[ML][AI Connector] Ensure testing validation for
Elastic Managed LLM works as
expected","number":231873,"url":"https://github.com/elastic/kibana/pull/231873","mergeCommit":{"message":"[ML][AI
Connector] Ensure testing validation for Elastic Managed LLM works as
expected (elastic#231873)\n\n## Summary\n\nFixes
https://github.com/elastic/kibana/issues/222006\n### TODO: Needs to be
backported to 9.1.4\n(After Aug 28)\n\nProblem was occurring in the
`UnifiedCompletionParamsFields` component\nin the `onDocumentChange` -
`JSON.parse(json)` had an unhandled error\nwhen the string was not valid
JSON. This was preventing the validation\nfrom running and allowing the
`Run` button to remain active.\n\nThis PR handles the case of invalid
JSON and updates messaging for the\nuser when that is the case. The
`Run` button is now disabled when the\ntest string is invalid
JSON.\n\n\n\nhttps://github.com/user-attachments/assets/3c206596-3bd2-409a-8d31-fbc5b8a7c491\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [ ] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[
]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas
added for features that require explanation or tutorials\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [ ] If a plugin
configuration key changed, check if it needs to be\nallowlisted in the
cloud and added to the
[docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n-
[ ] This was checked for breaking HTTP API changes, and any
breaking\nchanges have been approved by the breaking-change committee.
The\n`release_note:breaking` label should be applied in these
situations.\n- [ ] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n- [ ] The PR description includes the
appropriate Release Notes section,\nand the correct `release_note:*`
label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n-
[ ] Review the
[backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand
apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by:
Elastic Machine
<[email protected]>\nCo-authored-by: Dima Arnautov
<[email protected]>","sha":"00ad9b9ed09355a65220d90ac6961c8685313da7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/231873","number":231873,"mergeCommit":{"message":"[ML][AI
Connector] Ensure testing validation for Elastic Managed LLM works as
expected (elastic#231873)\n\n## Summary\n\nFixes
https://github.com/elastic/kibana/issues/222006\n### TODO: Needs to be
backported to 9.1.4\n(After Aug 28)\n\nProblem was occurring in the
`UnifiedCompletionParamsFields` component\nin the `onDocumentChange` -
`JSON.parse(json)` had an unhandled error\nwhen the string was not valid
JSON. This was preventing the validation\nfrom running and allowing the
`Run` button to remain active.\n\nThis PR handles the case of invalid
JSON and updates messaging for the\nuser when that is the case. The
`Run` button is now disabled when the\ntest string is invalid
JSON.\n\n\n\nhttps://github.com/user-attachments/assets/3c206596-3bd2-409a-8d31-fbc5b8a7c491\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [ ] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[
]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas
added for features that require explanation or tutorials\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [ ] If a plugin
configuration key changed, check if it needs to be\nallowlisted in the
cloud and added to the
[docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n-
[ ] This was checked for breaking HTTP API changes, and any
breaking\nchanges have been approved by the breaking-change committee.
The\n`release_note:breaking` label should be applied in these
situations.\n- [ ] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n- [ ] The PR description includes the
appropriate Release Notes section,\nand the correct `release_note:*`
label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n-
[ ] Review the
[backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand
apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by:
Elastic Machine
<[email protected]>\nCo-authored-by: Dima Arnautov
<[email protected]>","sha":"00ad9b9ed09355a65220d90ac6961c8685313da7"}}]}]
BACKPORT-->
Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Dima Arnautov <[email protected]>1 parent 9ab7448 commit 38ee3ad
File tree
4 files changed
+29
-4
lines changed4 files changed
+29
-4
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
94 | | - | |
| 94 | + | |
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
| |||
Lines changed: 13 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
61 | 72 | | |
62 | | - | |
63 | | - | |
| 73 | + | |
| 74 | + | |
64 | 75 | | |
65 | 76 | | |
66 | 77 | | |
| |||
Lines changed: 8 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
195 | 195 | | |
196 | 196 | | |
197 | 197 | | |
198 | | - | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
199 | 206 | | |
200 | 207 | | |
201 | 208 | | |
| |||
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
0 commit comments