Skip to content

Commit 7d56967

Browse files
Merge pull request openstack-k8s-operators#305 from Deydra71/fix-secret-watching
Index simpleCryptoBackendSecretField
2 parents e5cb269 + 3c89cb6 commit 7d56967

File tree

4 files changed

+41
-1
lines changed

4 files changed

+41
-1
lines changed

controllers/barbican_controller.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -561,7 +561,8 @@ func (r *BarbicanReconciler) reconcileDelete(ctx context.Context, instance *barb
561561
// fields to index to reconcile when change
562562
const (
563563
passwordSecretField = ".spec.secret"
564-
caBundleSecretNameField = ".spec.tls.caBundleSecretName" // #nosec G101
564+
simpleCryptoBackendSecretField = ".spec.simpleCryptoBackendSecret" // #nosec G101
565+
caBundleSecretNameField = ".spec.tls.caBundleSecretName" // #nosec G101
565566
tlsAPIInternalField = ".spec.tls.api.internal.secretName"
566567
tlsAPIPublicField = ".spec.tls.api.public.secretName"
567568
pkcs11LoginSecretField = ".spec.pkcs11.loginSecret" // #nosec G101
@@ -574,6 +575,7 @@ const (
574575
var (
575576
workerWatchFields = []string{
576577
passwordSecretField,
578+
simpleCryptoBackendSecretField,
577579
caBundleSecretNameField,
578580
pkcs11LoginSecretField,
579581
pkcs11ClientDataSecretField,
@@ -583,6 +585,7 @@ var (
583585
}
584586
apiWatchFields = []string{
585587
passwordSecretField,
588+
simpleCryptoBackendSecretField,
586589
caBundleSecretNameField,
587590
tlsAPIInternalField,
588591
tlsAPIPublicField,
@@ -594,6 +597,7 @@ var (
594597
}
595598
listenerWatchFields = []string{
596599
passwordSecretField,
600+
simpleCryptoBackendSecretField,
597601
caBundleSecretNameField,
598602
topologyField,
599603
customServiceConfigSecretsField,

controllers/barbicanapi_controller.go

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -941,6 +941,18 @@ func (r *BarbicanAPIReconciler) SetupWithManager(mgr ctrl.Manager) error {
941941
return err
942942
}
943943

944+
// index simpleCryptoBackendSecretField
945+
if err := mgr.GetFieldIndexer().IndexField(context.Background(), &barbicanv1beta1.BarbicanAPI{}, simpleCryptoBackendSecretField, func(rawObj client.Object) []string {
946+
// Extract the secret name from the spec, if one is provided
947+
cr := rawObj.(*barbicanv1beta1.BarbicanAPI)
948+
if cr.Spec.SimpleCryptoBackendSecret == "" {
949+
return nil
950+
}
951+
return []string{cr.Spec.SimpleCryptoBackendSecret}
952+
}); err != nil {
953+
return err
954+
}
955+
944956
// index caBundleSecretNameField
945957
if err := mgr.GetFieldIndexer().IndexField(context.Background(), &barbicanv1beta1.BarbicanAPI{}, caBundleSecretNameField, func(rawObj client.Object) []string {
946958
// Extract the secret name from the spec, if one is provided

controllers/barbicankeystonelistener_controller.go

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -700,6 +700,18 @@ func (r *BarbicanKeystoneListenerReconciler) SetupWithManager(mgr ctrl.Manager)
700700
return err
701701
}
702702

703+
// index simpleCryptoBackendSecretField
704+
if err := mgr.GetFieldIndexer().IndexField(context.Background(), &barbicanv1beta1.BarbicanKeystoneListener{}, simpleCryptoBackendSecretField, func(rawObj client.Object) []string {
705+
// Extract the secret name from the spec, if one is provided
706+
cr := rawObj.(*barbicanv1beta1.BarbicanKeystoneListener)
707+
if cr.Spec.SimpleCryptoBackendSecret == "" {
708+
return nil
709+
}
710+
return []string{cr.Spec.SimpleCryptoBackendSecret}
711+
}); err != nil {
712+
return err
713+
}
714+
703715
// index caBundleSecretNameField
704716
if err := mgr.GetFieldIndexer().IndexField(context.Background(), &barbicanv1beta1.BarbicanKeystoneListener{}, caBundleSecretNameField, func(rawObj client.Object) []string {
705717
// Extract the secret name from the spec, if one is provided

controllers/barbicanworker_controller.go

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -697,6 +697,18 @@ func (r *BarbicanWorkerReconciler) SetupWithManager(mgr ctrl.Manager) error {
697697
return err
698698
}
699699

700+
// index simpleCryptoBackendSecretField
701+
if err := mgr.GetFieldIndexer().IndexField(context.Background(), &barbicanv1beta1.BarbicanWorker{}, simpleCryptoBackendSecretField, func(rawObj client.Object) []string {
702+
// Extract the secret name from the spec, if one is provided
703+
cr := rawObj.(*barbicanv1beta1.BarbicanWorker)
704+
if cr.Spec.SimpleCryptoBackendSecret == "" {
705+
return nil
706+
}
707+
return []string{cr.Spec.SimpleCryptoBackendSecret}
708+
}); err != nil {
709+
return err
710+
}
711+
700712
// index caBundleSecretNameField
701713
if err := mgr.GetFieldIndexer().IndexField(context.Background(), &barbicanv1beta1.BarbicanWorker{}, caBundleSecretNameField, func(rawObj client.Object) []string {
702714
// Extract the secret name from the spec, if one is provided

0 commit comments

Comments
 (0)