Skip to content

Commit 8e30bc3

Browse files
committed
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime.
1 parent f8d7a89 commit 8e30bc3

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

Makefile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,8 @@ IMG ?= $(DEFAULT_IMG)
5656
# ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary.
5757
ENVTEST_K8S_VERSION = 1.31
5858

59+
SETUP_ENVTEST_VERSION ?= release-0.22
60+
5961
# Get the currently used golang install path (in GOPATH/bin, unless GOBIN is set)
6062
ifeq (,$(shell go env GOBIN))
6163
GOBIN=$(shell go env GOPATH)/bin
@@ -229,7 +231,7 @@ $(CONTROLLER_GEN): $(LOCALBIN)
229231
.PHONY: envtest
230232
envtest: $(ENVTEST) ## Download envtest-setup locally if necessary.
231233
$(ENVTEST): $(LOCALBIN)
232-
test -s $(LOCALBIN)/setup-envtest || GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
234+
test -s $(LOCALBIN)/setup-envtest || GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@$(SETUP_ENVTEST_VERSION)
233235

234236
.PHONY: ginkgo
235237
ginkgo: $(GINKGO) ## Download ginkgo locally if necessary.

controllers/barbicanapi_controller.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -542,8 +542,12 @@ func (r *BarbicanAPIReconciler) reconcileDelete(ctx context.Context, instance *b
542542

543543
// Remove the finalizer from our KeystoneEndpoint CR
544544
keystoneEndpoint, err := keystonev1.GetKeystoneEndpointWithName(ctx, helper, instance.Name, instance.Namespace)
545-
if err != nil && !k8s_errors.IsNotFound(err) {
546-
return ctrl.Result{}, err
545+
if err != nil {
546+
if k8s_errors.IsNotFound(err) {
547+
Log.Info(fmt.Sprintf("KeystoneEndpoint %s not found during delete - already cleaned up", instance.Name))
548+
} else {
549+
return ctrl.Result{}, err
550+
}
547551
}
548552

549553
if err == nil {

0 commit comments

Comments
 (0)