fix: unwrap outer parens if it's the RHS of a var declaration (#458)

Author: Declan Vong

src/generation/generate.rs

@@ -2722,12 +2722,26 @@ fn should_skip_paren_expr(node: &ParenExpr, context: &Context) -> bool {
     return true;
   }
 
+  // skip explicitly parsing this as a paren expr as that will be handled
+  // in the JSX element/fragment and it might collapse back to not having a paren expr
+  if matches!(node.expr.kind(), NodeKind::JSXElement | NodeKind::JSXFragment) {
+    return is_jsx_paren_expr_handled_node(node.expr.into(), context);
+  }
+
   if let Node::AssignExpr(assign_expr) = parent {
     if assign_expr.right.range().contains(&node.range()) {
       return true;
     }
   }
 
+  if let Node::VarDeclarator(var_decl) = parent {
+    if let Some(init) = var_decl.init {
+      if init.range().contains(&node.range()) {
+        return true;
+      }
+    }
+  }
+
   // skip over an expr or spread if not a spread
   if let Some(expr_or_spread) = parent.to::<ExprOrSpread>() {
     // these should only appear in these nodes
@@ -2747,9 +2761,7 @@ fn should_skip_paren_expr(node: &ParenExpr, context: &Context) -> bool {
     }
   }
 
-  // skip explicitly parsing this as a paren expr as that will be handled
-  // in the JSX element/fragment and it might collapse back to not having a paren expr
-  is_jsx_paren_expr_handled_node(node.expr.into(), context)
+  false
 }
 
 fn gen_sequence_expr<'a>(node: &'a SeqExpr, context: &mut Context<'a>) -> PrintItems {

tests/specs/expressions/ParenExpr/ParenExpr_All.txt

@@ -26,6 +26,22 @@ const test = (
 [expect]
 (x.test as unknown) = 6;
 
+== should not keep paren expr on right hand side of assignment ==
+const a = (1);
+const b = ((((1))));
+const c = (1 + 1) + 1;
+const d = 1 + (1 + 1);
+// except here it should because of the type assertion
+const e = /** @type {number} */ (((1)));
+
+[expect]
+const a = 1;
+const b = 1;
+const c = (1 + 1) + 1;
+const d = 1 + (1 + 1);
+// except here it should because of the type assertion
+const e = /** @type {number} */ (1);
+
 == should ignore paren exprs within paren exprs ==
 (((test)));
 (