integrated benchmark

Author: dragon7307

src/Extensions/ReadOnlySpan/Linq/Where.cs

@@ -15,17 +15,17 @@ public static partial class ReadOnlySpanExtensions
         /// <exception cref="ArgumentNullException"><paramref name="predicate"/> is null.</exception>
         public static IEnumerable<T> Where<T>(this ReadOnlySpan<T> source, Predicate<T> predicate)
         {
-            ReadOnlySpan<T>.Enumerator e = source.GetEnumerator();
+            List<T> list = new List<T>();
 
-            while(e.MoveNext())
+            foreach (T current in source)
             {
-                T current = e.Current;
-
-                if(predicate(current)) 
+                if(predicate(current))
                 {
-                    yield return current;
+                    list.Add(current);
                 }
             }
+
+            return list;
         }
 
         /// <summary>
@@ -38,15 +38,19 @@ public static IEnumerable<T> Where<T>(this ReadOnlySpan<T> source, Predicate<T>
         /// <exception cref="ArgumentNullException"><paramref name="predicate"/> is null.</exception>
         public static IEnumerable<T> Where<T>(this ReadOnlySpan<T> source, Func<T, int, bool> predicate)
         {
+            List<T> list = new List<T>();
+            
             for(int i = 0; i < source.Length; i++)
             {
                 T current = source[i];
 
                 if(predicate(current, i))
                 {
-                    yield return current;
+                    list.Add(current);
                 }
             }
+
+            return list;
         }
     }
 }

tests/Performance/Tests/ReadOnlySpan/Split/ReadOnlySpan_Split_Count_Benchmark.cs

@@ -39,7 +39,7 @@ public int Split_CutLastElements_ReadOnlySpan(ReadOnlySpan<char> value, char del
     {
         int length = 0;
 
-        foreach(ReadOnlySpan<char> part in value.Split(delimiter, count, CountExceedingBehaviour.CutLastElements))
+        foreach(ReadOnlySpan<char> part in value.Split(delimiter, count, CountExceedingBehaviour.CutRemainingElements))
         {
             length += part.Length;
         }

tests/Performance/Tests/ReadOnlySpan/Split/ReadOnlySpan_Split_Count_StringSplitOptions_Benchmark.cs

@@ -39,7 +39,7 @@ public int Split_Count_StringSplitOptions_CountExceedingBehaviour_CutLastElement
     {
         int length = 0;
 
-        foreach(ReadOnlySpan<char> part in value.Split(delimiter, count, options, CountExceedingBehaviour.CutLastElements))
+        foreach(ReadOnlySpan<char> part in value.Split(delimiter, count, options, CountExceedingBehaviour.CutRemainingElements))
         {
             length += part.Length;
         }

tests/Performance/Tests/ReadOnlySpan/SplitSequence/ReadOnlySpan_SplitSequence_Count_Benchmark.cs

@@ -39,7 +39,7 @@ public int Split_CutLastElements_ReadOnlySpan(ReadOnlySpan<char> value, ReadOnly
     {
         int length = 0;
 
-        foreach(ReadOnlySpan<char> part in value.Split(delimiter, count, CountExceedingBehaviour.CutLastElements))
+        foreach(ReadOnlySpan<char> part in value.Split(delimiter, count, CountExceedingBehaviour.CutRemainingElements))
         {
             length += part.Length;
         }

tests/Performance/Tests/ReadOnlySpan/SplitSequence/ReadOnlySpan_SplitSequence_Count_StringSplitOptions_Benchmark.cs

@@ -39,7 +39,7 @@ public int Split_Count_StringSplitOptions_CountExceedingBehaviour_CutLastElement
     {
         int length = 0;
 
-        foreach(ReadOnlySpan<char> part in value.Split(delimiter, count, options, CountExceedingBehaviour.CutLastElements))
+        foreach(ReadOnlySpan<char> part in value.Split(delimiter, count, options, CountExceedingBehaviour.CutRemainingElements))
         {
             length += part.Length;
         }