simplified checking for StringSplitOptions flags

Author: Guiorgy

src/Enumerators/Split/SpanSplitStringSplitOptionsEnumerator.cs

@@ -29,12 +29,8 @@ public SpanSplitStringSplitOptionsEnumerator(ReadOnlySpan<char> source, char del
         {
             Span = source;
             Delimiter = delimiter;
-#if NET5_0_OR_GREATER
-            TrimEntries = options.HasFlag(StringSplitOptions.TrimEntries);
-#else
-            TrimEntries = false;
-#endif
-            RemoveEmptyEntries = options.HasFlag(StringSplitOptions.RemoveEmptyEntries);
+            TrimEntries = options.IsTrimEntriesSet();
+            RemoveEmptyEntries = options.IsRemoveEmptyEntriesSet();
             EnumerationDone = false;
             Current = default;
         }

src/Enumerators/Split/SpanSplitStringSplitOptionsWithCountEnumerator.cs

@@ -34,12 +34,8 @@ public SpanSplitStringSplitOptionsWithCountEnumerator(ReadOnlySpan<char> source,
             Span = source;
             Delimiter = delimiter;
             CurrentCount = count.ThrowIfNegative();
-#if NET5_0_OR_GREATER
-            TrimEntries = options.HasFlag(StringSplitOptions.TrimEntries);
-#else
-            TrimEntries = false;
-#endif
-            RemoveEmptyEntries = options.HasFlag(StringSplitOptions.RemoveEmptyEntries);
+            TrimEntries = options.IsTrimEntriesSet();
+            RemoveEmptyEntries = options.IsRemoveEmptyEntriesSet();
             CountExceedingBehaviour = countExceedingBehaviour.ThrowIfInvalid();
             EnumerationDone = count == 0;
             Current = default;

src/Enumerators/SplitAny/SpanSplitAnyStringSplitOptionsEnumerator.cs

@@ -29,12 +29,8 @@ public SpanSplitAnyStringSplitOptionsEnumerator(ReadOnlySpan<char> source, ReadO
         {
             Span = source;
             Delimiters = delimiters;
-#if NET5_0_OR_GREATER
-            TrimEntries = options.HasFlag(StringSplitOptions.TrimEntries);
-#else
-            TrimEntries = false;
-#endif
-            RemoveEmptyEntries = options.HasFlag(StringSplitOptions.RemoveEmptyEntries);
+            TrimEntries = options.IsTrimEntriesSet();
+            RemoveEmptyEntries = options.IsRemoveEmptyEntriesSet();
             EnumerationDone = false;
             Current = default;
         }

src/Enumerators/SplitAny/SpanSplitAnyStringSplitOptionsWithCountEnumerator.cs

@@ -34,12 +34,8 @@ public SpanSplitAnyStringSplitOptionsWithCountEnumerator(ReadOnlySpan<char> sour
             Span = source;
             Delimiters = delimiters;
             CurrentCount = count.ThrowIfNegative();
-#if NET5_0_OR_GREATER
-            TrimEntries = options.HasFlag(StringSplitOptions.TrimEntries);
-#else
-            TrimEntries = false;
-#endif
-            RemoveEmptyEntries = options.HasFlag(StringSplitOptions.RemoveEmptyEntries);
+            TrimEntries = options.IsTrimEntriesSet();
+            RemoveEmptyEntries = options.IsRemoveEmptyEntriesSet();
             CountExceedingBehaviour = countExceedingBehaviour.ThrowIfInvalid();
             EnumerationDone = count == 0;
             Current = default;

src/Enumerators/SplitSequence/SpanSplitSequenceStringSplitOptionsEnumerator.cs

@@ -30,12 +30,8 @@ public SpanSplitSequenceStringSplitOptionsEnumerator(ReadOnlySpan<char> source,
             Span = source;
             Delimiter = delimiter;
             DelimiterLength = delimiter.Length;
-#if NET5_0_OR_GREATER
-            TrimEntries = options.HasFlag(StringSplitOptions.TrimEntries);
-#else
-            TrimEntries = false;
-#endif
-            RemoveEmptyEntries = options.HasFlag(StringSplitOptions.RemoveEmptyEntries);
+            TrimEntries = options.IsTrimEntriesSet();
+            RemoveEmptyEntries = options.IsRemoveEmptyEntriesSet();
             EnumerationDone = false;
             Current = default;
         }

src/Enumerators/SplitSequence/SpanSplitSequenceStringSplitOptionsWithCountEnumerator.cs

@@ -35,12 +35,8 @@ public SpanSplitSequenceStringSplitOptionsWithCountEnumerator(ReadOnlySpan<char>
             Delimiter = delimiter;
             DelimiterLength = delimiter.Length;
             CurrentCount = count.ThrowIfNegative();
-#if NET5_0_OR_GREATER
-            TrimEntries = options.HasFlag(StringSplitOptions.TrimEntries);
-#else
-            TrimEntries = false;
-#endif
-            RemoveEmptyEntries = options.HasFlag(StringSplitOptions.RemoveEmptyEntries);
+            TrimEntries = options.IsTrimEntriesSet();
+            RemoveEmptyEntries = options.IsRemoveEmptyEntriesSet();
             CountExceedingBehaviour = countExceedingBehaviour.ThrowIfInvalid();
             EnumerationDone = count == 0;
             Current = default;

src/InternalExtensions.cs

@@ -33,5 +33,32 @@ public static int ThrowIfNegative(this int value
 
             return value;
         }
+
+        /// <summary>
+        /// Determines whether the <see cref="StringSplitOptions.RemoveEmptyEntries"/> bit field is set in the current instance.
+        /// </summary>
+        /// <param name="options">The <see cref="StringSplitOptions"/> instance to test.</param>
+        /// <returns><see langword="true"/> if <paramref name="options"/> has the <see cref="StringSplitOptions.RemoveEmptyEntries"/> bit field set; <see langword="false"/> otherwise.</returns>
+        public static bool IsRemoveEmptyEntriesSet(this StringSplitOptions options)
+        {
+            return options.HasFlag(StringSplitOptions.RemoveEmptyEntries);
+        }
+
+        /// <summary>
+        /// Determines whether the <see cref="StringSplitOptions.TrimEntries"/> bit field is set in the current instance.
+        /// </summary>
+        /// <remarks>
+        /// In runtimes before .NET 5 this always returns <see langword="false"/>.
+        /// </remarks>
+        /// <param name="options">The <see cref="StringSplitOptions"/> instance to test.</param>
+        /// <returns><see langword="true"/> if <paramref name="options"/> has the <see cref="StringSplitOptions.TrimEntries"/> bit field set; <see langword="false"/> otherwise.</returns>
+        public static bool IsTrimEntriesSet(this StringSplitOptions options)
+        {
+#if NET5_0_OR_GREATER
+            return options.HasFlag(StringSplitOptions.TrimEntries);
+#else
+            return false;
+#endif
+        }
     }
 }