Skip to content

Commit 502f718

Browse files
authored
Added onSwipe callback + Fixed DatePicker inset icon (46.12.5) (#653)
* Added onSwipe to DeckSwiper and Swiper * Fixed datepicker inset icon not properly positioned * v46.12.5
1 parent 80c84af commit 502f718

File tree

13 files changed

+41
-21
lines changed

13 files changed

+41
-21
lines changed

example/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@draftbit/example",
33
"description": "Example app for @draftbit/ui",
4-
"version": "46.12.4",
4+
"version": "46.12.5",
55
"private": true,
66
"main": "__generated__/AppEntry.js",
77
"scripts": {
@@ -15,8 +15,8 @@
1515
"clean:modules": "rimraf node_modules"
1616
},
1717
"dependencies": {
18-
"@draftbit/maps": "46.12.4",
19-
"@draftbit/ui": "46.12.4",
18+
"@draftbit/maps": "46.12.5",
19+
"@draftbit/ui": "46.12.5",
2020
"@expo/dev-server": "0.1.120",
2121
"@expo/webpack-config": "^0.17.0",
2222
"@react-navigation/drawer": "^5.7.7",

example/src/DeckSwiperExample.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ const DeckSwiperExample: React.FC = () => {
5050
infiniteSwiping
5151
visibleCardCount={2}
5252
data={sampleData}
53+
onSwipe={(index) => console.log("Swiped", index)}
5354
onSwipedDown={(index) => console.log("Swiped down", index)}
5455
onSwipedUp={(index) => console.log("Swiped up", index)}
5556
onSwipedLeft={(index) => console.log("Swiped left", index)}

example/src/SwiperExample.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ function SwiperExample({ theme }) {
3636
style={{ width: "100%", height: 300 }}
3737
dotColor="green"
3838
dotActiveColor="red"
39+
onSwipe={(index) => console.log("Swiped", index)}
3940
onSwipedNext={(index) => console.log("Swiped next", index)}
4041
onSwipedPrevious={(index) => console.log("Swiped previous", index)}
4142
onIndexChanged={(index) => console.log("onIndexChanged: ", index)}

lerna.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"version": "46.12.4",
2+
"version": "46.12.5",
33
"npmClient": "yarn",
44
"useWorkspaces": true,
55
"packages": ["packages/*", "example"],

packages/core/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@draftbit/core",
3-
"version": "46.12.4",
3+
"version": "46.12.5",
44
"description": "Core (non-native) Components",
55
"main": "lib/commonjs/index.js",
66
"module": "lib/module/index.js",
@@ -41,7 +41,7 @@
4141
"dependencies": {
4242
"@date-io/date-fns": "^1.3.13",
4343
"@draftbit/react-theme-provider": "^2.1.1",
44-
"@draftbit/types": "46.12.4",
44+
"@draftbit/types": "46.12.5",
4545
"@material-ui/core": "^4.11.0",
4646
"@material-ui/pickers": "^3.2.10",
4747
"@react-native-community/slider": "4.2.3",

packages/core/src/components/DatePicker/DatePicker.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -315,6 +315,7 @@ const DatePicker: React.FC<React.PropsWithChildren<Props>> = ({
315315

316316
const leftIconStyle: ImageStyle = {
317317
position: "absolute",
318+
top: 0,
318319
marginTop:
319320
type === "solid"
320321
? leftIconMode === "inset"

packages/core/src/components/DeckSwiper/DeckSwiper.tsx

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import { StyleProp, ViewStyle, StyleSheet, View } from "react-native";
33
import DeckSwiperComponent from "react-native-deck-swiper";
44

55
export interface DeckSwiperProps<T> {
6+
onSwipe?: (index: number) => void;
67
onSwipedLeft?: (index: number) => void;
78
onSwipedRight?: (index: number) => void;
89
onSwipedUp?: (index: number) => void;
@@ -21,6 +22,7 @@ export interface DeckSwiperProps<T> {
2122
}
2223

2324
const DeckSwiper = <T extends object>({
25+
onSwipe,
2426
onSwipedLeft,
2527
onSwipedRight,
2628
onSwipedUp,
@@ -121,10 +123,22 @@ const DeckSwiper = <T extends object>({
121123
backgroundColor="transparent"
122124
cardVerticalMargin={0}
123125
cardHorizontalMargin={0}
124-
onSwipedLeft={onSwipedLeft}
125-
onSwipedRight={onSwipedRight}
126-
onSwipedTop={onSwipedUp}
127-
onSwipedBottom={onSwipedDown}
126+
onSwipedLeft={(index) => {
127+
onSwipedLeft?.(index);
128+
onSwipe?.(index);
129+
}}
130+
onSwipedRight={(index) => {
131+
onSwipedRight?.(index);
132+
onSwipe?.(index);
133+
}}
134+
onSwipedTop={(index) => {
135+
onSwipedUp?.(index);
136+
onSwipe?.(index);
137+
}}
138+
onSwipedBottom={(index) => {
139+
onSwipedDown?.(index);
140+
onSwipe?.(index);
141+
}}
128142
/>
129143
</View>
130144
);

packages/core/src/components/Swiper/Swiper.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import { View, StyleProp, ViewStyle } from "react-native";
33
import SwiperComponent from "react-native-web-swiper";
44

55
export interface SwiperProps<T> {
6+
onSwipe?: (index: number) => void;
67
onSwipedNext?: (index: number) => void;
78
onSwipedPrevious?: (index: number) => void;
89
vertical?: boolean;
@@ -41,6 +42,7 @@ const Swiper = ({
4142
renderItem,
4243
children,
4344
onIndexChanged: onIndexChangedProp,
45+
onSwipe,
4446
onSwipedNext,
4547
onSwipedPrevious,
4648
style,
@@ -66,6 +68,7 @@ const Swiper = ({
6668
} else if (current < previous) {
6769
onSwipedPrevious?.(previous);
6870
}
71+
onSwipe?.(previous);
6972
};
7073

7174
return (

packages/maps/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@draftbit/maps",
3-
"version": "46.12.4",
3+
"version": "46.12.5",
44
"description": "Map Components",
55
"main": "lib/commonjs/index.js",
66
"module": "lib/module/index.js",
@@ -39,8 +39,8 @@
3939
},
4040
"homepage": "https://github.com/draftbit/react-native-jigsaw#readme",
4141
"dependencies": {
42-
"@draftbit/types": "46.12.4",
43-
"@draftbit/web-maps": "46.12.4",
42+
"@draftbit/types": "46.12.5",
43+
"@draftbit/web-maps": "46.12.5",
4444
"react-native-maps": "0.31.1"
4545
},
4646
"react-native-builder-bob": {

packages/native/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@draftbit/native",
3-
"version": "46.12.4",
3+
"version": "46.12.5",
44
"description": "Draftbit UI Components that Depend on Native Components",
55
"main": "lib/commonjs/index.js",
66
"module": "lib/module/index.js",
@@ -39,7 +39,7 @@
3939
},
4040
"homepage": "https://github.com/draftbit/react-native-jigsaw#readme",
4141
"dependencies": {
42-
"@draftbit/types": "46.12.4",
42+
"@draftbit/types": "46.12.5",
4343
"@expo/vector-icons": "^13.0.0",
4444
"@react-native-community/datetimepicker": "6.2.0",
4545
"@react-native-community/slider": "4.2.3",

0 commit comments

Comments
 (0)