Fix bottom sheet (#865)

* Use lower version of bottom sheet

* Even lower version

* yarn.lcok

* Remove `disableImportExportTransform` from babel

* Revert "Remove `disableImportExportTransform` from babel"

This reverts commit 71e26d0.

* Downgrade rn-webview

* pollyfill RNCWebView

* react-native-webview as peer dependancy

* Remove from peer dependcies

* Revert "Remove from peer dependcies"

This reverts commit 034a367.

* Only keep as peer dependancy

* Have as dev dependancy but remove before publish

* Update typos

* config git in ci

* Add comments

* Add more comments

* Add as peer depenendncy for core

* Make react-native-youtube-iframe a peer dependancy

* Fix script

* Remove ts-ignores

* Remove polyfill

Author: YoussefHenna

.github/workflows/ci.yml

@@ -37,6 +37,16 @@ jobs:
       - name: Test
         run: yarn test
 
+      # snackager fails whenever react-native-webview is a dependency, so we remove it
+      # Removed right before deploy to keep it during development and when running tests, but ommited in final release
+      # Changes need to be committed, otherwise lerna refuses to publish
+      - name: Remove `react-native-webview` from dev dependencies
+        run: |
+          node ./scripts/remove-rn-webview-dependency.js
+          git config --global user.email "[email protected]"
+          git config --global user.name "Jigsaw CI Deploys"
+          git commit -a -m 'Remove react-native-webview dev dependency'
+
       - name: Release next packages
         if: github.event_name == 'pull_request'
         env:

packages/core/package.json

@@ -72,11 +72,11 @@
     "react-native-tab-view": "^3.4.0",
     "react-native-typography": "^1.4.1",
     "react-native-web-swiper": "^2.2.3",
-    "react-native-youtube-iframe": "^2.2.2",
     "react-youtube": "^10.1.0"
   },
   "peerDependencies": {
-    "react-native-avoid-softinput": "^4.0.1"
+    "react-native-avoid-softinput": "^4.0.1",
+    "react-native-youtube-iframe": "^2.2.2"
   },
   "peerDependenciesMeta": {
     "react-native-avoid-softinput": {
@@ -91,7 +91,8 @@
     "@types/lodash.isnumber": "^3.0.6",
     "@types/lodash.omit": "^4.5.6",
     "@types/lodash.tonumber": "^4.0.6",
-    "react-native-avoid-softinput": "^4.0.1"
+    "react-native-avoid-softinput": "^4.0.1",
+    "react-native-youtube-iframe": "^2.2.2"
   },
   "eslintIgnore": [
     "node_modules/",

packages/maps/package.json

@@ -44,8 +44,7 @@
     "@teovilla/react-native-web-maps": "^0.9.4",
     "color": "^4.2.3",
     "lodash.isequal": "^4.5.0",
-    "react-native-maps": "1.7.1",
-    "react-native-webview": "13.6.3"
+    "react-native-maps": "1.7.1"
   },
   "eslintIgnore": [
     "node_modules/",

packages/native/package.json

@@ -45,8 +45,13 @@
     "@react-native-community/slider": "4.4.2",
     "expo-camera": "~13.4.4",
     "expo-linear-gradient": "~12.3.0",
-    "react-native-svg": "13.10.0",
-    "react-native-webview": "13.6.3"
+    "react-native-svg": "13.10.0"
+  },
+  "peerDependencies": {
+    "react-native-webview": "13.2.2"
+  },
+  "devDependencies": {
+    "react-native-webview": "13.2.2"
   },
   "eslintIgnore": [
     "node_modules/",

scripts/remove-rn-webview-dependency.js

@@ -0,0 +1,43 @@
+/**
+ * snackager fails whenever react-native-webview is a dependency, so we remove it
+ * Fails with: Error: /tmp/snackager/snackager/buildStatus/1/@[email protected],android,web/package/node_modules/react-native-webview/lib/RNCWebViewNativeComponent.js: Could not find component config for native component
+ *
+ * This package is still needed during development and when running tests, so we run this script on ci right before it's released
+ *
+ * To be removed if this snackager call can succeed without it
+ * https://snackager.expo.io/bundle/@draftbit/core@VERSION_HERE?version_snackager=true&platforms=ios,android,web&bypassCache=true&sdkVersion=49.0.0
+ */
+
+const fs = require("fs");
+const path = require("path");
+
+const ROOT_PATH = path.join(__dirname, "..");
+const nativePackageJsonPath = path.join(
+  ROOT_PATH,
+  "packages",
+  "native",
+  "package.json"
+);
+
+const nativePackageJsonContents = fs
+  .readFileSync(nativePackageJsonPath)
+  .toString();
+const nativePackageJson = JSON.parse(nativePackageJsonContents);
+
+delete nativePackageJson.devDependencies["react-native-webview"];
+
+fs.writeFileSync(nativePackageJsonPath, JSON.stringify(nativePackageJson));
+
+const corePackageJsonPath = path.join(
+  ROOT_PATH,
+  "packages",
+  "core",
+  "package.json"
+);
+
+const corePackageJsonContents = fs.readFileSync(corePackageJsonPath).toString();
+const corePackageJson = JSON.parse(corePackageJsonContents);
+
+delete corePackageJson.devDependencies["react-native-youtube-iframe"];
+
+fs.writeFileSync(corePackageJsonPath, JSON.stringify(corePackageJson));

yarn.lock

@@ -12923,10 +12923,10 @@ react-native-web@~0.19.6:
     postcss-value-parser "^4.2.0"
     styleq "^0.1.3"
 
-react-native-webview@13.6.3:
-  version "13.6.3"
-  resolved "https://registry.yarnpkg.com/react-native-webview/-/react-native-webview-13.6.3.tgz#f3d26e942ef5cc5a07547f2e47903aa81a68e25e"
-  integrity sha512-IApO0JSj0uAWsBGKWagyfgDYoX29piiMYLmkHtRjKeL1rIVjLoR/bMe7KJ/0X47y86b//a6u3cYQtphyay+F2A==
+react-native-webview@13.2.2:
+  version "13.2.2"
+  resolved "https://registry.yarnpkg.com/react-native-webview/-/react-native-webview-13.2.2.tgz#06b04db8e1f4ed57a9dc92f4094aa0e41271b89b"
+  integrity sha512-uT70y2GUqQzaj2RwRb/QuKRdXeDjXM6oN3DdPqYQlOOMFTCT8r62fybyjVVRoik8io+KLa5KnmuSoS5B2O1BmA==
   dependencies:
     escape-string-regexp "2.0.0"
     invariant "2.2.4"