Map and SwipeableView Fixes/Updates (v47.2.3) (#641)

* Fixed Picker crash on IOS

* v46.7.8

* Added keyboard auto dismiss to Picker and DatePicker (#585)

* Added keyboard auto dismiss to Picker and DatePicker

* Minor change to trigger rebuild

* Minor change to trigger rebuild

* Fixed Picker double click to open issue on web (#586)

* Fixed broken web version of example app

* Updated Picker to properly show web picker

---------

Co-authored-by: Brian Luerssen <[email protected]>

* Fix border colors of datepicker (#587)

Co-authored-by: Brian Luerssen <[email protected]>

* Fixed number input defaultValue not being used + allowed to be empty to show placeholder (#588)

Co-authored-by: Brian Luerssen <[email protected]>

* Added Deck Swiper component + example in example app (#581)

* Added deck swiper component
Changes from #580
Copying changes manually - easier than rebasing

* Small change to comment to trigger rebuild

* Added export for DeckSwiper in ui package

* Moved ui package export above deprecated comment

* Minor edit to comment

* Fixed issue where border radius of theme is undefined

* Removed default border radius from theme

* Added layout to mapping

---------

Co-authored-by: Brian Luerssen <[email protected]>

* v46.8.0 (#593)

* Added Table components

* Added example + minor fixes to Table

* Added borderStyle prop

* Added mappings

* Added padding props to mapping

* Added BottomSheet with example

* Some fixes + packaged in library source code to fix its bugs

* Added mapping

* Updated ScreenContainer to use style background in SafeAreaView (#601)

* Added support for renderItem in DeckSwiper (#599)

* Added support for renderItem in DeckSwiper

* Fixed undefined key error when swiper is empty

---------

Co-authored-by: Brian Luerssen <[email protected]>

* Missing Stylespanel Sections (#584)

* Add StylesPanelSections to Swiper

* Add StylesPanelSections to mappings without them

* Update Stylesheets

* Updated Picker to treat empty string as a non value (#594)

+ removed placeholder as selectable value

Co-authored-by: Brian Luerssen <[email protected]>

* v46.8.1

* Updated allowed FlashList styles (#602)

Co-authored-by: Brian Luerssen <[email protected]>

* Added Markdown component (#597)

* Added Markdown component

* Updated mapping

* Updated component type

* Updated default value

---------

Co-authored-by: Brian Luerssen <[email protected]>

* Add TabView Component (#595)

* Added TabView (#368)
With some changes

* Added example and exports + minor fixes

* Downgraded pager version
Newer version fails to switch page with ref method

* Final minor updated to TabView

* Added mappings

* Updated group of accessibility label

* Updateed prop groups

* Updated default value of scroll enabled

* Added default title to tabs

* Updated intepretion of styling props of tabview

* Updated prop mapping to be more clear

* Made icon smaller

* Update tab view item type checking + does not render when no items

* Updated styles

* Revert "Updated styles"

This reverts commit 97d993e.

* Removed default style of tabview

---------

Co-authored-by: Brian Luerssen <[email protected]>

* Add shadow component (for v46) (#583)

* Added Shadow component

* Made props optional

* Added children + example

* Fixed example name

* Typo in mapping

* Fixed typo in tag in mappings

* Updated style to be passed as containerStyle

* Made paintInside false by default

* Made stretch false by default

* Undo default stretch prop

* Updated mapping to include advanced props

---------

Co-authored-by: Brian Luerssen <[email protected]>

* v46.9.0 (#603)

* Added gesture handler package to core

* Remove gesture handler from example

* Added reanimated package to core

* Updated reanimated version

* Fixed scrolling inside sheet

* Update decription on prop

* Simple change to trigger rebuild

* Remove static array prop function

* Updated reanimated a gesture handler to expo recomended versions

* Removed default layout of bottom sheet

* Only load maps script when not loaded

* Refactored how props shared with children (using Context)

* Added a way to include rows using 'renderItem' prop

* Added header and scrolling capability

* Removes unnecessary stylespanel sections

* Updated table mappings

* Updated default cell padding

* Only take first header row even when several provided

* Refactored header detection to find nested header within renderItem

* Passed rest props to inner scroll view

* Added show scroll indicator to mapping

* Fix to nested children not being an array

* Add YoutubePlayer Component (#596)

* Added Youtube component
As done in #367

* Added mapping

* Removed default playlist (overrides video)

* Removed default videoId

* Only show default video when both playlist and video not provided

* v46.10.0

* Update Lerna Method To Be Exact (#608)

* Use Exact Versions

* v46.10.1

* Fixed first item in picker not selectable (#605)

Co-authored-by: Brian Luerssen <[email protected]>

* Added mapping for native base layout components

* Removed Row components (superseded by NativeBase)

* Removed Row exports

* Updated mapping descriptions

* Squashed commit of the following:

commit 0aef0ce
Author: Youssef Henna <[email protected]>
Date:   Sun Feb 26 14:51:22 2023 +0200

    Revert "Removed web-webview from example"

    This reverts commit 38378ae.

commit 38378ae
Author: Youssef Henna <[email protected]>
Date:   Sun Feb 26 14:32:19 2023 +0200

    Removed web-webview from example

commit d2c0456
Author: Youssef Henna <[email protected]>
Date:   Sun Feb 26 13:37:07 2023 +0200

    Removed web-webview from being a core dependency

commit 0933344
Author: Youssef Henna <[email protected]>
Date:   Sun Feb 26 13:29:22 2023 +0200

    Removed webpack (no effect)

commit 05f8994
Author: Youssef Henna <[email protected]>
Date:   Sun Feb 26 13:19:14 2023 +0200

    Added webpack config to eslint ignore

commit f92a40f
Author: Youssef Henna <[email protected]>
Date:   Sun Feb 26 13:15:21 2023 +0200

    Removed .eslintrc

commit 5cf5fa9
Author: Youssef Henna <[email protected]>
Date:   Sun Feb 26 13:00:40 2023 +0200

    Added webpack config for 3rd party libraries

* Revert "Squashed commit of the following:"

This reverts commit c032c85.

* Replaced YoutubePlayer web impl to use
https://www.npmjs.com/package/react-youtube

* Refactored file structure to properly picked up by native and web + removed mute prop

* Updated aspect ratio prop to be numerical

* Updated mapping styles

* v46.10.2

* Updated container props

* Removed old Container mapping

* Removed container example

* Updated mapping for spacer

* Removed direction and row of stack. Use style directly instead

* Remove Container component

* Remove Container component

* Remove Container ui index

* Updated mapping of Aspect ration to only include supported styles

* Reworked how Maps script is loaded

* Added comment

* Removed comment

* Revert "Removed comment"

This reverts commit da0d785.

* Change in core to attempt corrupt build fix

* Change table file to attempt corrupt build fix

* Revert "Change table file to attempt corrupt build fix"

This reverts commit be4cf4b.

* Revert "Change in core to attempt corrupt build fix"

This reverts commit f1bb428.

* Remove comment

* Remove deprecated FAB

* Remove deprecated Card Wrapper

* Remove ProgressIndicator

* Delete Card mappings

* Refactored Table to reduce files

* Removed theme from Table

* Changed Table export to not be default

* Revert "Changed Table export to not be default"

This reverts commit 48afc09.

* Revert "Removed theme from Table"

This reverts commit ff93c5b.

* Revert "Refactored Table to reduce files"

This reverts commit 714d9a3.

* Move Nativebase mappings out of folder

* Revert "Move Nativebase mappings out of folder"

This reverts commit 52c9e48.

* Remove header mappings

* Move mappings outside core

* Revert "Move mappings outside core"

This reverts commit a05942d.

* lerna prepare concurrency 1

* Revert "lerna prepare concurrency 1"

This reverts commit 31b4cd5.

* Run ci on mac

* Revert "Remove ProgressIndicator"

This reverts commit d01bb61.

* Revert "Delete Card mappings"

This reverts commit bdd69c1.

* Revert "Remove header mappings"

This reverts commit 1ce355a.

* Revert "Remove deprecated FAB"

This reverts commit 35f9ee7.

* Revert "Remove deprecated Card Wrapper"

This reverts commit 5b5de36.

* Add comment to map script loader

* Revert to ubuntu in ci

* Updated bob builder version

* Updated core bob configuration

* core readd configuration options

* Remove bulder depenendcy from core

* Reconfigured bob the builder using automatic configuration

* Include source mappings in core

* Only include source mappings in module

* Replace \\ with /

* Removed source mapping config entirley from core

* Remove comment from MapScriptLoader

* Revert "Removed Row components (superseded by NativeBase)"

This reverts commit 7bd428f.

* Revert "Removed Row exports"

This reverts commit b68f423.

* Revert "Removed old Container mapping"

This reverts commit 7ea0f84.

* Revert "Removed container example"

This reverts commit 604d008.

* Revert "Remove Container component"

This reverts commit cf575f1.

* Revert "Remove Container component"

This reverts commit 23a66b3.

* Revert "Remove Container ui index"

This reverts commit d2fd894.

* Remove Container from Nativebase

* Deprecated old components replaced by Nativebase

* v46.11.0

* Only use default elevation when undefined (not zero)

* Added testing categrory to nativebase and table

* Added onRegionChange trigger to maps

* Added image as marker support for maps

* Updated mapping to include image prop

* Added ref to webview

* Added utility function for extracting styles

* Added SwipeableView components

* Updated how styling is applied

* Added simple example

* Added bunch of props and fixed swip handling

* Reordering of swipeable view

* Reset to default swipe on open percent

* Added mappings + removed some props

* updated tag

* Changed default TabView inactive to be darker shade of gray

* Remove default placeholder at component level

* Removed onValueChange from useEffect depenencies incase of anonymous function

* Ignore useEffect dependencies

* Updated how first value set to prevent useEffect issues

* v46.11.1

* Updated default paintInside + updated how styles are handled

* Fixed DeckSwiper sizing issue when aligned to center

* Possible fix double height issue with deck swiper

* Trigger rebuild

* Revert "Possible fix double height issue with deck swiper"

This reverts commit a6fbe8e.

* Fix double height issue with deck swiper on draftbit

* Trigger rebuild

* Added missing style panel sections to deckswiper

* Updated Shadow styles to support sizing

* Updated styles of DeckSwiper to what actually works

* Updated missed mapping

* Remove nativebase and undeprecate old layout components

* v46.11.2 (#630)

* Added onRegion change trigger to map view mapping

* Updated mapping for trigger

* Updated pin image prop type

* Updated proper usage of pin image and added pinImageSize prop

* Added onPress trigger to map marker

* v46.11.3

* Updated how image source is handled for maps pin

* v46.11.4

* Added patch to address x offset not working on IOS

* Updated bottom sheet props to be less technically involved

* Add numeric form type to snap positions

* Updated defauly snap values

* Update custom snap points prop mapping

* v46.11.5

* Revert "v46.11.5"

This reverts commit 7097c1a.

* Updated example name + made mapping category testing

* Updated shared props variable name

* Moved button and swipe handlers to testing category

* v46.12.0

* Fix `FlatList` not working because of the forced `flex` style attribute

Some testing in Snack showed that the `FlatList` component was not
properly working, the main reason being that the `flex` style attribute
was forced to `1` in the `FlatList` component.  For whatever reason,
when this settings is set, either the Webpreview fail to render the
FLatlist, or the Appetize preview do.

* Updated default disable of swipeable view

* Update maps callback args to provide more inforamtion

* Removed nullable on onPress and onSwipe
Will only be rendered under SwipeableView when onPress/onSwipe provided

* Fixed issue with size styles application for web on swipeable view

* v46.12.1

* Remove duplicate in package.json

* v47.2.3

* Removed state from MapView

* Addressed PR comments

---------

Co-authored-by: Brian Luerssen <[email protected]>
Co-authored-by: Brian Luerssen <[email protected]>
Co-authored-by: Timothée Vialatoux <[email protected]>

Author: 3 people

.github/workflows/ci.yml

@@ -74,6 +74,20 @@ jobs:
             --yes \
             --no-verify-access
 
+      - name: Release packages (46)
+        if: github.event_name != 'pull_request' && github.ref == 'refs/heads/46'
+        env:
+          NODE_AUTH_TOKEN: ${{ secrets.JIGSAW_AUTH_TOKEN }}
+        run: |
+          # Only publishes when finding a new `lerna version` was pushed to
+          # the branch. But for purposes of _this_ action, that means master.
+          # You have to manually run lerna version locally and get that PR
+          # merged before this does anything.
+          yarn lerna publish from-package \
+            --ignore-scripts \
+            --yes \
+            --no-verify-access
+
       - name: Release to Snack (PRs)
         if: github.event_name == 'pull_request'
         run: |

example/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@draftbit/example",
   "description": "Example app for @draftbit/ui",
-  "version": "47.2.2",
+  "version": "47.2.3",
   "private": true,
   "main": "__generated__/AppEntry.js",
   "scripts": {
@@ -15,8 +15,8 @@
     "clean:modules": "rimraf node_modules"
   },
   "dependencies": {
-    "@draftbit/maps": "47.2.2",
-    "@draftbit/ui": "47.2.2",
+    "@draftbit/maps": "47.2.3",
+    "@draftbit/ui": "47.2.3",
     "@expo/dev-server": "0.1.123",
     "@expo/webpack-config": "^0.17.2",
     "@react-navigation/drawer": "^5.12.9",

example/src/SwipeableViewExample.tsx

@@ -15,19 +15,19 @@ const SwipeableViewExample: React.FC = () => {
           <Text>Some Content</Text>
 
           <SwipeableViewButton
-            onPress={null}
+            onPress={() => {}}
             side="left"
             title="Button"
             icon="add"
           />
           <SwipeableViewButton
-            onPress={null}
+            onPress={() => {}}
             side="left"
             title="Button"
             icon="add"
           />
           <SwipeableViewSwipeHandler
-            onSwipe={null}
+            onSwipe={() => {}}
             side="right"
             title="Swipe"
             icon="add"

lerna.json

@@ -1,5 +1,5 @@
 {
-  "version": "47.2.2",
+  "version": "47.2.3",
   "npmClient": "yarn",
   "useWorkspaces": true,
   "packages": ["packages/*", "example"],

packages/core/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@draftbit/core",
-  "version": "47.2.2",
+  "version": "47.2.3",
   "description": "Core (non-native) Components",
   "main": "lib/commonjs/index.js",
   "module": "lib/module/index.js",
@@ -41,7 +41,7 @@
   "dependencies": {
     "@date-io/date-fns": "^1.3.13",
     "@draftbit/react-theme-provider": "^2.1.1",
-    "@draftbit/types": "47.2.2",
+    "@draftbit/types": "47.2.3",
     "@material-ui/core": "^4.11.0",
     "@material-ui/pickers": "^3.2.10",
     "@react-native-community/slider": "4.2.4",

packages/core/src/components/SwipeableView/SwipeableView.tsx

@@ -77,18 +77,23 @@ const SwipeableView: React.FC<React.PropsWithChildren<SwipeableViewProps>> = ({
   const { borderStyles, marginStyles } =
     extractBorderAndMarginStyles(viewStyles);
 
+  const sizeStyles = extractSizeStyles(viewStyles);
+
   const parentContainerStyles = StyleSheet.flatten([
     borderStyles,
     marginStyles,
     extractFlexItemStyles(viewStyles),
     extractPositionStyles(viewStyles),
     extractEffectStyles(viewStyles),
-    extractSizeStyles(viewStyles),
+    sizeStyles,
   ]);
 
   //Remove styles already consumed from viewStyles
   Object.keys(parentContainerStyles).forEach((key) => delete viewStyles[key]);
-  const surfaceContainerStyles = viewStyles;
+  const surfaceContainerStyles = StyleSheet.flatten([
+    viewStyles,
+    sizeStyles /* Size styles needs to be readded to surface container due to inconsistencies on web */,
+  ]);
 
   const [componentWidth, setComponentWidth] = React.useState<number | null>(
     null
@@ -289,7 +294,7 @@ const styles = StyleSheet.create({
   surfaceContainer: {
     flexDirection: "row",
     width: "100%",
-    height: "100%",
+    minHeight: 50,
     padding: 10,
     alignItems: "center",
     overflow: "hidden",

packages/core/src/components/SwipeableView/SwipeableViewButton.tsx

@@ -3,7 +3,7 @@ import React from "react";
 export interface SwipeableViewButtonProps {
   title: string;
   side: "left" | "right";
-  onPress: (() => void) | null; //Not optional in order to always exist in props
+  onPress?: () => void;
   icon?: string;
   iconSize?: number;
   backgroundColor?: string;

packages/core/src/components/SwipeableView/SwipeableViewSwipeHandler.tsx

@@ -3,7 +3,7 @@ import React from "react";
 export interface SwipeableViewSwipeHandlerProps {
   title: string;
   side: "left" | "right";
-  onSwipe: (() => void) | null; //Not optional in order to always exist in props
+  onSwipe?: () => void;
   icon?: string;
   iconSize?: number;
   backgroundColor?: string;

packages/core/src/mappings/SwipeableView.ts

@@ -86,12 +86,12 @@ export const SEED_DATA = [
       disableLeftSwipe: createBoolProp({
         label: "Disable left swipe",
         description: "Whether left swipe is enabled or not",
-        defaultValue: true,
+        defaultValue: false,
       }),
       disableRightSwipe: createBoolProp({
         label: "Disable right swipe",
         description: "Whether right swipe is enabled or not",
-        defaultValue: true,
+        defaultValue: false,
       }),
       leftOpenValue: createStaticNumberProp({
         label: "Left open value",

packages/core/src/utilities.ts

@@ -169,7 +169,7 @@ export function extractEffectStyles(
   return effectStyles;
 }
 
-export const sizeStyleNames = ["width", "height"];
+export const sizeStyleNames = ["width", "height", "minWidth", "minHeight"];
 
 export function extractSizeStyles(
   style: StyleProp<any>,