search: Return a default_score with ft.info index definition (#5941)

* search: Add default_score with hardcoded value to ft.info

Some clients expect this field to be present. Default score is not a
part of data structures within the search family, but returning a value
of 1 is a sensible default.

* search: Add index_options field to FT.Info

Signed-off-by: Abhijat Malviya <[email protected]>

Author: abhijat

src/server/search/search_family.cc

@@ -1203,20 +1203,25 @@ void SearchFamily::FtInfo(CmdArgList args, const CommandContext& cmd_cntx) {
   const auto& info = infos.front();
   const auto& schema = info.base_index.schema;
 
-  rb->StartCollection(4, RedisReplyBuilder::MAP);
+  rb->StartCollection(5, RedisReplyBuilder::MAP);
 
   rb->SendSimpleString("index_name");
   rb->SendSimpleString(idx_name);
 
   rb->SendSimpleString("index_definition");
   {
-    rb->StartCollection(2, RedisReplyBuilder::MAP);
+    rb->StartCollection(3, RedisReplyBuilder::MAP);
     rb->SendSimpleString("key_type");
     rb->SendSimpleString(info.base_index.type == DocIndex::JSON ? "JSON" : "HASH");
     rb->SendSimpleString("prefix");
     rb->SendSimpleString(info.base_index.prefix);
+    rb->SendSimpleString("default_score");
+    rb->SendLong(1);
   }
 
+  rb->SendSimpleString("index_options");
+  rb->SendEmptyArray();
+
   rb->SendSimpleString("attributes");
   rb->StartArray(schema.fields.size());
   for (const auto& [field_ident, field_info] : schema.fields) {

src/server/search/search_family_test.cc

@@ -291,7 +291,8 @@ TEST_F(SearchFamilyTest, InfoIndex) {
 
   auto info = Run({"ft.info", "idx-1"});
   EXPECT_THAT(info,
-              IsArray(_, _, _, IsArray("key_type", "HASH", "prefix", "doc-"), "attributes",
+              IsArray(_, _, _, IsArray("key_type", "HASH", "prefix", "doc-", "default_score", 1),
+                      "index_options", RespArray(IsEmpty()), "attributes",
                       IsArray(IsArray("identifier", "name", "attribute", "name", "type", "TEXT")),
                       "num_docs", IntArg(15)));
 }
@@ -2773,7 +2774,7 @@ TEST_F(SearchFamilyTest, BlockSizeOptionFtCreate) {
 
   // Verify that the index was created successfully
   resp = Run({"FT.INFO", "index"});
-  EXPECT_THAT(resp, IsArray(_, _, _, _, "attributes",
+  EXPECT_THAT(resp, IsArray(_, _, _, _, _, _, "attributes",
                             IsUnordArray(IsArray("identifier", "number1", "attribute", "number1",
                                                  "type", "NUMERIC", "blocksize", "2"),
                                          IsArray("identifier", "number2", "attribute", "number2",

tests/dragonfly/search_test.py

@@ -3,17 +3,15 @@
 Search correctness should be ensured with unit tests.
 """
 
-import pytest
-from redis import asyncio as aioredis
-from .utility import *
-from . import dfly_args
 import copy
 
 import numpy as np
-
-from redis.commands.search.query import Query
 from redis.commands.search.field import TextField, NumericField, TagField, VectorField
 from redis.commands.search.indexDefinition import IndexDefinition, IndexType
+from redis.commands.search.query import Query
+
+from . import dfly_args
+from .utility import *
 
 TEST_DATA = [
     {
@@ -130,15 +128,15 @@ async def test_management(async_client: aioredis.Redis):
     assert sorted(await async_client.execute_command("FT._LIST")) == ["i1", "i2"]
 
     i1info = await i1.info()
-    assert i1info["index_definition"] == ["key_type", "HASH", "prefix", "p1"]
+    assert i1info["index_definition"] == ["key_type", "HASH", "prefix", "p1", "default_score", 1]
     assert i1info["num_docs"] == 10
     assert sorted(i1info["attributes"]) == [
         ["identifier", "f1", "attribute", "f1", "type", "TEXT"],
         ["identifier", "f2", "attribute", "f2", "type", "NUMERIC", "SORTABLE", "blocksize", "7000"],
     ]
 
     i2info = await i2.info()
-    assert i2info["index_definition"] == ["key_type", "HASH", "prefix", "p2"]
+    assert i2info["index_definition"] == ["key_type", "HASH", "prefix", "p2", "default_score", 1]
     assert i2info["num_docs"] == 15
     assert sorted(i2info["attributes"]) == [
         [