refactor: drop extra code

Author: BorysTheDev

src/core/search/hnsw_index.cc

@@ -264,27 +264,7 @@ struct HnswlibAdapter {
       size_t internal_id = node.internal_id;
 
       // Validate internal_id is within bounds - invalid internal_id indicates corrupted data
-      if (internal_id >= world_.max_elements_) {
-        LOG(ERROR) << "RestoreFromNodes: internal_id " << internal_id << " exceeds max_elements "
-                   << world_.max_elements_ << ", aborting restoration (corrupted snapshot data)";
-        // Clean up all state modified for previously processed nodes
-        for (size_t id : restored_internal_ids) {
-          // Free allocated linkLists_ to prevent memory leak
-          if (world_.linkLists_[id]) {
-            mi_free(world_.linkLists_[id]);
-            world_.linkLists_[id] = nullptr;
-          }
-          // Reset element_levels_ entry
-          world_.element_levels_[id] = 0;
-          // Clear level 0 memory that was modified
-          memset(world_.data_level0_memory_ + id * world_.size_data_per_element_, 0,
-                 world_.size_data_per_element_);
-        }
-        // Reset global state
-        world_.cur_element_count.store(0);
-        world_.label_lookup_.clear();
-        return;
-      }
+      CHECK(internal_id < world_.max_elements_);
 
       // Register label in lookup table
       world_.label_lookup_[node.global_id] = internal_id;

src/server/rdb_load.cc

@@ -2311,9 +2311,10 @@ error_code RdbLoader::Load(io::Source* src) {
 
         LOG(INFO) << "Restored HNSW index " << index_key << " with " << nodes.size() << " nodes";
       } else if (elements_number > 0) {
-        VLOG(2) << "Skipping HNSW vector index restore: " << index_key
-                << " elements_number=" << elements_number << " shard_count_=" << shard_count_
-                << " current_shards=" << (shard_set ? shard_set->size() : 0);
+        LOG(INFO) << "Skipping HNSW vector index restore: " << index_key
+                  << " elements_number=" << elements_number << " shard_count_=" << shard_count_
+                  << " current_shards=" << (shard_set ? shard_set->size() : 0)
+                  << ". Index will be rebuilt from data.";
       }
       continue;
     }

src/server/search/doc_index.cc

@@ -483,9 +483,13 @@ void ShardDocIndex::RebuildGlobalVectorIndices(std::string_view index_name, cons
 
   if (any_restored) {
     // Iterate by index keys - more efficient for restored indices
+    LOG(INFO) << "Restoring vector index '" << index_name << "' from serialized graph on shard "
+              << EngineShard::tlocal()->shard_id();
     RebuildGlobalVectorIndicesByIndexKeys(index_name, op_args);
   } else {
     // Iterate by database - needed when building new index
+    LOG(INFO) << "Rebuilding vector index '" << index_name << "' from database on shard "
+              << EngineShard::tlocal()->shard_id() << " (no serialized graph available)";
     RebuildGlobalVectorIndicesByDatabase(index_name, op_args);
   }
 }