Skip to content

Commit 99945be

Browse files
committed
fix: review comments
1 parent 913c6cd commit 99945be

File tree

3 files changed

+0
-4
lines changed

3 files changed

+0
-4
lines changed

src/server/hset_family.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1164,7 +1164,6 @@ void HSetFamily::HRandField(CmdArgList args, const CommandContext& cmd_cntx) {
11641164
}
11651165

11661166
if (string_map->Empty()) { // Can happen if we use a TTL on hash members.
1167-
// Use type-safe deletion (fixes #5316)
11681167
auto res_it = db_slice.FindMutable(db_context, key, OBJ_HASH);
11691168
if (res_it) {
11701169
res_it->post_updater.Run();

src/server/set_family.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -481,7 +481,6 @@ OpResult<uint32_t> OpAdd(const OpArgs& op_args, std::string_view key, const NewE
481481
// to overwrite the key. However, if the set is empty it means we should delete the
482482
// key if it exists.
483483
if (overwrite && (vals_it.begin() == vals_it.end())) {
484-
// Use type-safe deletion with OBJ_SET (fixes #5316)
485484
auto res_it = db_slice.FindMutable(op_args.db_cntx, key, OBJ_SET);
486485
if (res_it) {
487486
res_it->post_updater.Run();

src/server/string_family.cc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,6 @@ OpResult<int64_t> OpIncrBy(const OpArgs& op_args, string_view key, int64_t incr,
285285
auto& db_slice = op_args.GetDbSlice();
286286

287287
// we avoid using AddOrFind because of skip_on_missing option for memcache.
288-
// Use type-safe FindMutable with OBJ_STRING (fixes #5316)
289288
auto res = db_slice.FindMutable(op_args.db_cntx, key, OBJ_STRING);
290289

291290
if (!res) {
@@ -384,7 +383,6 @@ OpResult<array<int64_t, 5>> OpThrottle(const OpArgs& op_args, const string_view
384383
// Cost of this request
385384
const int64_t increment_ns = emission_interval_ns * quantity; // should be nonnegative
386385

387-
// Use type-safe FindMutable with OBJ_STRING (fixes #5316)
388386
auto res = db_slice.FindMutable(op_args.db_cntx, key, OBJ_STRING);
389387
const int64_t now_ns = GetCurrentTimeNs();
390388

0 commit comments

Comments
 (0)