chore: rewrite mimalloc2 external lib dependency (#5751)

Needed to be able to pass compile/define flags.
Specifically, pass MI_STAT=1 to enable mimalloc stats aggregation.

Signed-off-by: Roman Gershman <[email protected]>

Author: romange

src/external_libs.cmake

@@ -58,28 +58,63 @@ add_third_party(
   INSTALL_COMMAND ${DFLY_TOOLS_MAKE} install BUILD_SHARED=no PREFIX=${THIRD_PARTY_LIB_DIR}/lz4
 )
 
-set(MIMALLOC_INCLUDE_DIR ${THIRD_PARTY_LIB_DIR}/mimalloc2/include)
-
+set(MIMALLOC_ROOT_DIR ${THIRD_PARTY_LIB_DIR}/mimalloc2)
+set(MIMALLOC_INCLUDE_DIR ${MIMALLOC_ROOT_DIR}/include)
 set(MIMALLOC_PATCH_DIR ${CMAKE_CURRENT_LIST_DIR}/../patches/mimalloc-v2.2.4)
-
-add_third_party(mimalloc2
-   # GIT_REPOSITORY https://github.com/microsoft/mimalloc/
-   # GIT_TAG v2.2.4
-   URL https://github.com/microsoft/mimalloc/archive/refs/tags/v2.2.4.tar.gz
-   PATCH_COMMAND
-        patch -p1 -d ${THIRD_PARTY_DIR}/mimalloc2/ -i ${MIMALLOC_PATCH_DIR}/0_base.patch
-        COMMAND patch -p1 -d ${THIRD_PARTY_DIR}/mimalloc2/ -i ${MIMALLOC_PATCH_DIR}/1_add_stat_type.patch
-        COMMAND patch -p1 -d ${THIRD_PARTY_DIR}/mimalloc2/ -i ${MIMALLOC_PATCH_DIR}/2_return_stat.patch
-   # Add -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_FLAGS=-O0 to debug
-   CMAKE_PASS_FLAGS "-DCMAKE_BUILD_TYPE=Release -DMI_BUILD_SHARED=OFF -DMI_BUILD_TESTS=OFF \
-                    -DMI_INSTALL_TOPLEVEL=ON -DMI_OVERRIDE=OFF -DMI_NO_PADDING=ON \ -DCMAKE_C_FLAGS=-g"
-
+set(MIMALLOC_C_FLAGS "-O3 -g -DMI_STAT=1 -DNDEBUG")
+file(MAKE_DIRECTORY ${MIMALLOC_INCLUDE_DIR})
+
+ExternalProject_Add(mimalloc2_project
+  URL https://github.com/microsoft/mimalloc/archive/refs/tags/v2.2.4.tar.gz
+  DOWNLOAD_DIR ${THIRD_PARTY_DIR}/mimalloc2
+  SOURCE_DIR ${THIRD_PARTY_DIR}/mimalloc2
+  # INSTALL_DIR ${MIMALLOC_ROOT_DIR}
+  UPDATE_COMMAND ""
+
+  PATCH_COMMAND
+      patch -p1 -d ${THIRD_PARTY_DIR}/mimalloc2/ -i ${MIMALLOC_PATCH_DIR}/0_base.patch
+      COMMAND patch -p1 -d ${THIRD_PARTY_DIR}/mimalloc2/ -i ${MIMALLOC_PATCH_DIR}/1_add_stat_type.patch
+      COMMAND patch -p1 -d ${THIRD_PARTY_DIR}/mimalloc2/ -i ${MIMALLOC_PATCH_DIR}/2_return_stat.patch
   BUILD_COMMAND make mimalloc-static
+
   INSTALL_COMMAND make install
+  # Copy internal types like mi_page_usage_stats_s and mi_heap_s
   COMMAND cp -r <SOURCE_DIR>/include/mimalloc ${MIMALLOC_INCLUDE_DIR}/
-  LIB ${HELIO_MIMALLOC_LIBNAME}
+
+  LOG_INSTALL ON
+  LOG_DOWNLOAD ON
+  LOG_CONFIGURE ON
+  LOG_BUILD ON
+  LOG_PATCH ON
+  LOG_UPDATE ON
+  DOWNLOAD_EXTRACT_TIMESTAMP YES
+
+  CMAKE_GENERATOR "Unix Makefiles"
+
+  # Add -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_FLAGS=-O0 to debug, and set BUILD_BYPRODUCTS to
+  # libmimalloc-debug.a
+
+  BUILD_BYPRODUCTS ${MIMALLOC_ROOT_DIR}/lib/libmimalloc.a
+
+  CMAKE_ARGS -DCMAKE_ARCHIVE_OUTPUT_DIRECTORY:PATH=${MIMALLOC_ROOT_DIR}/lib
+        -DCMAKE_LIBRARY_OUTPUT_DIRECTORY:PATH=${MIMALLOC_ROOT_DIR}/lib
+        -DCMAKE_BUILD_TYPE:STRING=Release
+        -DCMAKE_CXX_COMPILER:STRING=${CMAKE_CXX_COMPILER}
+        -DMI_INSTALL_TOPLEVEL=ON
+        -DMI_OVERRIDE=OFF
+        -DMI_NO_PADDING=ON
+        -DMI_BUILD_TESTS=OFF
+        -DMI_BUILD_SHARED=OFF
+        -DMI_BUILD_OBJECT=OFF
+        -DCMAKE_C_FLAGS=${MIMALLOC_C_FLAGS}
+        -DCMAKE_INSTALL_PREFIX:PATH=${MIMALLOC_ROOT_DIR}
 )
 
+add_library(TRDP::mimalloc2 STATIC IMPORTED)
+add_dependencies(TRDP::mimalloc2 mimalloc2_project)
+set_target_properties(TRDP::mimalloc2 PROPERTIES IMPORTED_LOCATION ${MIMALLOC_ROOT_DIR}/lib/libmimalloc.a
+                      INTERFACE_INCLUDE_DIRECTORIES ${MIMALLOC_ROOT_DIR}/include)
+
 add_third_party(
   croncpp
   URL https://github.com/mariusbancila/croncpp/archive/refs/tags/v2023.03.30.tar.gz