Skip to content

Commit d3d222d

Browse files
authored
fix(pytest): Wait replica to be in sync in test_stream_approximate_trimming (#5430)
Before checking keys on both master and replica we need to be sure that all changes are replicated. Closes #5426 Signed-off-by: mkaruza <[email protected]>
1 parent 3c3078c commit d3d222d

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

tests/dragonfly/replication_test.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2861,7 +2861,7 @@ async def test_stream_approximate_trimming(df_factory):
28612861
await c_master.execute_command("XTRIM", stream_name, "MAXLEN", "~", trim_size)
28622862

28632863
# Wait for replica sync
2864-
await asyncio.sleep(1)
2864+
await check_all_replicas_finished([c_replica], c_master)
28652865

28662866
# Check replica data consistent
28672867
master_data = await DebugPopulateSeeder.capture(c_master)
@@ -2873,6 +2873,9 @@ async def test_stream_approximate_trimming(df_factory):
28732873
stream_name = f"stream{i}"
28742874
await c_master.execute_command("XTRIM", stream_name, "MAXLEN", "0")
28752875

2876+
# Wait for replica sync
2877+
await check_all_replicas_finished([c_replica], c_master)
2878+
28762879
# Check replica data consistent
28772880
master_data = await DebugPopulateSeeder.capture(c_master)
28782881
replica_data = await DebugPopulateSeeder.capture(c_replica)

0 commit comments

Comments
 (0)