fix: compute_memory_size() added #5
Open
+152
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As far as I could find, the is no way to compute the requested memory usage, neither the real memory usage (i.e. mi_good_size) as the library doesn't have control over this. What it does support is polymorphic allocators and we're already using them to get the total memory usage of all json objects. A simpler solution in terms of code, but with higher overhead, would be "copying" the json object with a custom memory resource and counting the memory usage from within. Should be just a few lines of code inside Dragonfly... Though we'll end up copying the object |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is to be used for dragonflydb/dragonfly#5480