Fix lint

Author: draincoder

pyproject.toml

@@ -90,6 +90,7 @@ lint.ignore = [
     "RET505",
     "ISC001",
     "UP035",
+    "COM812",
 ]
 
 [tool.ruff.lint.per-file-ignores]

src/asgi_monitor/integrations/litestar.py

@@ -33,7 +33,7 @@
 
 
 def _get_default_span_details(scope: Scope) -> tuple[str, dict[str, Any]]:
-    method, path = scope["method"], scope["path"]  # The WebSocket is not supported
+    method, path = scope["method"], scope["path"]  # type: ignore[typeddict-item]  # The WebSocket is not supported
     return f"{method} {path}", {SpanAttributes.HTTP_ROUTE: path}
 
 
@@ -74,7 +74,7 @@ def __init__(self, app: ASGIApp, config: TracingConfig) -> None:
         self.open_telemetry_middleware = build_open_telemetry_middleware(app, config)
 
     async def __call__(self, scope: Scope, receive: Receive, send: Send) -> None:
-        return await self.open_telemetry_middleware(scope, receive, send)  # type: ignore[no-any-return]
+        return await self.open_telemetry_middleware(scope, receive, send)  # type: ignore[arg-type]
 
 
 def _get_wrapped_send(send: Send, request_span: dict[str, float]) -> Callable:
@@ -146,7 +146,7 @@ async def __call__(self, scope: Scope, receive: Receive, send: Send) -> None:
             self.metrics.inc_responses_count(
                 method=method,
                 path=path,
-                status_code=request_span["status_code"],
+                status_code=request_span["status_code"],  # type: ignore[arg-type]
             )
             self.metrics.remove_request_in_progress(method=method, path=path)
 

src/asgi_monitor/integrations/starlette.py

@@ -115,7 +115,7 @@ async def __call__(
         if scope["type"] != "http":
             return await self.app(scope, receive, send)
 
-        return await self.open_telemetry_middleware(scope, receive, send)  # type: ignore[no-any-return]
+        return await self.open_telemetry_middleware(scope, receive, send)  # type: ignore[arg-type]
 
 
 class MetricsMiddleware(BaseHTTPMiddleware):

src/asgi_monitor/logging/configure.py

@@ -71,7 +71,7 @@ def _configure_default_logging(
 
     formatter = structlog.stdlib.ProcessorFormatter(
         foreign_pre_chain=default_processors,
-        processors=logging_processors,
+        processors=logging_processors,  # type: ignore[arg-type]
     )
 
     handler = logging.StreamHandler(stream=sys.stdout)

src/asgi_monitor/logging/trace_processor.py

@@ -18,7 +18,7 @@ def extract_opentelemetry_trace_meta(
             return event_dict
 
         ctx = span.get_span_context()
-        service_name = trace.get_tracer_provider().resource.attributes["service.name"]
+        service_name = trace.get_tracer_provider().resource.attributes["service.name"]  # type: ignore[attr-defined]
         parent = getattr(span, "parent", None)
 
         event_dict["span_id"] = trace.format_span_id(ctx.span_id)

src/asgi_monitor/logging/uvicorn/log_config.py

@@ -52,7 +52,7 @@ def __init__(self, *args: Any, **kwargs: Any) -> None:
         ]
 
         super().__init__(
-            processors=processors,
+            processors=processors,  # type: ignore[arg-type]
             foreign_pre_chain=_build_default_processors(json_format=False),
             pass_foreign_args=True,  # for args from record.args in positional_args
         )
@@ -68,7 +68,7 @@ def __init__(self, *args: Any, **kwargs: Any) -> None:
         ]
 
         super().__init__(
-            processors=processors,
+            processors=processors,  # type: ignore[arg-type]
             foreign_pre_chain=_build_default_processors(json_format=False),
             pass_foreign_args=True,  # for args from record.args in positional_args
         )
@@ -91,7 +91,7 @@ def __init__(self, *args: Any, **kwargs: Any) -> None:
         ]
 
         super().__init__(
-            processors=processors,
+            processors=processors,  # type: ignore[arg-type]
             foreign_pre_chain=_build_default_processors(json_format=True),
             pass_foreign_args=True,  # for args from record.args in positional_args
         )
@@ -107,7 +107,7 @@ def __init__(self, *args: Any, **kwargs: Any) -> None:
         ]
 
         super().__init__(
-            processors=processors,
+            processors=processors,  # type: ignore[arg-type]
             foreign_pre_chain=_build_default_processors(json_format=True),
             pass_foreign_args=True,  # for args from record.args in positional_args
         )
@@ -134,7 +134,7 @@ def build_uvicorn_log_config(
         default = UvicornDefaultJSONFormatter
         access = UvicornAccessJSONFormatter if not include_trace else TraceUvicornAccessJSONFormatter
     else:
-        default = UvicornDefaultConsoleFormatter
+        default = UvicornDefaultConsoleFormatter  # type: ignore[assignment]
         access = UvicornAccessConsoleFormatter if not include_trace else TraceUvicornAccessConsoleFormatter
 
     return {

tests/unit/metrics/test_metrics.py

@@ -116,16 +116,17 @@ def test_request_duration(container: MetricsContainer, manager: MetricsManager)
         "histogram",
         "",
     )
+    bucket_labels = {"app_name": "asgi-monitor", "method": "GET", "path": "/metrics", "le": IsStr}
     expected_sample_bucket_with_exemplar = Sample(
         name="test_request_duration_seconds_bucket",
-        labels={"app_name": "asgi-monitor", "method": "GET", "path": "/metrics", "le": IsStr},
+        labels=bucket_labels,  # type: ignore[arg-type]
         value=1.0,
         timestamp=None,
         exemplar=Exemplar(labels={"TraceID": "1234567"}, value=0.0, timestamp=FROZEN_TIMESTAMP),
     )
     expected_sample_bucket_without_exemplar = Sample(
         name="test_request_duration_seconds_bucket",
-        labels={"app_name": "asgi-monitor", "method": "GET", "path": "/metrics", "le": IsStr},
+        labels=bucket_labels,  # type: ignore[arg-type]
         value=1.0,
         timestamp=None,
         exemplar=None,
@@ -165,7 +166,7 @@ def test_request_duration(container: MetricsContainer, manager: MetricsManager)
 
     # Assert
     request_duration = container.request_duration().collect()
-    samples = request_duration[0].samples
+    samples = request_duration[0].samples  # type: ignore[index]
 
     assert_that(request_duration).extracting("name", "documentation", "type", "unit").is_equal_to([expected])
     assert_that(samples[0]).is_equal_to(expected_sample_bucket_with_exemplar)