sharedownload.html template

[brontosaurusrex]

Trying to add filename/filesize to the template found in
/usr/share/sftpgo/templates/webclient/sharedownload.html
but not sure how.

Currently the download page for a share is just "Your download is ready" + a blue download button.

Any ideas/examples would be appreciated.

[jrnewton]

Based on my quick review of the code, it seems the share data is not passed down to the template render function... @drakkan - would you be open to a PR to fix this?

func (s *httpdServer) renderShareDownloadPage(w http.ResponseWriter, r *http.Request, share *dataprovider.Share,
	downloadLink string,
) {
	data := shareDownloadPage{
		baseClientPage: s.getBaseClientPageData(util.I18nShareDownloadTitle, "", w, r),
		// include Share pointer here
		DownloadLink:   downloadLink,
	}
	data.LogoutURL = ""
	if share.Password != "" {
		data.LogoutURL = path.Join(webClientPubSharesPath, share.ShareID, "logout")
	}

	renderClientTemplate(w, templateShareDownload, data)
}

[drakkan]

The Share pointer does not contain information about the file size. It is usefil to provide other details that are already available in the Enterprise edition.

When sharing a directory that contains many subdirectories, determining the total size would require a recursive scan. Even then, the result would not necessarily match the actual download size, since files are downloaded in compressed form.

[jrnewton]

@drakkan - would you be willing to accept a PR that would show the name and description at least? They are configurable options on the share struct but not exposed to the UI.

Here's an example of what it might look like:

[drakkan]

If I recall correctly, we already have something similar in SFTPGo Enterprise. That said, feel free to send a PR and we’ll do our best to review and merge it.