[flang] Add return statement to Logical opeator=.

DavidTruby · memfrob · commit 76eacee5a21d · 2022-10-04T16:48:36.000-04:00
This removes the current undefined behavior where the function has a return type but no return statement. Fixes: https://bugs.llvm.org/show_bug.cgi?id=45530
diff --git a/flang/include/flang/Evaluate/logical.h b/flang/include/flang/Evaluate/logical.h
@@ -29,6 +29,7 @@ template <int BITS, bool IS_LIKE_C = true> class Logical {
 
   template <int B, bool C> constexpr Logical &operator=(Logical<B, C> x) {
     word_ = Represent(x.IsTrue());
+    return *this;
   }
 
   // Fortran actually has only .EQV. & .NEQV. relational operations

Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,7 @@ template <int BITS, bool IS_LIKE_C = true> class Logical {`
`29`	`29`
`30`	`30`	`template <int B, bool C> constexpr Logical &operator=(Logical<B, C> x) {`
`31`	`31`	`word_ = Represent(x.IsTrue());`
	`32`	`+ return *this;`
`32`	`33`	`}`
`33`	`34`
`34`	`35`	`// Fortran actually has only .EQV. & .NEQV. relational operations`