Skip to content

Commit a132806

Browse files
rnkmemfrob
authored andcommitted
Prune TargetInfo.h include from ParsedAttr.h, NFC
Saves ~400 includes of related headers: $ diff -u <(sort thedeps-before.txt) <(sort thedeps-after.txt) \ | grep '^[-+] ' | sort | uniq -c | sort -nr 468 - llvm-project/clang/include/clang/Basic/TargetInfo.h 468 - llvm-project/clang/include/clang/Basic/TargetCXXABI.h 368 - llvm-project/llvm/include/llvm/Support/CodeGen.h 368 - llvm-project/clang/include/clang/Basic/XRayInstr.h 368 - llvm-project/clang/include/clang/Basic/CodeGenOptions.h 368 - llvm-project/clang/include/clang/Basic/CodeGenOptions.def 367 - llvm-project/llvm/include/llvm/ADT/FloatingPointMode.h 367 - llvm-project/clang/include/clang/Basic/DebugInfoOptions.h
1 parent f279ab5 commit a132806

17 files changed

+26
-7
lines changed

clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
#include "clang/Tooling/Core/Diagnostic.h"
2727
#include "llvm/ADT/STLExtras.h"
2828
#include "llvm/ADT/SmallString.h"
29+
#include "llvm/Support/Regex.h"
2930
#include <tuple>
3031
#include <vector>
3132
using namespace clang;

clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@
1919
#include "llvm/ADT/StringMap.h"
2020
#include "llvm/Support/Timer.h"
2121

22+
namespace llvm {
23+
class Regex;
24+
}
25+
2226
namespace clang {
2327

2428
class ASTContext;

clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99
#include "ExpandModularHeadersPPCallbacks.h"
1010
#include "clang/Basic/FileManager.h"
11+
#include "clang/Basic/TargetInfo.h"
1112
#include "clang/Frontend/CompilerInstance.h"
1213
#include "clang/Lex/PreprocessorOptions.h"
1314
#include "clang/Serialization/ASTReader.h"

clang-tools-extra/clang-tidy/cert/DefaultOperatorNewAlignmentCheck.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
#include "DefaultOperatorNewAlignmentCheck.h"
1010
#include "clang/AST/ASTContext.h"
1111
#include "clang/ASTMatchers/ASTMatchFinder.h"
12+
#include "clang/Basic/TargetInfo.h"
1213

1314
using namespace clang::ast_matchers;
1415

clang-tools-extra/clang-tidy/portability/SIMDIntrinsicsCheck.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
#include "SIMDIntrinsicsCheck.h"
1010
#include "clang/AST/ASTContext.h"
1111
#include "clang/ASTMatchers/ASTMatchFinder.h"
12+
#include "clang/Basic/TargetInfo.h"
1213
#include "llvm/ADT/StringMap.h"
1314
#include "llvm/ADT/Triple.h"
1415
#include "llvm/Support/Regex.h"

clang/include/clang/Sema/ParsedAttr.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
#include "clang/Basic/AttributeCommonInfo.h"
1919
#include "clang/Basic/Diagnostic.h"
2020
#include "clang/Basic/SourceLocation.h"
21-
#include "clang/Basic/TargetInfo.h"
2221
#include "clang/Sema/Ownership.h"
2322
#include "llvm/ADT/PointerUnion.h"
2423
#include "llvm/ADT/SmallVector.h"
@@ -40,6 +39,7 @@ class IdentifierInfo;
4039
class LangOptions;
4140
class ParsedAttr;
4241
class Sema;
42+
class TargetInfo;
4343

4444
struct ParsedAttrInfo {
4545
/// Corresponds to the Kind enum.

clang/include/clang/Sema/Sema.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
#include "clang/AST/DeclTemplate.h"
2323
#include "clang/AST/DeclarationName.h"
2424
#include "clang/AST/Expr.h"
25-
#include "clang/AST/ExprConcepts.h"
2625
#include "clang/AST/ExprCXX.h"
26+
#include "clang/AST/ExprConcepts.h"
2727
#include "clang/AST/ExprObjC.h"
2828
#include "clang/AST/ExternalASTSource.h"
2929
#include "clang/AST/LocInfoType.h"
@@ -36,6 +36,7 @@
3636
#include "clang/Basic/BitmaskEnum.h"
3737
#include "clang/Basic/ExpressionTraits.h"
3838
#include "clang/Basic/Module.h"
39+
#include "clang/Basic/OpenCLOptions.h"
3940
#include "clang/Basic/OpenMPKinds.h"
4041
#include "clang/Basic/PragmaKinds.h"
4142
#include "clang/Basic/Specifiers.h"

clang/lib/Frontend/FrontendActions.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
#include "clang/Frontend/FrontendActions.h"
1010
#include "clang/AST/ASTConsumer.h"
1111
#include "clang/Basic/FileManager.h"
12+
#include "clang/Basic/TargetInfo.h"
1213
#include "clang/Basic/LangStandard.h"
1314
#include "clang/Frontend/ASTConsumers.h"
1415
#include "clang/Frontend/CompilerInstance.h"

clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99
#include "clang/AST/Mangle.h"
1010
#include "clang/AST/RecursiveASTVisitor.h"
11+
#include "clang/Basic/TargetInfo.h"
1112
#include "clang/Frontend/CompilerInstance.h"
1213
#include "clang/Frontend/FrontendActions.h"
1314
#include "clang/Sema/TemplateInstCallback.h"

clang/lib/Parse/ParseObjc.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,12 @@
1010
//
1111
//===----------------------------------------------------------------------===//
1212

13-
#include "clang/Parse/Parser.h"
1413
#include "clang/AST/ASTContext.h"
1514
#include "clang/AST/PrettyDeclStackTrace.h"
1615
#include "clang/Basic/CharInfo.h"
16+
#include "clang/Basic/TargetInfo.h"
1717
#include "clang/Parse/ParseDiagnostic.h"
18+
#include "clang/Parse/Parser.h"
1819
#include "clang/Parse/RAIIObjectsForParser.h"
1920
#include "clang/Sema/DeclSpec.h"
2021
#include "clang/Sema/Scope.h"

0 commit comments

Comments
 (0)