Fixed compiler warnings

Author: drasil

BinaryNotes.NET/BinaryNotes/BinaryNotes.csproj

@@ -104,9 +104,6 @@
     <Reference Include="System.Data">
       <Name>System.Data</Name>
     </Reference>
-    <Reference Include="System.Design">
-      <Name>System.Design</Name>
-    </Reference>
     <Reference Include="System.Drawing">
       <Name>System.Drawing</Name>
     </Reference>

BinaryNotes.NET/BinaryNotes/org/bn/coders/CoderUtils.cs

@@ -213,7 +213,7 @@ public static SortedList<int, PropertyInfo> getSetOrder(Type objClass)
                             fieldOrder.Add(tagNA--, field);
                         }
                     }
-                    catch (ArgumentException ex)
+                    catch (ArgumentException)
                     {
                         if (element.HasTag)
                         {

BinaryNotes.NET/BinaryNotes/org/bn/coders/per/PERUnalignedDecoder.cs

@@ -14,20 +14,18 @@ You may obtain a copy of the License at
  See the License for the specific language governing permissions and
  limitations under the License.
  */
-using System;
-using System.Reflection;
-using System.Collections.Generic;
 using org.bn.utils;
-using org.bn.attributes;
-using org.bn.attributes.constraints;
+using System;
+using System.IO;
+using System.Text;
 
 namespace org.bn.coders.per
 {
 
 	public class PERUnalignedDecoder:PERAlignedDecoder
 	{
 
-		protected override void  skipAlignedBits(System.IO.Stream stream)
+		protected override void skipAlignedBits(Stream stream)
 		{
 			// Do nothing! Unaligned encoding ;)
 		}
@@ -43,48 +41,49 @@ protected override long decodeConstraintNumber(long min, long max, BitArrayInput
 			{
 				return max;
 			}
-			//For the UNALIGNED variant the value is always encoded in the minimum 
+			// For the UNALIGNED variant the value is always encoded in the minimum 
 			// number of bits necessary to represent the range (defined in 10.5.3). 
 			int currentBit = maxBitLen;
 			while (currentBit > 7)
 			{
 				currentBit -= 8;
-				result |= stream.ReadByte() << currentBit;
+                result |= (uint)(stream.ReadByte() << currentBit);
 			}
 			if (currentBit > 0)
 			{
-				result |= stream.readBits(currentBit);
+                result |= (uint)stream.readBits(currentBit);
 			}
 			result += min;
 			return result;
 		}
 
-		public override DecodedObject<object> decodeString(DecodedObject<object> decodedTag, System.Type objectClass, ElementInfo elementInfo, System.IO.Stream stream)
+		public override DecodedObject<object> decodeString(DecodedObject<object> decodedTag, Type objectClass, ElementInfo elementInfo, Stream stream)
 		{
-            if (!PERCoderUtils.is7BitEncodedString(elementInfo)) 
+            if (!PERCoderUtils.is7BitEncodedString(elementInfo))
+            {
                 return base.decodeString(decodedTag, objectClass, elementInfo, stream);
-			else
-			{
+            }
+            else
+            {
                 DecodedObject<object> result = new DecodedObject<object>();
                 int strLen = decodeLength(elementInfo, stream);
-
                 if (strLen <= 0)
                 {
-                    result.Value = ("");
-                    return result;
+                    result.Value = "";
+                }
+                else
+                {
+                    BitArrayInputStream bitStream = (BitArrayInputStream)stream;
+                    // 7-bit decoding of string
+                    byte[] buffer = new byte[strLen];
+                    for (int i = 0; i < strLen; i++)
+                    {
+                        buffer[i] = (byte)bitStream.readBits(7);
+                    }
+                    result.Value = new string(ASCIIEncoding.ASCII.GetChars(buffer));
                 }
-			
-				BitArrayInputStream bitStream = (BitArrayInputStream) stream;
-				byte[] buffer = new byte[strLen];
-				// 7-bit decoding of string
-				for (int i = 0; i < strLen; i++)
-					buffer[i] = (byte)bitStream.readBits(7);
-                result.Value = new string(
-                    System.Text.ASCIIEncoding.ASCII.GetChars(buffer)
-                );
                 return result;
-			}
-			
+            }
 		}
 	}
 }

BinaryNotes.NET/BinaryNotes/org/bn/metadata/ASN1StringMetadata.cs

@@ -26,21 +26,18 @@ namespace org.bn.metadata
     public class ASN1StringMetadata : ASN1FieldMetadata
     {
         private bool isUCS = false;
-        private int     stringType = UniversalTags.PrintableString ;
-        private bool hasDefaults = false;
+        private int stringType = UniversalTags.PrintableString;
 
         public ASN1StringMetadata() {
-            hasDefaults = true;
         }
 
         public ASN1StringMetadata(ASN1String annotation)
             : this(annotation.Name, annotation.IsUCS, annotation.StringType)
         {
         }
 
-        public ASN1StringMetadata(String  name,
-                                  bool isUCS,
-                                  int     stringType): base(name)
+        public ASN1StringMetadata(String name, bool isUCS, int stringType)
+            : base(name)
         {
             this.isUCS = isUCS;
             this.stringType = stringType;
@@ -65,7 +62,6 @@ public override void setParentAnnotated(ICustomAttributeProvider parent) {
             }        
         }
 
-
         public override int encode(IASN1TypesEncoder encoder, object obj, Stream stream, ElementInfo elementInfo) 
         {
             return encoder.encodeString(obj, stream, elementInfo);