New features & code maintenance

drcheap · drcheap · commit 2bf1b521a90c · 2025-08-02T21:47:51.000-05:00
Added Quick Resize feature (issue #23) Added an Update option for backups Fix button spacing in presets area Removed a kludgy setTimeout, current size now updates instantly in popup Better centralized constants & utility functions Improved console logging Prefer const over let
diff --git a/README.md b/README.md
@@ -6,6 +6,8 @@ A simple, customizeable window resizer
   - Define multiple custom width & height presets in options
   - Easily switch between them via toolbar menu
   - Even more quickly switch between them via hotkeys
+  - Backup & restore with Sync compatiblity
+  - Compatible with private windows & requires *no browser privileges*
 
 Inspired by the old Firefox add-on [Browsizer]
 
diff --git a/background.js b/background.js
@@ -1,13 +1,9 @@
-"use strict";
-
-const CURRENT_STORAGE_VERSION = 2;
-
 async function initialize(details)
 {
-   console.log("(init) Initializing...");
+   console.debug("Initializing...");
 
    // Preset initialization, if needed
-   let storage = await browser.storage.local.get(["version","presets","options","advanced"]);
+   const storage = await browser.storage.local.get(["version","presets","options","advanced"]);
    if(storage.version === undefined)
    {
       // Had non-versioned preset storage, so treat it as version 1
@@ -22,7 +18,7 @@ async function initialize(details)
 
          if(storage.version == 1)
          {
-            console.log("(update) Migrating storage from version 1 to 2...");
+            console.warn("Migrating storage from version 1 to 2...");
             storage.version = 2;
          }
 
@@ -36,54 +32,80 @@ async function initialize(details)
    }
    else
    {
-      console.log("(init) No storage version tag found, initializing...");
+      console.info("No storage version tag found, initializing...");
       await browser.storage.local.set({"version": CURRENT_STORAGE_VERSION});
    }
 
    if(!Array.isArray(storage.presets))
    {
-      console.log("(init) No presets found, initializing...");
+      console.info("No presets found, initializing...");
       storage.presets = [];
       await browser.storage.local.set({"presets": storage.presets});
    }
 
    if(storage.options === undefined)
    {
-      console.log("(init) No options found, initializing...");
+      console.info("No options found, initializing...");
       storage.options = {};
       await browser.storage.local.set({"options": storage.options});
    }
 
    if(storage.advanced === undefined)
    {
-      console.log("(init) No advanced settings found, initializing...");
+      console.info("No advanced settings found, initializing...");
       storage.advanced = {};
       await browser.storage.local.set({"advanced": storage.advanced});
    }
 
-   console.log("(init) Initialization complete...");
-   console.log("(init)    Storage version: " + storage.version);
-   console.log("(init)    Preset count: " + storage.presets.length);
-   console.log("(init)    Option count: " + Object.keys(storage.options).length);
-   console.log("(init)    Advanced count: " + Object.keys(storage.advanced).length);
+   applyQuickResizeSetting();
+
+   console.debug("Initialization complete...");
+   console.debug("   Storage version: " + storage.version);
+   console.debug("   Preset count: " + storage.presets.length);
+   console.debug("   Option count: " + Object.keys(storage.options).length);
+   console.debug("   Advanced count: " + Object.keys(storage.advanced).length);
 }
 
+// Hotkey handler
 async function handleCommand(command)
 {
-   console.log("(background) handling command: " + command);
+   console.debug("handling command: " + command);
 
    if(command.startsWith(PREFIX_PRESET))
    {
-      let presetNum = parseInt(command.substring(PREFIX_PRESET.length));
-      let storage = await browser.storage.local.get("presets");
-      let presets = storage.presets;
+      const presetNum = parseInt(command.substring(PREFIX_PRESET.length));
+      const storage = await browser.storage.local.get("presets");
+      const presets = storage.presets;
       if(presetNum <= presets.length)
       {
-         let presetId = presets[presetNum - 1].id;
+         const presetId = presets[presetNum - 1].id;
          applyPreset(presetId);
       }
    }
 }
 
+async function toolbarClickHandler()
+{
+   console.debug("Toolbar clicked");
+
+   const storage = await browser.storage.local.get(["presets","options"]);
+   const presets = storage.presets;
+   const options = storage.options;
+
+   useQuickResizeMode = options.useQuickResizeMode !== undefined && options.useQuickResizeMode;
+   if(useQuickResizeMode && presets.length > 0)
+   {
+      applyPreset(presets[0].id);
+   }
+   else
+   {
+      browser.browserAction.openPopup();
+   }
+}
+
 browser.runtime.onInstalled.addListener(initialize);
 browser.commands.onCommand.addListener(handleCommand);
+browser.browserAction.onClicked.addListener(toolbarClickHandler);
+
+const manifest = browser.runtime.getManifest();
+console.info(manifest.name + " version " + manifest.version + " by " + manifest.author);
diff --git a/common.js b/common.js
@@ -1,11 +1,49 @@
-const PREFIX_PRESET = "preset-"; // Must match the one in options.js
+"use strict";
+
+const CURRENT_STORAGE_VERSION = 2;
+
+const MSGTYPE_APPLY_PRESET = "applyPreset";
+const MSGTYPE_GET_SHORTCUT = "getShortcutKey";
+
+const PREFIX_PRESET = "preset-";
+const PREFIX_EDIT = "edit-";
+const PREFIX_UPDATE = "update-";
+const PREFIX_RESTORE = "restore-";
+const PREFIX_REMOVE = "remove-";
+const PREFIX_SAVE = "save-";
+const PREFIX_CANCEL = "cancel-";
+const PREFIX_DOWN = "down-"
+const PREFIX_UP = "up-"
+
+const DEFAULT_POPUP = "toolbar_menu.html";
+
+async function applyQuickResizeSetting()
+{
+   const storage = await browser.storage.local.get(["options","presets"]);
+   const options = storage.options;
+   const presets = storage.presets;
+
+   let newTitle = null;  // Says to use default from manifest
+   let newPopup = "";    // Says to not have one
+   if(options.useQuickResizeMode && presets.length > 0)
+   {
+      newTitle = await browser.browserAction.getTitle({}) + " - Quick Resize mode active, click to apply preset";
+   }
+   else
+   {
+      newPopup = DEFAULT_POPUP;
+   }
+
+   browser.browserAction.setTitle({ title: newTitle });
+   browser.browserAction.setPopup({ popup: newPopup });
+}
 
 async function applyPreset(presetId)
 {
-   console.log("(common) applying preset: " + presetId);
+   console.debug("Applying preset: " + presetId);
 
-   let storage = await browser.storage.local.get("presets");
-   let presets = storage.presets;
+   const storage = await browser.storage.local.get("presets");
+   const presets = storage.presets;
    for(let i = 0;i < presets.length;i++)
    {
       if(presets[i].id == presetId)
@@ -18,24 +56,24 @@ async function applyPreset(presetId)
 
 async function resizeWindow(newWidth, newHeight)
 {
-   console.log("(common) resizing to: " + newWidth + "x" + newHeight);
+   console.debug("Resizing to: " + newWidth + "x" + newHeight);
 
-   let updateInfo = {
+   const updateInfo = {
       "width": parseInt(newWidth),
       "height": parseInt(newHeight)
    };
 
-   let currentWindow = await browser.windows.getCurrent();
+   const currentWindow = await browser.windows.getCurrent();
    await browser.windows.update(currentWindow.id, updateInfo);
 }
 
 async function getShortcutKey(commandName)
 {
-   console.log("(common) retrieving shortcut for " + commandName);
+   console.debug("Retrieving shortcut for " + commandName);
 
    let shortcutKey = "(none)";
 
-   let commands = await browser.commands.getAll();
+   const commands = await browser.commands.getAll();
    for(let command of commands)
    {
       if(command.name == commandName)
diff --git a/manifest.json b/manifest.json
@@ -1,7 +1,7 @@
 {
    "manifest_version": 2,
    "name": "WindowSizer",
-   "version": "1.4.2",
+   "version": "1.5.0",
    "author": "Dr. Cheap",
    "description": "Quickly resize the window to one of your favorite sizes",
    "homepage_url": "https://github.com/drcheap/WindowSizer",
@@ -30,7 +30,6 @@
    "browser_action": {
       "browser_style": true,
       "default_title": "WindowSizer",
-      "default_popup": "toolbar_menu.html",
       "default_icon": {
          "16": "icons/ws_icon_16_dark.png",
          "32": "icons/ws_icon_32_dark.png"
diff --git a/options.css b/options.css
@@ -32,11 +32,15 @@ th, td {
    margin-top: 0.5em;
 }
 
-#currentSize, #getCurrentSize {
+#currentSize, #getCurrentSize, #quickResizeInfo {
    color: rgb(0, 0, 238);
    cursor: pointer;
 }
 
+#quickResizeInfo {
+   cursor: help;
+}
+
 .imgDown, .imgUp {
    cursor: pointer;
 }
diff --git a/options.html b/options.html
@@ -44,6 +44,7 @@
  <fieldset>
   <legend>General Options</legend>
   <form>
+   <input type="checkbox" id="useQuickResizeMode" value="yes"> Use Quick Resize mode for toolbar (<span id="quickResizeInfo">what is this?</span>)<br>
    <input type="checkbox" id="keepActionMenuOnClick" value="yes"> Keep toolbar menu open after choosing a preset
   </form>
  </fieldset>
@@ -90,6 +91,7 @@
   </div>
  </fieldset>
 
+ <script src="common.js"></script>
  <script src="options.js"></script>
 </body>
 </html>
diff --git a/options.js b/options.js
diff --git a/toolbar_menu.js b/toolbar_menu.js

Original file line number	Diff line number	Diff line change
`@@ -32,11 +32,15 @@ th, td {`
`32`	`32`	`margin-top: 0.5em;`
`33`	`33`	`}`
`34`	`34`
`35`		`-#currentSize, #getCurrentSize {`
	`35`	`+#currentSize, #getCurrentSize, #quickResizeInfo {`
`36`	`36`	`color: rgb(0, 0, 238);`
`37`	`37`	`cursor: pointer;`
`38`	`38`	`}`
`39`	`39`
	`40`	`+#quickResizeInfo {`
	`41`	`+ cursor: help;`
	`42`	`+}`
	`43`	`+`
`40`	`44`	`.imgDown, .imgUp {`
`41`	`45`	`cursor: pointer;`
`42`	`46`	`}`