Skip to content

Commit 7073c94

Browse files
committed
Tweaks after review
Clean up a few items pointed out by the AMO review
1 parent ae15069 commit 7073c94

File tree

4 files changed

+8
-9
lines changed

4 files changed

+8
-9
lines changed

manifest.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
"name": "WindowSizer",
44
"version": "0.3beta",
55
"author": "Dr. Cheap",
6-
"description": "Quickly resize the window to one of your favorite sizes.",
7-
"homepage_url": "https://addons.mozilla.org/en-US/firefox/addon/WindowSizer",
6+
"description": "Quickly resize the window to one of your favorite sizes",
7+
"homepage_url": "https://addons.mozilla.org/en-US/firefox/addon/windowsizer",
88
"permissions": ["storage"],
99

1010
"applications": {
@@ -33,5 +33,4 @@
3333
"32": "icons/ws_icon_32.png"
3434
}
3535
}
36-
3736
}

options.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@ th {
55
th, td {
66
padding-left: 10px;
77
padding-top: 2px;
8-
]
8+
}

options.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,23 +76,23 @@ function displayPresets() {
7676
tr.className = "presetItem";
7777

7878
let tdW = document.createElement("td");
79-
tdW.innerHTML = presets[i].width;
79+
tdW.appendChild(document.createTextNode(presets[i].width));
8080
tr.appendChild(tdW);
8181

8282
let tdH = document.createElement("td");
83-
tdH.innerHTML = presets[i].height;
83+
tdH.appendChild(document.createTextNode(presets[i].height));
8484
tr.appendChild(tdH);
8585

8686
let tdN = document.createElement("td");
87-
tdN.innerHTML = presets[i].name;
87+
tdN.appendChild(document.createTextNode(presets[i].name));
8888
tr.appendChild(tdN);
8989

9090
let tdR = document.createElement("td");
9191

9292
let btnR = document.createElement("button");
9393
btnR.type = "button";
9494
btnR.id = presets[i].id;
95-
btnR.innerHTML = "Remove";
95+
btnR.appendChild(document.createTextNode("Remove"));
9696
btnR.addEventListener('click', removePreset);
9797
tdR.appendChild(btnR);
9898

toolbar_menu.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ function updateMenuWithPresets()
1414
let a = document.createElement("a");
1515
a.href = "#";
1616
a.id = RESIZE_PREFIX + presets[i].width + "x" + presets[i].height;
17-
a.innerHTML = presets[i].width + "x" + presets[i].height + " " + presets[i].name;
17+
a.appendChild(document.createTextNode(presets[i].width + "x" + presets[i].height + " " + presets[i].name));
1818
menu.appendChild(a);
1919

2020
let br = document.createElement("br");

0 commit comments

Comments
 (0)