Skip to content

Commit 982ce52

Browse files
Merge pull request #33 from dreadnode/ads/eng-1009-robopages-validation-workflow-is-reporting-fps
fix: validation needs saving as env for pass to comments
2 parents b792b88 + ae8d83a commit 982ce52

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

.github/workflows/validate_robopages.yml

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ name: Validate Contributions
33
on:
44
pull_request:
55
paths:
6-
- '**.yml'
7-
- '!.github/**'
6+
- "**.yml"
7+
- "!.github/**"
88
branches:
99
- main
1010

@@ -19,8 +19,8 @@ jobs:
1919
- name: Checkout code
2020
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 #v4.2.2
2121
with:
22-
fetch-depth: 0 # Fetch all history
23-
ref: ${{ github.head_ref }} # Checkout the PR branch
22+
fetch-depth: 0
23+
ref: ${{ github.head_ref }}
2424

2525
- name: Set up Docker
2626
uses: docker/setup-buildx-action@c47758b77c9736f4b2ef4073d4d51994fabfe349 # 3.7.1
@@ -84,13 +84,16 @@ jobs:
8484
done
8585
8686
exit $overall_status
87+
continue-on-error: true
8788

8889
- name: Post validation status
8990
if: always()
9091
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea #7.0.1
92+
env:
93+
VALIDATION_STATUS: ${{ steps.robopages-validation.outcome == 'success' }}
9194
with:
9295
script: |
93-
const validation_status = process.env.STATE_validation === '0'
96+
const validation_status = process.env.VALIDATION_STATUS === 'true'
9497
? '✅ Validation successful'
9598
: '❌ Validation failed';
9699
const runUrl = `${process.env.GITHUB_SERVER_URL}/${process.env.GITHUB_REPOSITORY}/actions/runs/${process.env.GITHUB_RUN_ID}`;
@@ -114,4 +117,4 @@ jobs:
114117
repo: context.repo.repo,
115118
issue_number: context.issue.number,
116119
body: body
117-
});
120+
});

0 commit comments

Comments
 (0)