Skip to content

Commit 5b055eb

Browse files
deepanshushuklad11deepanshushuklad11
authored
fix: example app fixes and package upgrade (#17)
1 parent e064966 commit 5b055eb

File tree

6 files changed

+100
-102
lines changed

6 files changed

+100
-102
lines changed

‎ReactNativeFastImageExample/Gemfile.lock

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ GEM
9393

9494
PLATFORMS
9595
arm64-darwin-21
96+
arm64-darwin-23
9697

9798
DEPENDENCIES
9899
activesupport (>= 6.1.7.5, < 7.1.0)

‎ReactNativeFastImageExample/ios/ReactNativeFastImageExample.xcodeproj/project.pbxproj

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
13B07FB71A68108700A75B9A /* main.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name = main.m; path = ReactNativeFastImageExample/main.m; sourceTree = "<group>"; };
4040
13B07FB81A68108700A75B9A /* PrivacyInfo.xcprivacy */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; name = PrivacyInfo.xcprivacy; path = ReactNativeFastImageExample/PrivacyInfo.xcprivacy; sourceTree = "<group>"; };
4141
19F6CBCC0A4E27FBF8BF4A61 /* libPods-ReactNativeFastImageExample-ReactNativeFastImageExampleTests.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; includeInIndex = 0; path = "libPods-ReactNativeFastImageExample-ReactNativeFastImageExampleTests.a"; sourceTree = BUILT_PRODUCTS_DIR; };
42-
1D406A7743A8A751B00B8EB4 /* PrivacyInfo.xcprivacy */ = {isa = PBXFileReference; includeInIndex = 1; name = PrivacyInfo.xcprivacy; path = ReactNativeFastImageExample/PrivacyInfo.xcprivacy; sourceTree = "<group>"; };
42+
1D406A7743A8A751B00B8EB4 /* PrivacyInfo.xcprivacy */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xml; name = PrivacyInfo.xcprivacy; path = ReactNativeFastImageExample/PrivacyInfo.xcprivacy; sourceTree = "<group>"; };
4343
3B4392A12AC88292D35C810B /* Pods-ReactNativeFastImageExample.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-ReactNativeFastImageExample.debug.xcconfig"; path = "Target Support Files/Pods-ReactNativeFastImageExample/Pods-ReactNativeFastImageExample.debug.xcconfig"; sourceTree = "<group>"; };
4444
5709B34CF0A7D63546082F79 /* Pods-ReactNativeFastImageExample.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-ReactNativeFastImageExample.release.xcconfig"; path = "Target Support Files/Pods-ReactNativeFastImageExample/Pods-ReactNativeFastImageExample.release.xcconfig"; sourceTree = "<group>"; };
4545
5B7EB9410499542E8C5724F5 /* Pods-ReactNativeFastImageExample-ReactNativeFastImageExampleTests.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-ReactNativeFastImageExample-ReactNativeFastImageExampleTests.debug.xcconfig"; path = "Target Support Files/Pods-ReactNativeFastImageExample-ReactNativeFastImageExampleTests/Pods-ReactNativeFastImageExample-ReactNativeFastImageExampleTests.debug.xcconfig"; sourceTree = "<group>"; };
@@ -590,10 +590,7 @@
590590
"-DFOLLY_CFG_NO_COROUTINES=1",
591591
"-DFOLLY_HAVE_CLOCK_GETTIME=1",
592592
);
593-
OTHER_LDFLAGS = (
594-
"$(inherited)",
595-
" ",
596-
);
593+
OTHER_LDFLAGS = "$(inherited) ";
597594
REACT_NATIVE_PATH = "${PODS_ROOT}/../../node_modules/react-native";
598595
SDKROOT = iphoneos;
599596
USE_HERMES = true;
@@ -665,10 +662,7 @@
665662
"-DFOLLY_CFG_NO_COROUTINES=1",
666663
"-DFOLLY_HAVE_CLOCK_GETTIME=1",
667664
);
668-
OTHER_LDFLAGS = (
669-
"$(inherited)",
670-
" ",
671-
);
665+
OTHER_LDFLAGS = "$(inherited) ";
672666
REACT_NATIVE_PATH = "${PODS_ROOT}/../../node_modules/react-native";
673667
SDKROOT = iphoneos;
674668
USE_HERMES = true;

‎ReactNativeFastImageExample/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"@react-navigation/native": "^6.1.17",
1616
"@react-navigation/stack": "^6.3.29",
1717
"react": "18.2.0",
18-
"react-native": "0.74.2",
18+
"react-native": "^0.74.2",
1919
"react-native-gesture-handler": "^2.16.2",
2020
"react-native-image-picker": "^7.1.2",
2121
"react-native-image-progress": "^1.2.0",

‎package.json

Lines changed: 91 additions & 88 deletions
Original file line numberDiff line numberDiff line change
@@ -1,92 +1,95 @@
11
{
2-
"name": "@d11/react-native-fast-image",
3-
"version": "8.6.5",
4-
"description": "🚩 FastImage, performant React Native image component.",
5-
"keywords": [
6-
"cache",
7-
"cached",
8-
"fastimage",
9-
"image",
10-
"priority"
2+
"name": "@d11/react-native-fast-image",
3+
"version": "8.6.7",
4+
"description": "🚩 FastImage, performant React Native image component.",
5+
"keywords": [
6+
"cache",
7+
"cached",
8+
"fastimage",
9+
"image",
10+
"priority"
11+
],
12+
"homepage": "https://github.com/dream11/react-native-fast-image#readme",
13+
"bugs": {
14+
"url": "https://github.com/dream11/react-native-fast-image/issues"
15+
},
16+
"repository": {
17+
"type": "git",
18+
"url": "https://github.com/dream11/react-native-fast-image.git"
19+
},
20+
"license": "(MIT AND Apache-2.0)",
21+
"author": "Deepanshu shukla <[email protected]> (https://dream11.com)",
22+
"source": "src/index",
23+
"main": "dist/index.cjs.js",
24+
"module": "dist/index.js",
25+
"typings": "dist/index.d.ts",
26+
"files": [
27+
"src",
28+
"android",
29+
"!android/build",
30+
"ios",
31+
"!ios/build",
32+
"dist",
33+
"RNFastImage.podspec"
34+
],
35+
"scripts": {
36+
"prepack": "yarn build",
37+
"example": "yarn workspace reactnativefastimageexample",
38+
"build": "dv-scripts build && cp src/index.js.flow dist/index.js.flow && cp src/index.js.flow dist/index.cjs.js.flow",
39+
"lint": "dv-scripts lint",
40+
"release": "dv-scripts release",
41+
"test": "dv-scripts test"
42+
},
43+
"prettier": {
44+
"semi": false,
45+
"singleQuote": true,
46+
"tabWidth": 4,
47+
"trailingComma": "all"
48+
},
49+
"eslintConfig": {
50+
"extends": "dv-scripts"
51+
},
52+
"jest": {
53+
"coveragePathIgnorePatterns": [
54+
"ReactNativeFastImageExample*",
55+
"ReactNativeFastImageExampleServer*"
1156
],
12-
"homepage": "https://github.com/dream11/react-native-fast-image#readme",
13-
"bugs": {
14-
"url": "https://github.com/dream11/react-native-fast-image/issues"
15-
},
16-
"repository": {
17-
"type": "git",
18-
"url": "https://github.com/dream11/react-native-fast-image.git"
19-
},
20-
"license": "(MIT AND Apache-2.0)",
21-
"author": "Deepanshu shukla <[email protected]> (https://dream11.com)",
22-
"main": "dist/index.cjs.js",
23-
"module": "dist/index.js",
24-
"typings": "dist/index.d.ts",
25-
"files": [
26-
"android",
27-
"!android/build",
28-
"ios",
29-
"!ios/build",
30-
"dist",
31-
"RNFastImage.podspec"
57+
"modulePathIgnorePatterns": [
58+
"ReactNativeFastImageExample*",
59+
"ReactNativeFastImageExampleServer*"
3260
],
33-
"scripts": {
34-
"prepack": "yarn build",
35-
"example": "yarn workspace reactnativefastimageexample",
36-
"build": "dv-scripts build && cp src/index.js.flow dist/index.js.flow && cp src/index.js.flow dist/index.cjs.js.flow",
37-
"lint": "dv-scripts lint",
38-
"release": "dv-scripts release",
39-
"test": "dv-scripts test"
40-
},
41-
"prettier": {
42-
"semi": false,
43-
"singleQuote": true,
44-
"tabWidth": 4,
45-
"trailingComma": "all"
46-
},
47-
"eslintConfig": {
48-
"extends": "dv-scripts"
49-
},
50-
"jest": {
51-
"coveragePathIgnorePatterns": [
52-
"ReactNativeFastImageExample*",
53-
"ReactNativeFastImageExampleServer*"
54-
],
55-
"modulePathIgnorePatterns": [
56-
"ReactNativeFastImageExample*",
57-
"ReactNativeFastImageExampleServer*"
58-
],
59-
"preset": "react-native"
60-
},
61-
"resolutions": {
62-
"@jest/create-cache-key-function": "^27"
63-
},
64-
"devDependencies": {
65-
"@babel/core": "^7.24.7",
66-
"@babel/preset-env": "^7.20.0",
67-
"@babel/runtime": "^7.24.7",
68-
"@react-native/babel-preset": "0.74.84",
69-
"@react-native/metro-config": "0.74.84",
70-
"@react-native/typescript-config": "0.74.84",
71-
"@types/jest": "^26.0.24",
72-
"@types/react": "^18.3.3",
73-
"@types/react-native": "^0.69.5",
74-
"@types/react-test-renderer": "^17.0.1",
75-
"babel-plugin-module-resolver": "^5.0.0",
76-
"dv-scripts": "^1.6.0",
77-
"eslint-config-dv-scripts": "^1.1.1",
78-
"metro-react-native-babel-preset": "^0.66.1",
79-
"prettier": "^2.3.2",
80-
"react": "18.2.0",
81-
"react-native": "0.74.2",
82-
"react-test-renderer": "17.0.2",
83-
"typescript": "^4.3.5"
84-
},
85-
"peerDependencies": {
86-
"react": "*",
87-
"react-native": "*"
88-
},
89-
"workspaces": [
90-
"ReactNativeFastImageExample"
91-
]
61+
"preset": "react-native"
62+
},
63+
"resolutions": {
64+
"@jest/create-cache-key-function": "^27"
65+
},
66+
"devDependencies": {
67+
"@babel/core": "^7.24.7",
68+
"@babel/preset-env": "^7.20.0",
69+
"@babel/runtime": "^7.24.7",
70+
"@react-native/babel-preset": "0.74.84",
71+
"@react-native/metro-config": "0.74.84",
72+
"@react-native/typescript-config": "0.74.84",
73+
"@types/jest": "^26.0.24",
74+
"@types/react": "^18.3.3",
75+
"@types/react-native": "^0.69.5",
76+
"@types/react-test-renderer": "^17.0.1",
77+
"babel-plugin-module-resolver": "^5.0.0",
78+
"dv-scripts": "^1.6.0",
79+
"eslint-config-dv-scripts": "^1.1.1",
80+
"metro-react-native-babel-preset": "^0.66.1",
81+
"prettier": "^2.3.2",
82+
"react": "18.2.0",
83+
"react-native": "0.74.2",
84+
"react-test-renderer": "17.0.2",
85+
"typescript": "^4.3.5"
86+
},
87+
"peerDependencies": {
88+
"react": "*",
89+
"react-native": "*"
90+
},
91+
"workspaces": [
92+
"ReactNativeFastImageExample"
93+
],
94+
"packageManager": "[email protected]"
9295
}

‎src/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ function FastImageBase({
177177
const resolvedSource = Image.resolveAssetSource(cleanedSource)
178178

179179
return (
180-
<View style={[styles.imageContainer, style]} ref={forwardedRef} accessible>
180+
<View style={[styles.imageContainer, style]} ref={forwardedRef} accessible ={accessible}>
181181
<Image
182182
{...props}
183183
style={[StyleSheet.absoluteFill, { tintColor }]}
@@ -199,7 +199,7 @@ function FastImageBase({
199199
const resolvedDefaultSource = resolveDefaultSource(defaultSource)
200200

201201
return (
202-
<View style={[styles.imageContainer, style]} ref={forwardedRef} accessible>
202+
<View style={[styles.imageContainer, style]} ref={forwardedRef} accessible ={accessible}>
203203
<FastImageView
204204
{...props}
205205
tintColor={tintColor}

‎yarn.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13290,7 +13290,7 @@ __metadata:
1329013290
languageName: node
1329113291
linkType: hard
1329213292

13293-
"react-native@npm:*, react-native@npm:0.74.2":
13293+
"react-native@npm:*, react-native@npm:0.74.2, react-native@npm:^0.74.2":
1329413294
version: 0.74.2
1329513295
resolution: "react-native@npm:0.74.2"
1329613296
dependencies:
@@ -13430,7 +13430,7 @@ __metadata:
1343013430
jest: ^29.6.3
1343113431
prettier: 2.8.8
1343213432
react: 18.2.0
13433-
react-native: 0.74.2
13433+
react-native: ^0.74.2
1343413434
react-native-codegen: ^0.70.7
1343513435
react-native-gesture-handler: ^2.16.2
1343613436
react-native-image-picker: ^7.1.2

0 commit comments

Comments
 (0)