chore: fix pre-existing pre-commit failures (#68)

Fix ty type checker errors and warnings:
- Remove 29 now-unused type: ignore comments across scraper.py,
  examples, and tests (ty updated its BS4 type stubs)
- Fix invalid-assignment in models.py by annotating trip_report
  as dict[str, Any] before mutating it
- Fix str | AttributeValueList assignment in scraper.py by casting
  url_link["href"] to str()

Fix yamllint warnings and errors in workflow files:
- Add required second space before inline # comments in ci.yml,
  release.yml, scorecard.yml, and codeql.yml
- Break long comment string in dependabot-auto-merge.yml into a
  $BODY variable to stay under the 120-char line limit

Co-authored-by: Aaron Gustafson <jag426@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Dmytro Gaivoronsky <the@dreamiurg.net>

Author: 3 people

.github/workflows/ci.yml

@@ -30,17 +30,17 @@ jobs:
     name: Lint and format check
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8  # v5
 
       - name: Set up Python
-        uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6
+        uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c  # v6
         with:
           python-version: "3.14"
           cache: pip
           cache-dependency-path: pyproject.toml
 
       - name: Install uv
-        uses: astral-sh/setup-uv@85856786d1ce8acfbcc2f13a5f3fbd6b938f9f41 # v7
+        uses: astral-sh/setup-uv@85856786d1ce8acfbcc2f13a5f3fbd6b938f9f41  # v7
         with:
           enable-cache: true
           cache-dependency-glob: "pyproject.toml"
@@ -75,17 +75,17 @@ jobs:
             python-version: "3.14"
 
     steps:
-      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8  # v5
 
       - name: Set up Python ${{ matrix.python-version }}
-        uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6
+        uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c  # v6
         with:
           python-version: ${{ matrix.python-version }}
           cache: pip
           cache-dependency-path: pyproject.toml
 
       - name: Install uv
-        uses: astral-sh/setup-uv@85856786d1ce8acfbcc2f13a5f3fbd6b938f9f41 # v7
+        uses: astral-sh/setup-uv@85856786d1ce8acfbcc2f13a5f3fbd6b938f9f41  # v7
         with:
           enable-cache: true
           cache-dependency-glob: "pyproject.toml"
@@ -98,7 +98,7 @@ jobs:
 
       - name: Upload coverage to Codecov
         if: matrix.os == 'ubuntu-latest' && matrix.python-version == '3.14'
-        uses: codecov/codecov-action@5a1091511ad55cbe89839c7260b706298ca349f7 # v5
+        uses: codecov/codecov-action@5a1091511ad55cbe89839c7260b706298ca349f7  # v5
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
           file: ./coverage.xml
@@ -110,7 +110,7 @@ jobs:
     if: github.event_name == 'pull_request'
     steps:
       - name: Validate PR title follows conventional commit format
-        uses: amannn/action-semantic-pull-request@48f256284bd46cdaab1048c3721360e808335d50 # v6
+        uses: amannn/action-semantic-pull-request@48f256284bd46cdaab1048c3721360e808335d50  # v6
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:

.github/workflows/codeql.yml

@@ -24,16 +24,16 @@ jobs:
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
+        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8  # v5
 
       - name: Initialize CodeQL
-        uses: github/codeql-action/init@5d5cd550d3e189c569da8f16ea8de2d821c9bf7a # v3
+        uses: github/codeql-action/init@5d5cd550d3e189c569da8f16ea8de2d821c9bf7a  # v3
         with:
           languages: python
           # Queries: security-extended includes all security checks
           queries: security-extended
 
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@5d5cd550d3e189c569da8f16ea8de2d821c9bf7a # v3
+        uses: github/codeql-action/analyze@5d5cd550d3e189c569da8f16ea8de2d821c9bf7a  # v3
         with:
           category: "/language:python"

.github/workflows/dependabot-auto-merge.yml

@@ -32,5 +32,6 @@ jobs:
           PR_URL: ${{ github.event.pull_request.html_url }}
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
-          gh pr comment "$PR_URL" --body \
-            "This is a **major version update** and will not be auto-merged. Please review the changelog for breaking changes before merging manually."
+          BODY="This is a **major version update** and will not be auto-merged."
+          BODY="$BODY Please review the changelog for breaking changes before merging manually."
+          gh pr comment "$PR_URL" --body "$BODY"

.github/workflows/release.yml

@@ -20,26 +20,26 @@ jobs:
     steps:
       - name: Generate GitHub App token
         id: app-token
-        uses: actions/create-github-app-token@67018539274d69449ef7c02e8e71183d1719ab42 # v2
+        uses: actions/create-github-app-token@67018539274d69449ef7c02e8e71183d1719ab42  # v2
         with:
           app-id: ${{ secrets.RELEASE_APP_ID }}
           private-key: ${{ secrets.RELEASE_APP_PRIVATE_KEY }}
 
       - name: Checkout
-        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
+        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8  # v5
         with:
           fetch-depth: 0
           token: ${{ steps.app-token.outputs.token }}
 
       - name: Set up Python
-        uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6
+        uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c  # v6
         with:
           python-version: '3.12'
           cache: pip
           cache-dependency-path: pyproject.toml
 
       - name: Install uv
-        uses: astral-sh/setup-uv@85856786d1ce8acfbcc2f13a5f3fbd6b938f9f41 # v7
+        uses: astral-sh/setup-uv@85856786d1ce8acfbcc2f13a5f3fbd6b938f9f41  # v7
         with:
           enable-cache: true
           cache-dependency-glob: "pyproject.toml"
@@ -68,6 +68,6 @@ jobs:
 
       - name: Publish to PyPI
         if: steps.semantic-release.outputs.new_release == 'true'
-        uses: pypa/gh-action-pypi-publish@ed0c53931b1dc9bd32cbe73a98c7f6766f8a527e # release/v1
+        uses: pypa/gh-action-pypi-publish@ed0c53931b1dc9bd32cbe73a98c7f6766f8a527e  # release/v1
         with:
           print-hash: true

.github/workflows/scorecard.yml

@@ -27,26 +27,26 @@ jobs:
 
     steps:
       - name: Checkout code
-        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
+        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8  # v5
         with:
           persist-credentials: false
 
       - name: Run analysis
-        uses: ossf/scorecard-action@4eaacf0543bb3f2c246792bd56e8cdeffafb205a # v2.4.3
+        uses: ossf/scorecard-action@4eaacf0543bb3f2c246792bd56e8cdeffafb205a  # v2.4.3
         with:
           results_file: results.sarif
           results_format: sarif
           # Publish results to OpenSSF REST API for the badge
           publish_results: true
 
       - name: Upload artifact
-        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02  # v4
         with:
           name: SARIF file
           path: results.sarif
           retention-days: 5
 
       - name: Upload to code-scanning
-        uses: github/codeql-action/upload-sarif@0499de31b99561a6d14a36a5f662c2a54f91beee # v4
+        uses: github/codeql-action/upload-sarif@0499de31b99561a6d14a36a5f662c2a54f91beee  # v4
         with:
           sarif_file: results.sarif

examples/batch_peaks.py

@@ -24,7 +24,7 @@ def fetch_peak_details(peak_id: str) -> dict[str, Any] | None:
             text=True,
             check=True,
         )
-        return json.loads(result.stdout)  # type: ignore[no-any-return]
+        return json.loads(result.stdout)
     except subprocess.CalledProcessError as e:
         print(f"Error fetching peak {peak_id}: {e}", file=sys.stderr)
         return None

examples/export_csv.py

@@ -24,7 +24,7 @@ def search_peaks(query: str) -> list[dict[str, Any]]:
             text=True,
             check=True,
         )
-        return json.loads(result.stdout)  # type: ignore[no-any-return]
+        return json.loads(result.stdout)
     except (subprocess.CalledProcessError, json.JSONDecodeError) as e:
         print(f"Error searching for '{query}': {e}", file=sys.stderr)
         return []
@@ -39,7 +39,7 @@ def fetch_peak_details(peak_id: str) -> dict[str, Any] | None:
             text=True,
             check=True,
         )
-        return json.loads(result.stdout)  # type: ignore[no-any-return]
+        return json.loads(result.stdout)
     except (subprocess.CalledProcessError, json.JSONDecodeError) as e:
         print(f"Error fetching peak {peak_id}: {e}", file=sys.stderr)
         return None

peakbagger/models.py

@@ -132,7 +132,7 @@ def to_dict(self) -> dict[str, Any]:
         }
 
         # Add trip report info
-        result["trip_report"] = {
+        trip_report: dict[str, Any] = {
             "has_report": self.has_trip_report,
             "word_count": self.trip_report_words,
         }
@@ -166,9 +166,10 @@ def to_dict(self) -> dict[str, Any]:
 
         # Add full trip report text if present
         if self.trip_report_text:
-            result["trip_report"]["text"] = self.trip_report_text
+            trip_report["text"] = self.trip_report_text
         if self.trip_report_url:
-            result["trip_report"]["external_url"] = self.trip_report_url
+            trip_report["external_url"] = self.trip_report_url
+        result["trip_report"] = trip_report
 
         return result
 

peakbagger/scraper.py

@@ -42,26 +42,26 @@ def parse_search_results(html: str) -> list[SearchResult]:
             return results
 
         # Find the next table after the header
-        table: Tag | None = search_header.find_next("table", class_="gray")  # type: ignore[assignment]
+        table: Tag | None = search_header.find_next("table", class_="gray")
         if not table:
             logger.debug("No search results table found")
             return results
 
         # Skip header row, process data rows
-        rows: list[Tag] = table.find_all("tr")[1:]  # type: ignore[assignment]
+        rows: list[Tag] = table.find_all("tr")[1:]
         logger.debug(f"Found {len(rows)} result rows to process")
 
         for row in rows:
-            cells: list[Tag] = row.find_all("td")  # type: ignore[assignment]
+            cells: list[Tag] = row.find_all("td")
             if len(cells) < 5:  # Need at least: Type, Name, Location, Range, Elevation
                 continue
 
             # Extract peak link (2nd column)
-            link: Tag | None = cells[1].find("a", href=lambda x: x and "peak.aspx?pid=" in x)  # type: ignore[assignment]
+            link: Tag | None = cells[1].find("a", href=lambda x: x and "peak.aspx?pid=" in x)
             if not link:
                 continue
 
-            href: str = link["href"]  # type: ignore[assignment]
+            href: str = link["href"]
             name: str = link.get_text(strip=True)
 
             # Extract peak ID from URL
@@ -126,7 +126,7 @@ def parse_peak_detail(html: str, pid: str) -> Peak | None:
 
         try:
             # Extract peak name and state from H1
-            h1: Tag | None = soup.find("h1")  # type: ignore[assignment]
+            h1: Tag | None = soup.find("h1")
             if not h1:
                 logger.debug("No H1 tag found in peak detail page")
                 return None
@@ -143,7 +143,7 @@ def parse_peak_detail(html: str, pid: str) -> Peak | None:
             peak: Peak = Peak(pid=pid, name=name, state=state)
 
             # Extract elevation from H2
-            h2: Tag | None = soup.find("h2")  # type: ignore[assignment]
+            h2: Tag | None = soup.find("h2")
             if h2:
                 elevation_text: str = h2.get_text(strip=True)
                 # Format: "Elevation: 10,984 feet, 3348 meters"
@@ -310,7 +310,7 @@ def parse_peak_ascents(html: str) -> list[Ascent]:
         ascents: list[Ascent] = []
 
         # Find all tables
-        tables: list[Tag] = soup.find_all("table")  # type: ignore[assignment]
+        tables: list[Tag] = soup.find_all("table")
         logger.debug(f"Found {len(tables)} tables in HTML")
 
         # Look for the data table with dynamic header detection
@@ -319,14 +319,14 @@ def parse_peak_ascents(html: str) -> list[Ascent]:
         num_columns: int = 0
 
         for table in tables:
-            rows: list[Tag] = table.find_all("tr")  # type: ignore[assignment]
+            rows: list[Tag] = table.find_all("tr")
             if len(rows) < 10:
                 continue
 
             # Check if second row has expected headers
             if len(rows) > 1:
                 header_row: Tag = rows[1]
-                headers: list[Tag] = header_row.find_all(["th", "td"], recursive=False)  # type: ignore[assignment]
+                headers: list[Tag] = header_row.find_all(["th", "td"], recursive=False)
 
                 # Table must have reasonable number of columns (not the merged giant table)
                 if len(headers) < 3 or len(headers) > 20:
@@ -368,7 +368,7 @@ def parse_peak_ascents(html: str) -> list[Ascent]:
         # Process data rows (skip first 2 rows: separator and header)
         for row in rows[2:]:
             # Use recursive=False to avoid counting cells in nested tables (e.g., route icons)
-            cells: list[Tag] = row.find_all(["td", "th"], recursive=False)  # type: ignore[assignment]
+            cells: list[Tag] = row.find_all(["td", "th"], recursive=False)
 
             # Skip rows that don't match the expected column count
             if len(cells) != num_columns:
@@ -378,7 +378,7 @@ def parse_peak_ascents(html: str) -> list[Ascent]:
             climber_cell: Tag = cells[climber_idx]
             climber_link: Tag | None = climber_cell.find(
                 "a", href=lambda x: x and "climber.aspx?cid=" in x
-            )  # type: ignore[assignment]
+            )
             if not climber_link:
                 continue
 
@@ -391,7 +391,7 @@ def parse_peak_ascents(html: str) -> list[Ascent]:
             date_cell: Tag = cells[date_idx]
             date_link: Tag | None = date_cell.find(
                 "a", href=lambda x: x and "ascent.aspx?aid=" in x
-            )  # type: ignore[assignment]
+            )
             if not date_link:
                 continue
 
@@ -415,7 +415,7 @@ def parse_peak_ascents(html: str) -> list[Ascent]:
             has_gpx: bool = False
             if gps_idx != -1:
                 gps_cell: Tag = cells[gps_idx]
-                gps_img: Tag | None = gps_cell.find("img", src=lambda x: x and "GPS.gif" in x)  # type: ignore[assignment]
+                gps_img: Tag | None = gps_cell.find("img", src=lambda x: x and "GPS.gif" in x)
                 has_gpx = gps_img is not None
 
             # Check for trip report (optional column)
@@ -470,7 +470,7 @@ def parse_ascent_detail(html: str, ascent_id: str) -> Ascent | None:
 
         try:
             # Extract title: "Ascent of [Peak Name] on [Date]" or "Ascent of [Peak Name] in [Year]"
-            h1: Tag | None = soup.find("h1")  # type: ignore[assignment]
+            h1: Tag | None = soup.find("h1")
             if not h1:
                 logger.debug("No H1 tag found in ascent detail page")
                 return None
@@ -486,13 +486,13 @@ def parse_ascent_detail(html: str, ascent_id: str) -> Ascent | None:
                 peak_name = parts[0].replace("Ascent of ", "").strip()
 
             # Extract climber from H2: "Climber: [Name]"
-            h2: Tag | None = soup.find("h2")  # type: ignore[assignment]
+            h2: Tag | None = soup.find("h2")
             climber_name: str | None = None
             climber_id: str | None = None
             if h2:
                 climber_link: Tag | None = h2.find(
                     "a", href=lambda x: x and "climber.aspx?cid=" in x
-                )  # type: ignore[assignment]
+                )
                 if climber_link:
                     climber_name = climber_link.get_text(strip=True)
                     climber_href: str = climber_link["href"]  # type: ignore[assignment]
@@ -506,7 +506,7 @@ def parse_ascent_detail(html: str, ascent_id: str) -> Ascent | None:
             # Find the left gray table (width="49%", align="left")
             table: Tag | None = soup.find(
                 "table", class_="gray", attrs={"width": "49%", "align": "left"}
-            )  # type: ignore[assignment]
+            )
             if not table:
                 return None
 
@@ -519,9 +519,9 @@ def parse_ascent_detail(html: str, ascent_id: str) -> Ascent | None:
             )
 
             # Extract data from table rows
-            rows: list[Tag] = table.find_all("tr")  # type: ignore[assignment]
+            rows: list[Tag] = table.find_all("tr")
             for row in rows:
-                cells: list[Tag] = row.find_all("td", recursive=False)  # type: ignore[assignment]
+                cells: list[Tag] = row.find_all("td", recursive=False)
                 if len(cells) < 1:
                     continue
 
@@ -551,9 +551,9 @@ def parse_ascent_detail(html: str, ascent_id: str) -> Ascent | None:
                             ascent.trip_report_text = report_text.strip()
 
                         # Extract external URL if present
-                        url_link: Tag | None = cells[0].find("a", href=re.compile(r"^https?://"))  # type: ignore[assignment]
+                        url_link: Tag | None = cells[0].find("a", href=re.compile(r"^https?://"))
                         if url_link and url_link.get("href"):
-                            href = url_link["href"]  # type: ignore[assignment]
+                            href = str(url_link["href"])
                             # Only store if not peakbagger.com
                             if "peakbagger.com" not in href:
                                 ascent.trip_report_url = href
@@ -565,7 +565,7 @@ def parse_ascent_detail(html: str, ascent_id: str) -> Ascent | None:
                 # Get label from first cell
                 # Some labels have <b> tags, others are just text
                 label_cell = cells[0]
-                label_b: Tag | None = label_cell.find("b")  # type: ignore[assignment]
+                label_b: Tag | None = label_cell.find("b")
                 if label_b:
                     label: str = label_b.get_text(strip=True).rstrip(":")
                 else:
@@ -616,7 +616,7 @@ def parse_ascent_detail(html: str, ascent_id: str) -> Ascent | None:
                     # Extract peak link and ID
                     peak_link: Tag | None = value_cell.find(
                         "a", href=lambda x: x and "peak.aspx?pid=" in x
-                    )  # type: ignore[assignment]
+                    )
                     if peak_link:
                         ascent.peak_name = peak_link.get_text(strip=True)
                         peak_href: str = peak_link["href"]  # type: ignore[assignment]