Fixed config publishing;

$expiration default behaviour moved to internal `sign()` method instead of helper

Author: IlCallo

CHANGELOG.md

@@ -2,6 +2,11 @@
 
 All notable changes to `laravel-cloudfront-url-signer` will be documented in this file.
 
+## 0.1.2 - 2018-02-09
+
+- Fixed config publishing
+- $expiration default behaviour moved to internal `sign()` method instead of helper
+
 ## 0.1.1 - 2018-02-09
 
 - $expiration parameter of `sign()` helper now defaults to the value defined in the configuration file when not defined

README.md

@@ -6,15 +6,19 @@ Inspired by [laravel-url-signer](https://github.com/spatie/laravel-url-signer)
 [![Latest Version on Packagist](https://img.shields.io/packagist/v/dreamonkey/laravel-cloudfront-url-signer.svg?style=flat-square)](https://packagist.org/packages/dreamonkey/laravel-cloudfront-url-signer)
 [![Total Downloads](https://img.shields.io/packagist/dt/dreamonkey/laravel-cloudfront-url-signer.svg?style=flat-square)](https://packagist.org/packages/dreamonkey/laravel-cloudfront-url-signer)
 
-This package can create canned policies signed URLs for CloudFront which expires after a given time. This is done by wrapping the AWS SDK method adding a Laravel-style configuration.
+This package can create canned policies signed URLs for CloudFront which expires after a given time. This is done by wrapping the AWS SDK method adding a Laravel-style configuration and accessibility.
 
 This is how you can create signed URL that's valid for 30 days:
 
 ```php
+// With Facade
 CloudFrontUrlSigner::sign('https://myapp.com/resource', 30);
+
+// With helper
+sign('https://myapp.com/resource', 30);
 ```
 
-The output will be compliant with [CloudFront specifications](https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/private-content-creating-signed-url-canned-policy.html)
+The output is compliant with [CloudFront specifications](https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/private-content-creating-signed-url-canned-policy.html)
 
 ## Installation
 

src/CloudFrontUrlSigner.php

@@ -59,16 +59,17 @@ public function __construct(CloudFrontClient $cloudFrontClient, string $privateK
      * Get a secure URL to a controller action.
      *
      * @param string $url
-     * @param \DateTime|int $expiration
+     * @param \DateTime|int|null $expiration
      *
      * @return string
      * @throws \Dreamonkey\CloudFrontUrlSigner\Exceptions\InvalidExpiration
      */
-    public function sign(string $url, $expiration): string
+    public function sign(string $url, $expiration = null): string
     {
         $resourceKey = Http::createFromString($url);
 
-        $expiration = $this->getExpirationTimestamp($expiration);
+        $expiration = $this->getExpirationTimestamp($expiration ??
+            config('cloudfront-url-signer.default_expiration_time_in_days'));
 
         return $this->cloudFrontClient->getSignedUrl([
             'url' => $resourceKey,

src/CloudFrontUrlSignerServiceProvider.php

@@ -24,7 +24,7 @@ public function boot()
     protected function setupConfig(Application $app)
     {
         $source = realpath(__DIR__ . '/../config/cloudfront-url-signer.php');
-        $this->publishes([$source => config_path('cloudfront-url-signer.php')]);
+        $this->publishes([$source => config_path('cloudfront-url-signer.php')], 'config');
         $this->mergeConfigFrom($source, 'cloudfront-url-signer');
     }
 

src/helpers.php

@@ -13,7 +13,6 @@
      */
     function sign(string $url, $expiration = null): string
     {
-        return app(UrlSigner::class)
-            ->sign($url, $expiration ?? config('cloudfront-url-signer.default_expiration_time_in_days'));
+        return app(UrlSigner::class)->sign($url, $expiration);
     }
 }