Cloud testing (#290)

### Summary

Adjusting dbt tests to run against other environments (with the goal of
us being able to run tests against Dremio DC).

### Description

This PR makes the testing framework more flexible, mainly by removing
some hard coded values.

Author: simonpannek

.github/expected_failures_cloud.txt

@@ -0,0 +1,24 @@
+tests/functional/adapter/unit_testing/test_unit_testing.py::TestDremioUnitTestingTypes::test_unit_test_data_type
+tests/functional/adapter/dremio_specific/test_persist_docs.py::TestPersistDocs::test_view_model_delete_wikis_and_tags
+tests/functional/adapter/dremio_specific/test_persist_docs.py::TestPersistDocs::test_view_model_update_wikis_and_tags
+tests/functional/adapter/dremio_specific/test_persist_docs.py::TestPersistDocs::test_view_model_wikis_and_tags_remain_when_no_changes
+tests/functional/adapter/grants/test_incremental_grants.py::TestIncrementalGrantsDremio::test_incremental_grants
+tests/functional/adapter/grants/test_model_grants.py::TestTableGrantsDremio::test_view_table_grants
+tests/functional/adapter/grants/test_model_grants.py::TestViewGrantsDremio::test_view_table_grants
+tests/functional/adapter/grants/test_seed_grants.py::TestSeedGrantsDremio::test_seed_grants
+tests/functional/adapter/materialization/test_base_mat.py::TestSimpleMaterializationsDremio::test_base
+tests/functional/adapter/utils/test_array_append.py::TestArrayAppend::test_expected_actual
+tests/functional/adapter/utils/test_array_concat.py::TestArrayConcat::test_expected_actual
+tests/functional/adapter/utils/test_null_compare.py::TestMixedNullCompare::test_build_assert_equal
+tests/functional/adapter/utils/test_null_compare.py::TestNullCompare::test_build_assert_equal
+tests/simple_copy/test_simple_copy.py::TestSimpleCopyBaseDremio::test_simple_copy_with_materialized_views
+tests/functional/adapter/grants/test_snapshot_grants.py::TestSnapshotGrantsDremio::test_snapshot_grants
+tests/component/test_profile_template.py::TestProfileTemplate::test_software_pat_options
+tests/component/test_profile_template.py::TestProfileTemplate::test_software_username_password_options
+tests/functional/adapter/basic/test_docs_generate.py::TestBaseDocsGenerateDremio::test_run_and_generate
+tests/functional/adapter/dremio_specific/test_exact_search.py::TestExactSearchEnabled::test_exact_match_succeeds
+tests/functional/adapter/dremio_specific/test_exact_search.py::TestExactSearchEnabled::test_ilike_match_succeeds
+tests/hooks/test_model_hooks.py::TestPrePostModelHooksInConfigDremio::test_pre_and_post_model_hooks_model
+tests/hooks/test_model_hooks.py::TestPrePostModelHooksInConfigWithCountDremio::test_pre_and_post_model_hooks_model_and_project
+tests/hooks/test_model_hooks.py::TestPrePostModelHooksInConfigKwargsDremio::test_pre_and_post_model_hooks_model
+tests/hooks/test_model_hooks.py::TestPrePostModelHooksUnderscoresDremio::test_pre_and_post_run_hooks

.github/scripts/profiles.yml

@@ -1,18 +1,3 @@
-test_cloud_options:
-  outputs:
-    dev:
-      dremio_space: '@user'
-      dremio_space_folder: no_schema
-      object_storage_path: no_schema
-      object_storage_source: $scratch
-      pat: dremio123
-      port: 9047
-      software_host: localhost
-      threads: 1
-      type: dremio
-      use_ssl: false
-      user: dremio
-  target: dev
 test_sw_pat_options:
   outputs:
     dev:

tests/component/test_profile_template.py

@@ -17,6 +17,7 @@
 
 from dbt.config.profile import read_profile
 from dbt.adapters.dremio.credentials import DremioCredentials
+from tests.utils.util import SOURCE
 
 # Tests require manual setup before executing.
 #
@@ -55,18 +56,17 @@ class TestProfileTemplate:
     _PAT_AUTH_PROFILE_OPTIONS_WITH_DEFAULTS = {"pat": None}
     _COMMON_PROFILE_OPTIONS_WITH_DEFAULTS = {
         "user": None,
-        "object_storage_source": "$scratch",
-        "object_storage_path": "no_schema",
-        "dremio_space": "@user",
-        "dremio_space_folder": "no_schema",
         "threads": 1,
     }
     _DREMIO_CLOUD_PROFILE_SPECIFIC_OPTIONS_WITH_DEFAULTS = {
-        "cloud_host": "api.dremio.cloud",
-        "cloud_project_id": None,
-        "use_ssl": True,
+        "dremio_space": SOURCE,
+        "dremio_space_folder": "space",
+        "object_storage_source": SOURCE,
+        "object_storage_path": "object_storage",
+        "use_ssl": False,
     }
     _DREMIO_SW_PROFILE_SPECIFIC_OPTIONS_WITH_DEFAULTS = {
+        "object_storage_source": "$scratch",
         "software_host": None,
         "port": 9047,
         "use_ssl": False,

tests/functional/adapter/dbt_clone/test_dbt_clone.py

@@ -21,21 +21,21 @@
 
 
 # Need to change the target_database to be the object_storage_source
-snapshot_sql = """
-{% snapshot my_cool_snapshot %}
+snapshot_sql = f"""
+{{% snapshot my_cool_snapshot %}}
 
-    {{
+    {{{{
         config(
-            target_database="dbt_test_source",
+            target_database="{SOURCE}",
             target_schema=schema,
             unique_key='id',
             strategy='check',
             check_cols=['id'],
         )
-    }}
-    select * from {{ ref('view_model') }}
+    }}}}
+    select * from {{{{ ref('view_model') }}}}
 
-{% endsnapshot %}
+{{% endsnapshot %}}
 """
 
 # Append _seeds to schemas of both targets

tests/functional/adapter/dremio_specific/test_persist_docs.py

@@ -25,7 +25,7 @@
 
 from build.lib.dbt.adapters.dremio.api.rest.client import DremioRestClient
 
-from tests.utils.util import BUCKET
+from tests.utils.util import BUCKET, SOURCE
 
 # Excluded seed
 _PROPERTIES__SCHEMA_YML = """
@@ -256,9 +256,8 @@ def _create_path_list(self, database, schema):
     def _get_relation_id(self, project, client, identifier):
         client.start()
 
-        # Replacing dbt_test to dbt_test_source if it is table
         if identifier == "table_model":
-            database = "dbt_test_source"
+            database = SOURCE 
         else:
             database = project.database
         schema = project.test_schema

tests/functional/adapter/dremio_specific/test_schema_parsing.py

@@ -19,6 +19,8 @@
     read_file,
     write_file,
 )
+from tests.utils.util import BUCKET
+
 test_schema_parsing = """
 {{
   config(
@@ -45,7 +47,7 @@ def update_config_file(self, updates, *paths):
 
     def test_schema_with_dots(self, project):
         self.update_config_file(
-            {"root_path": 'dbtdremios3."test.schema"'},
+            {"root_path": f'{BUCKET}."test.schema"'},
             project.profiles_dir,
             "profiles.yml",
         )

tests/functional/adapter/materialization/test_base_mat.py

@@ -31,7 +31,6 @@
 )
 from tests.utils.util import BUCKET
 
-# Unable to insert variable into docstring, so "dbt_test_source" is hardcoded
 schema_base_yml = """
 version: 2
 sources:

tests/utils/util.py

@@ -16,15 +16,17 @@
 from typing import List
 from contextlib import contextmanager
 from dbt.tests.util import AnyInteger
+import os
 
 from dbt.adapters.events.logging import AdapterLogger
 
 logger = AdapterLogger("dremio")
 
 # Ensure we do not include dashes in our source
 # https://github.com/dremio/dbt-dremio/issues/68
-BUCKET = "dbtdremios3"
-SOURCE = "dbt_test_source"
+# Use environment variable if present, otherwise use default value
+BUCKET = os.environ.get("DBT_DREMIO_S3_BUCKET", "dbtdremios3")
+SOURCE = os.environ.get("DBT_DREMIO_S3_SOURCE", "dbt_test_source")
 
 
 class TestProcessingException(Exception):
@@ -55,15 +57,15 @@ def relation_from_name(adapter, name: str, materialization=""):
         relation_parts.insert(0, credentials.datalake)
         if credentials.root_path not in [None, "no_schema"]:
             relation_parts.insert(1, credentials.root_path)
-    
+
 
     relation_type = "table" if materialization != "view" and "view" not in name else "view"
 
     schema = ".".join(relation_parts[1:-1])
 
     kwargs = {
         "database": relation_parts[0],
-        "schema": None if schema == "" else schema, 
+        "schema": None if schema == "" else schema,
         "identifier": relation_parts[-1],
         "type": relation_type,
     }
@@ -83,7 +85,7 @@ def get_connection(adapter, name="_test"):
         yield conn
 
 # Overwrite the default implementation to use this adapter's
-# relation_from_name function. 
+# relation_from_name function.
 def get_relation_columns(adapter, name):
     relation = relation_from_name(adapter, name)
     with get_connection(adapter):
@@ -92,7 +94,7 @@ def get_relation_columns(adapter, name):
 
 
 # Overwrite the default implementation to use this adapter's
-# relation_from_name function. 
+# relation_from_name function.
 def check_relation_types(adapter, relation_to_type):
     # Ensure that models with different materialiations have the
     # corrent table/view.
@@ -128,7 +130,7 @@ def check_relation_types(adapter, relation_to_type):
 
 
 # Overwrite the default implementation to use this adapter's
-# relation_from_name function. 
+# relation_from_name function.
 def check_relations_equal(adapter, relation_names: List, compare_snapshot_cols=False):
     # Replaces assertTablesEqual. assertManyTablesEqual can be replaced
     # by doing a separate call for each set of tables/relations.