-
Notifications
You must be signed in to change notification settings - Fork 34
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Is there an existing issue for this?
- I have searched the existing issues
Current Behavior
On many Operations, Dremio does not return the actual row count of the result sets as "rowCount", but instead a number related to the operation.
A good example is an insert: If you insert 1_000_000 rows into a table, Dremio will show a "rowCount" of 1_000_000 (Dremio 24.2.6). However, the result set of course only has one row - the number of inserted rows.
Due to the implementation here:
dbt-dremio/dbt/adapters/dremio/api/cursor.py
Line 172 in 9a9391e
| job_results( |
the cursor iterates over hundreds of thousands of empty resultsets.
Expected Behavior
As we cannot count on Dremio returning the number of results in "rowCount" we should probably just break when we hit the first empty batch of results.
Steps To Reproduce
No response
Environment
- OS: K8s
- dbt-dremio: 1.7.0
- Dremio Software: 24.2.6
- Dremio Cloud: -Relevant log output
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working