Zero is a valid value for an ID column, don't coerce it to NULL

stueynz · stueynz · commit 6e331b44f174 · 2015-12-07T15:48:54.000+13:00
diff --git a/lib/Drivers/DML/sqlite.js b/lib/Drivers/DML/sqlite.js
@@ -175,7 +175,8 @@ Driver.prototype.insert = function (table, data, keyProperties, cb) {
 		} else {
 			for (i = 0; i < keyProperties.length; i++) {
 				prop = keyProperties[i];
-				ids[prop.name] = data[prop.mapsTo] || null;
+                                // Zero is a valid value for an ID column
+				ids[prop.name] = data[prop.mapsTo] !== undefined ? data[prop.mapsTo] : null;
 			}
 			return cb(null, ids);
 		}

Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,8 @@ Driver.prototype.insert = function (table, data, keyProperties, cb) {`
`175`	`175`	`} else {`
`176`	`176`	`for (i = 0; i < keyProperties.length; i++) {`
`177`	`177`	`prop = keyProperties[i];`
`178`		`- ids[prop.name] = data[prop.mapsTo] \|\| null;`
	`178`	`+ // Zero is a valid value for an ID column`
	`179`	`+ ids[prop.name] = data[prop.mapsTo] !== undefined ? data[prop.mapsTo] : null;`
`179`	`180`	`}`
`180`	`181`	`return cb(null, ids);`
`181`	`182`	`}`