Changes many errors to use the ErrorCodes generator (#206)

Author: dresende

lib/Associations/Many.js

@@ -1,11 +1,12 @@
 var InstanceConstructor = require("../Instance").Instance;
 var Settings            = require("../Settings");
 var Property            = require("../Property");
+var ErrorCodes          = require("../ErrorCodes");
 
 exports.prepare = function (Model, associations) {
 	if (Model.keys.length > 1) {
 		Model.hasMany = function () {
-			throw new Error("Model.hasMany() does not support multiple keys models");
+			throw ErrorCodes.generateError(ErrorCodes.NO_SUPPORT, "Model.hasMany() does not support multiple keys models");
 		};
 		return;
 	}
@@ -209,7 +210,7 @@ function extendInstance(Model, Instance, Driver, association, opts, cb) {
 			                 typeof Instances[Instances.length - 1] == "function" ? Instances.pop() : noOperation);
 
 			if (Instances.length === 0) {
-				throw new Error("No associations defined");
+				throw ErrorCodes.generateError(ErrorCodes.PARAM_MISSMATCH, "No associations defined");
 			}
 
 			if (Array.isArray(Instances[0])) {

lib/Associations/One.js

@@ -56,7 +56,7 @@ exports.prepare = function (Model, associations, association_properties, model_f
 			}
 
 			if (conditions === null) {
-				throw new Error(".findBy" + assocName + "() is missing a conditions object");
+				throw ErrorCodes.generateError(ErrorCodes.PARAM_MISSMATCH, ".findBy(" + assocName + ") is missing a conditions object");
 			}
 
 			options.__merge = {

lib/Model.js

@@ -7,6 +7,7 @@ var Property        = require("./Property");
 var Singleton       = require("./Singleton");
 var Utilities       = require("./Utilities");
 var Validators      = require("./Validators");
+var ErrorCodes      = require("./ErrorCodes");
 
 exports.Model = Model;
 
@@ -161,7 +162,7 @@ function Model(opts) {
 			return this;
 		}
 
-		return cb(new Error("Driver does not support Model.drop()"));
+		return cb(ErrorCodes.generateError(ErrorCodes.NO_SUPPORT, "Driver does not support Model.drop()"));
 	};
 
 	model.sync = function (cb) {
@@ -181,7 +182,7 @@ function Model(opts) {
 			return this;
 		}
 
-		return cb(new Error("Driver does not support Model.sync()"));
+		return cb(ErrorCodes.generateError(ErrorCodes.NO_SUPPORT, "Driver does not support Model.sync()"));
 	};
 
 	model.get = function () {
@@ -191,7 +192,7 @@ function Model(opts) {
 		var cb         = ids.pop();
 
 		if (typeof cb != "function") {
-			throw new Error("Missing Model.get() callback");
+			throw ErrorCodes.generateError(ErrorCodes.MISSING_CALLBACK, "Missing Model.get() callback");
 		}
 
 		if (typeof ids[ids.length - 1] == "object" && !Array.isArray(ids[ids.length - 1])) {
@@ -203,7 +204,7 @@ function Model(opts) {
 		}
 
 		if (ids.length != opts.keys.length) {
-			throw new Error("Model.get() IDs number missmatch (" + opts.keys.length + " needed, " + ids.length + " passed)");
+			throw ErrorCodes.generateError(ErrorCodes.PARAM_MISSMATCH, "Model.get() IDs number missmatch (" + opts.keys.length + " needed, " + ids.length + " passed)");
 		}
 
 		for (var i = 0; i < opts.keys.length; i++) {
@@ -219,10 +220,10 @@ function Model(opts) {
 
 		opts.driver.find(model_fields, opts.table, conditions, { limit: 1 }, function (err, data) {
 			if (err) {
-				return cb(err);
+				return cb(ErrorCodes.generateError(ErrorCodes.QUERY_ERROR, err.message, { originalCode: err.code }));
 			}
 			if (data.length === 0) {
-				return cb(new Error("Not found"));
+				return cb(ErrorCodes.generateError(ErrorCodes.NOT_FOUND, "Not found"));
 			}
 			Singleton.get(opts.driver.uid + "/" + opts.table + "/" + ids.join("/"), {
 				cache      : (options.hasOwnProperty("cache") ? options.cache : opts.cache),
@@ -366,7 +367,7 @@ function Model(opts) {
 		}
 
 		if (cb === null) {
-			throw new Error("Model.one() called without callback");
+			throw ErrorCodes.generateError(ErrorCodes.MISSING_CALLBACK, "Missing Model.one() callback");
 		}
 
 		// add limit 1
@@ -397,7 +398,7 @@ function Model(opts) {
 		}
 
 		if (typeof cb != "function") {
-			throw new Error("Missing Model.count() callback");
+			throw ErrorCodes.generateError(ErrorCodes.MISSING_CALLBACK, "Missing Model.count() callback");
 		}
 
 		opts.driver.count(opts.table, conditions, {}, function (err, data) {
@@ -437,7 +438,7 @@ function Model(opts) {
 		var cb  = ids.pop();
 
 		if (typeof cb != "function") {
-			throw new Error("Missing Model.exists() callback");
+			throw ErrorCodes.generateError(ErrorCodes.MISSING_CALLBACK, "Missing Model.exists() callback");
 		}
 
 		var conditions = {}, i;